From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3292C3B8BC0 for ; Wed, 1 Apr 2026 21:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775077731; cv=none; b=Yhe7XPSpnvQMHWkVS+XQ6dlsNxqDXg9enbC9Ur0OH8I5UNSq06u8elAHYauYxkT7K+5yCf/6vrV+WSWWdynjHm0yxft48nyIMPZS/XjlhTgpYduN1Gw2c1p1BsSRY9xXo+91jQoclPITtKzdhfQ6S4nosqlz9a2HoiYEblQCBlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775077731; c=relaxed/simple; bh=fFZ5oJN3U/GRwKQIjCw0R7tvz9vv711GIXcprwT8jvU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=D6si+Tyg58vjEtfMU0RAU+9wNlGY0VSvie6TdwiXNuo0RNgkENVv4+R1THyqFKfcLUjhtUfJ60LnWsIeKrl4Xj1Ea8Lj/ZN0Om5F3RAiQHYnfu2YpOF4P+et8DaB4oZPXf0XPPCCSh+dE0ZUbBazj5qNfXlsCVSdiq0pysu4iOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=L9y/tadT; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="L9y/tadT" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2b249541063so972985ad.3 for ; Wed, 01 Apr 2026 14:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775077728; x=1775682528; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Pu8VN/18EKGWu9s98ZXH5MFFrHb1clMJomnWtLClx2s=; b=L9y/tadT2BeyBnSJgoriD89TDwQ/AHVYRdnl1v3MVcR+X6hMqSAn7bN+yUXuP/pL+Z 9F1RimtwT6PK8osSYXqorfShGpDcMd6xRle5XheGspDphtrKvRQ1Q9+jMx3OMDdGaWr+ 6LKD7kem2L00e/jlZ2t8mQ1T6Fe/dl206VjUoomT9JuLvs2nMb+8d4R/gHNY4XBS2btS Ydb39RwbXnMyJ1upmgv7+uwqaZG7xYuszyojvCAPzW7n+Dj7RBQHUqeQdI8PrN3ODIx1 HVccAIUaRTEdSs4y4cQ0zqDSM1jH0JIS49wlysqFDx6z3XwBEJdPitfC3oauDCG+m03o xmIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775077728; x=1775682528; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pu8VN/18EKGWu9s98ZXH5MFFrHb1clMJomnWtLClx2s=; b=gVM/U7+wiPEkzqkQ/5f0w9D657Q1NH1Ydu8WltGlErr5OIzlz5HhAtDTRsnUTl8Eio DGKx0EWKt7MWwUyWGaR6qYSOIz6pm4OaIzippZCeryqTxZ7/S/m7YFXVRvi8IJZoMa23 U+fEwjWvTOOTDfKYzRuy0VFp4n4TZJDIkpqIxSuqK1nCm9TEnrJId2WXLKap90qrfxTt UQZ0FKIqyUqiuTKbVDA5gnx6FWExCUIoPSf+E2lS4sUmuCAHYDia34fPr8064KZ+XoRs M7g3D/KNsNRjSM8yUtC3rsXCPchkY+mLv0Q9Ne0ONHRfpTZyLFZVWM8w0P81Lc1q3Cq+ 2OXA== X-Forwarded-Encrypted: i=1; AJvYcCUlUfqmoQTrrWYfNaQd+2b9iN9EgZhdY1FmIgppAZTdOycAB5FXe2DJdaiBxKuEqoKWktI=@vger.kernel.org X-Gm-Message-State: AOJu0YxMKid9VTqo14C+gYNzKKk2/3XWz92vFjLhCGmS1Sf5ZOBJV9Fy m39iwbTWiMG442WwAkycHMO52Yn/aS0VZ8GWqVxt8pgySAqbaErhz+kBVbuWiUsvcFqCwSsolwq tmRBFbw== X-Received: from plbka15.prod.google.com ([2002:a17:903:334f:b0:2b0:46bd:4fe5]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:248:b0:2b2:52fb:bf28 with SMTP id d9443c01a7336-2b269d08defmr45254965ad.46.1775077728024; Wed, 01 Apr 2026 14:08:48 -0700 (PDT) Date: Wed, 1 Apr 2026 14:08:46 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260326-gmem-inplace-conversion-v4-0-e202fe950ffd@google.com> <20260326-gmem-inplace-conversion-v4-25-e202fe950ffd@google.com> Message-ID: Subject: Re: [PATCH RFC v4 25/44] KVM: selftests: Test basic single-page conversion flow From: Sean Christopherson To: Ackerley Tng Cc: aik@amd.com, andrew.jones@linux.dev, binbin.wu@linux.intel.com, brauner@kernel.org, chao.p.peng@linux.intel.com, david@kernel.org, ira.weiny@intel.com, jmattson@google.com, jroedel@suse.de, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Jason Gunthorpe , Vlastimil Babka , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" On Tue, Mar 31, 2026, Ackerley Tng wrote: > Ackerley Tng writes: Please trim your replies (even more, since you did trim a little). > > +static void run_guest_do_rmw(struct kvm_vcpu *vcpu, loff_t pgoff, > > + char expected_val, char write_val) > > +{ > > + struct ucall uc; > > + int r; > > + > > + guest_data.mem = (void *)GUEST_MEMFD_SHARING_TEST_GVA + pgoff * page_size; > > + guest_data.expected_val = expected_val; > > + guest_data.write_val = write_val; > > + sync_global_to_guest(vcpu->vm, guest_data); > > + > > + do { > > + r = __vcpu_run(vcpu); > > + } while (r == -1 && errno == EINTR); > > + > > + TEST_ASSERT_EQ(r, 0); > > TEST_ASSERT_EQ() ends up calling exit() on failures, which skips > FIXTURE_TEARDOWN(). > > Other than the explicit assertions not working with the > kselftest_harness, kvm selftest library functions like vm_mem_add() also > call TEST_ASSERT, which doesn't play nice with kselftest_harness. > > Any suggestions for this? Should we use the kselftest framework with > these tests? > > (I ran into this issue while trying to test something else, where I > needed FIXTURE_TEARDOWN() to clean up system state.) > > Or is it "okay" in this case since FIXTURE_TEARDOWN() only cleans up > stuff that would happen if the program exits anyway? Can you see if any of the ideas in https://lore.kernel.org/all/ZjUwqEXPA5QVItyX@google.com would help? Converting more tests to TAP+FIXTURE is still on my wish list, I've just never been able to carve out cycles to see it through.