From: Sean Christopherson <seanjc@google.com>
To: Lei Chen <lei.chen@smartx.com>
Cc: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
kvm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
pbonzini@redhat.com, Igor Raits <igor@gooddata.com>,
Jan Cipa <jan.cipa@gooddata.com>
Subject: Re: [REGRESSION 6.19, BISECTED] KVM: x86: kvmclock rate-limit removal causes IPI storm and high guest steal time
Date: Wed, 1 Apr 2026 14:16:19 -0700 [thread overview]
Message-ID: <ac2LI_UPPrf45vmp@google.com> (raw)
In-Reply-To: <CAKcXpBzJ=ZNL=_XJBoG9sFXb0pt4JrF0wP3u_2eQSx-FizbOcQ@mail.gmail.com>
On Wed, Apr 01, 2026, Lei Chen wrote:
> Hi Jaroslav,
>
> I apologize for the late reply.
>
> I have reviewed the code and identified two scenarios that currently
> trigger the KVM_REQ_GLOBAL_CLOCK_UPDATE request:
>
> Scenario 1: kvm_write_system_time
> This code path occurs when the hypervisor (such as QEMU) adjusts the
> time, or when the guest writes to the TSC.
>
> Scenario 2: vcpu schedule in kvm_arch_vcpu_load
> If this function triggers KVM_REQ_GLOBAL_CLOCK_UPDATE, it indicates
> that the virtual machine is not using the master_clock.
>
> Those two cases are uncommon. Could you please provide your dmesg and
> help check which code path triggers KVM_REQ_GLOBAL_CLOCK_UPDATE?
I'm also mildly curious as to why KVM_REQ_GLOBAL_CLOCK_UPDATE is being
triggered, but I don't know that it matters. E.g. fixing the underlying flaw
(if one even exists) could fix Jaroslav's setup, but it won't fix setups where
the "uncommon" cases are unavoidable, e.g. on setups that _can't_ use a master
clock for whatever reason.
At a glance, explicitly ratelimiting kvm_gen_kvmclock_update() seems like the
simplest option to address the regression.
next prev parent reply other threads:[~2026-04-01 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 14:32 [REGRESSION 6.19, BISECTED] KVM: x86: kvmclock rate-limit removal causes IPI storm and high guest steal time Jaroslav Pulchart
2026-03-23 2:27 ` Lei Chen
2026-04-01 6:43 ` Lei Chen
2026-04-01 21:16 ` Sean Christopherson [this message]
2026-04-07 7:00 ` [PATCH v1] KVM: x86: Rate-limit global clock updates on vCPU load Lei Chen
-- strict thread matches above, loose matches on Subject: below --
2026-03-21 14:59 [REGRESSION 6.19, BISECTED] KVM: x86: kvmclock rate-limit removal causes IPI storm and high guest steal time Jaroslav Pulchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac2LI_UPPrf45vmp@google.com \
--to=seanjc@google.com \
--cc=igor@gooddata.com \
--cc=jan.cipa@gooddata.com \
--cc=jaroslav.pulchart@gooddata.com \
--cc=kvm@vger.kernel.org \
--cc=lei.chen@smartx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox