From: "Lai, Yi" <yi1.lai@linux.intel.com>
To: David Matlack <dmatlack@google.com>
Cc: Yi Lai <yi1.lai@intel.com>, Alex Williamson <alex@shazbot.org>,
Shuah Khan <shuah@kernel.org>,
Baolu Lu <baolu.lu@linux.intel.com>,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Alex Mastro <amastro@fb.com>
Subject: Re: [PATCH 0/2] vfio: selftests: Fix MMIO test failures in iommufd compat mode
Date: Mon, 23 Mar 2026 08:37:41 +0800 [thread overview]
Message-ID: <acCLVWggK3wru6aF@ly-workstation> (raw)
In-Reply-To: <CALzav=c5Sgv-x4LoCbJGdwuuQBr_4DQyZV=0vvnzG_16T3HtzA@mail.gmail.com>
On Fri, Mar 20, 2026 at 10:43:54AM -0700, David Matlack wrote:
> On Thu, Mar 19, 2026 at 9:03 PM Yi Lai <yi1.lai@intel.com> wrote:
> >
> > This series fixes two issues in the vfio_dma_mapping_mmio_test selftest when
> > running in iommufd compat mode.
> >
> > The first patch fixes a segmentation fault caused by an uninitialized list head
> > when __iommu_map() fails (as expected for MMIO regions in iommufd).
> >
> > The second patch fixes a test assertion failure by aligning the check for the
> > __iommu_unmap() return value based on the iommufd mode (native vs. compat).
>
> Alex Mastro also sent a fix for these issues here:
>
> https://lore.kernel.org/kvm/20260303-fix-mmio-test-v1-1-78b4a9e46a4e@fb.com/
>
> Can you take a look and see if it looks ok to you? I think I prefer
> Alex's fix. We shouldn't even be calling __iommu_unmap() after
> __iommu_map() fails.
Yes, just remove calling __iommu_unmap() is a more direct fix for the
two issues I encoutered. Agree with the fix.
prev parent reply other threads:[~2026-03-23 0:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 4:03 [PATCH 0/2] vfio: selftests: Fix MMIO test failures in iommufd compat mode Yi Lai
2026-03-20 4:03 ` [PATCH 1/2] vfio: selftests: Fix iommufd compat mode __iommu_unmap() crash Yi Lai
2026-03-20 4:03 ` [PATCH 2/2] vfio: selftests: Align __iommu_unmap() check with iommufd compat mode Yi Lai
2026-03-20 17:43 ` [PATCH 0/2] vfio: selftests: Fix MMIO test failures in " David Matlack
2026-03-23 0:37 ` Lai, Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acCLVWggK3wru6aF@ly-workstation \
--to=yi1.lai@linux.intel.com \
--cc=alex@shazbot.org \
--cc=amastro@fb.com \
--cc=baolu.lu@linux.intel.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=yi1.lai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox