From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C0DC31F98A for ; Tue, 24 Mar 2026 18:00:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774375209; cv=none; b=KxSDpZKcC66vXcUtflDrAlMYWH4P/J5++oBWElCY60AqPtDyQ8u+/twZXKavrwnbr11iPeYw1H8hFo1gdENNeIgQWIwza3tdHPL/V5N95ZFAzeTxVDNOLY2mY6mbftmKqALi1mgNjhLTqa3Vt8vfIBVffogY6Z4Y8G8Ue1g2W+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774375209; c=relaxed/simple; bh=CNHXMSmAUOWH+d0jWI2bXIfdmawcgqh7aZ6RTG+xo5U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RecpJd/LOiL+qmz5QFLEwA5bXo7NdIIUfFY8Z7h7OUuLCy4CLsMSdHnvGDKIH1naclb7lL6pMSlti4iY0ri8Zcozq4WNb9R6f9jE1RFfU/wx8Vi2QX3P8hZrnqXYw/QBfp7l4PtHIY3L2OCOzSr8quAhnZx42w7o4dyVumQ6a/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=r7wVIEoC; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="r7wVIEoC" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-82bae83318bso2211615b3a.2 for ; Tue, 24 Mar 2026 11:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774375206; x=1774980006; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oR1oDysYc7m3zFicPQmc7IfOCoKYgQXwHXDPwXVzCPk=; b=r7wVIEoCOuRMjg1YrOzsLz4l2c5jl76GG92F5jwCa8nLslFfASSUz+Zp+tQORELJnb +JKEqTMgU6RIZc2ixU4SqFBjyf6+NC353uFIuey58jHxgZbEf4n2ycQXYkNnJntauxdT GSLXNuKaPV6l3lxJBc3oEHl+1hiXvt3LiAwT4RU/GBDZ6r9qJ/ZG+A0mWUZXfi6Bce+4 1Yns8tDTQ1DQerp1zMZ/Tovj64NHaipROFcTrB/PfG3XD98BcK/AsSPR7k7eFamZhIs3 Eq52zG9yGOt8bcUobEwBIYZkH3+elTz+R0uwRqcpgrtVonqfQ8xmnV04mXasMFPM4r9t d0JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774375206; x=1774980006; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oR1oDysYc7m3zFicPQmc7IfOCoKYgQXwHXDPwXVzCPk=; b=iXH47YLvWWUzyfr5qeB9Iip/LVZqIXBZyKfKZ3WMRc7PXAxpM536Jpb4UHfc1IRqbS xFw/sRzy69eqP/WzdwaGrPnvSZVL5G1+HNQmooHh5Wxnv7M5l4V1yIBcnv2tjmdRptF0 jAh+UnKe+aXm6KWKvdOQnMutjnYBTj/mIS5P23dR8wBa/6t1LRw8AvqjoFlirfO3vSA+ tmxz9HdsP9gEyzQIhuD5RLicC4KEawEZTTmMLk2azUsiQkmMSZ6hZrhdCbx9vemNRtKP J8nnnvDY/0fGQM0s/gsD6VF3MO9Hm9CKanOixc+euRMuL41cwP3eQyKePquQE/GZa/LZ ITVA== X-Forwarded-Encrypted: i=1; AJvYcCVoY47z8+hgf7UdQc6Uo2q66HPErlKV90Ijmc62e+ZuqzJ+uuH71fcLqo9o4samFJ16aEU=@vger.kernel.org X-Gm-Message-State: AOJu0YyxHxtwQYSK3xQTWMsBqo9dOni0iHceEbo57AA/TdD/Rj+6T3LE AKiiqQYqjSo4C2dEj0ulr2tOU/awG22AjexSdTpJTfkFdp37gBFfVArGUi/w8vkx5Q== X-Gm-Gg: ATEYQzzOhQamc3LjCYZ+3nXR83TyZyye94WYU6Fa8xnAQliqQOeRDfb2oB8DbWSjkdL 2uPXapRO9MiRBLEL+BFqCOGUmVqH9hd0RtRnvN19bFUtzDrPztjnWxk7NESXyR2pWxv3xZFGbdk tuJCUPmXd24hy1ON8eOaTL57XKmX6358p+w8XGZspH0QA5g1Fsi8IC7B5qzqREtI1nEBFS9aglD x/KF/GK4ZEk+DGUjDiDw5ciUd0ALSVfrOP+LaCOnoyf6afZ9+VLCr8RZ/Ehn/X398kKz7hVBuCE lBZv6mJr+d3FdHzgfb+482a2K5aylRDLe6LAGl2bZi1wKtsADBt4nyCe6bAhHOft0xP2LEi/yBB 0D5Lm0KV3Kc20DTCN42d7kCnAgGy/Qs6oihKbBaAmpvrTh58+6Q5/II3NIXjtIy1qQ2LRYuqMTk p4UvPuE68NIyafL5s0KShrVd5zPOC4phSPrDd8lzpCHdCoL/EopPFt/7A8GFC77Q== X-Received: by 2002:a05:6a00:2da7:b0:827:3e19:574b with SMTP id d2e1a72fcca58-82c6e0bf7bamr488776b3a.43.1774375205765; Tue, 24 Mar 2026 11:00:05 -0700 (PDT) Received: from google.com (239.23.105.34.bc.googleusercontent.com. [34.105.23.239]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0421df0esm15901970b3a.58.2026.03.24.11.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 11:00:04 -0700 (PDT) Date: Tue, 24 Mar 2026 18:00:00 +0000 From: David Matlack To: Yi Liu Cc: Alex Williamson , Bjorn Helgaas , Adithya Jayachandran , Alexander Graf , Alex Mastro , Andrew Morton , Ankit Agrawal , Arnd Bergmann , Askar Safin , "Borislav Petkov (AMD)" , Chris Li , Dapeng Mi , David Rientjes , Feng Tang , Jacob Pan , Jason Gunthorpe , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Kees Cook , Kevin Tian , kexec@lists.infradead.org, kvm@vger.kernel.org, Leon Romanovsky , Leon Romanovsky , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Li RongQing , Lukas Wunner , Marco Elver , =?utf-8?Q?Micha=C5=82?= Winiarski , Mike Rapoport , Parav Pandit , Pasha Tatashin , "Paul E. McKenney" , Pawan Gupta , "Peter Zijlstra (Intel)" , Pranjal Shrivastava , Pratyush Yadav , Raghavendra Rao Ananta , Randy Dunlap , Rodrigo Vivi , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Vipin Sharma , Vivek Kasireddy , William Tu , Zhu Yanjun Subject: Re: [PATCH v3 03/24] PCI: Require Live Update preserved devices are in singleton iommu_groups Message-ID: References: <20260323235817.1960573-1-dmatlack@google.com> <20260323235817.1960573-4-dmatlack@google.com> <376910fa-4232-4e58-bf87-0504202866a5@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <376910fa-4232-4e58-bf87-0504202866a5@intel.com> On 2026-03-24 09:07 PM, Yi Liu wrote: > On 3/24/26 07:57, David Matlack wrote: > > Require that Live Update preserved devices are in singleton iommu_groups > > during preservation (outgoing kernel) and retrieval (incoming kernel). > > > > PCI devices preserved across Live Update will be allowed to perform > > memory transactions throughout the Live Update. Thus IOMMU groups for > > preserved devices must remain fixed. Since all current use cases for > > Live Update are for PCI devices in singleton iommu_groups, require that > > as a starting point. This avoids the complexity of needing to enforce > > arbitrary iommu_group topologies while still allowing all current use > > cases. > > > > Suggested-by: Jason Gunthorpe > > Signed-off-by: David Matlack > > --- > > drivers/pci/liveupdate.c | 34 +++++++++++++++++++++++++++++++++- > > 1 file changed, 33 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pci/liveupdate.c b/drivers/pci/liveupdate.c > > index bec7b3500057..a3dbe06650ff 100644 > > --- a/drivers/pci/liveupdate.c > > +++ b/drivers/pci/liveupdate.c > > @@ -75,6 +75,8 @@ > > * > > * * The device must not be a Physical Function (PF). > > * > > + * * The device must be the only device in its IOMMU group. > > + * > > * Preservation Behavior > > * ===================== > > * > > @@ -105,6 +107,7 @@ > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -222,6 +225,31 @@ static void pci_ser_delete(struct pci_ser *ser, struct pci_dev *dev) > > ser->nr_devices--; > > } > > +static int count_devices(struct device *dev, void *__nr_devices) > > +{ > > + (*(int *)__nr_devices)++; > > + return 0; > > +} > > + > > there was a related discussion on the singleton group check. have you > considered the device_group_immutable_singleton() in below link? > > https://lore.kernel.org/linux-iommu/20220421052121.3464100-4-baolu.lu@linux.intel.com/ Thanks for the link. Based on the discussion in the follow-up threads, I think the only check in that function that is needed on top of what is in this patch to ensure group immutability is this one: /* * The device could be considered to be fully isolated if * all devices on the path from the device to the host-PCI * bridge are protected from peer-to-peer DMA by ACS. */ if (!pci_acs_path_enabled(pdev, NULL, REQ_ACS_FLAGS)) return false; However, this would restrict Live Update support to only device topologies that have these flags enabled. I am not yet sure if this would be overly restrictive for the scenarios we care about supporting. An alternative way to ensure immutability would be to block adding devices at probe time. i.e. Fail pci_device_group() if the device being added has liveupdate_incoming=True, or if the group already contains a device with liveupdate_{incoming,outgoing}=True. We would still need the check in pci_liveupdate_preserve() to pretect against setting liveupdate_outgoing=True on a device in a multi-device group.