From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1180C28CBC for ; Wed, 6 May 2020 14:03:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5BF62070B for ; Wed, 6 May 2020 14:03:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728897AbgEFODz (ORCPT ); Wed, 6 May 2020 10:03:55 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33800 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728850AbgEFODy (ORCPT ); Wed, 6 May 2020 10:03:54 -0400 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 046Dw2n6140906; Wed, 6 May 2020 10:03:53 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 30s4gw2epn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 May 2020 10:03:52 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 046DXjCJ141035; Wed, 6 May 2020 10:03:41 -0400 Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 30s4gw2eeh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 May 2020 10:03:41 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 046E0S3B019645; Wed, 6 May 2020 14:03:28 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03ams.nl.ibm.com with ESMTP id 30s0g5sb3y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 May 2020 14:03:28 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 046E2GJq10420612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 May 2020 14:02:16 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B9CBF11C050; Wed, 6 May 2020 14:03:25 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B10F11C052; Wed, 6 May 2020 14:03:25 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.51.179]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 6 May 2020 14:03:25 +0000 (GMT) Subject: Re: [kvm-unit-tests RFC] s390x: Add Protected VM support To: Marc Hartmayer , kvm@vger.kernel.org Cc: Thomas Huth , David Hildenbrand , Cornelia Huck , Andrew Jones , Paolo Bonzini , Christian Borntraeger , linux-s390@vger.kernel.org References: <20200506124636.21876-1-mhartmay@linux.ibm.com> From: Janosch Frank Autocrypt: addr=frankja@linux.ibm.com; prefer-encrypt=mutual; keydata= mQINBFubpD4BEADX0uhkRhkj2AVn7kI4IuPY3A8xKat0ihuPDXbynUC77mNox7yvK3X5QBO6 qLqYr+qrG3buymJJRD9xkp4mqgasHdB5WR9MhXWKH08EvtvAMkEJLnqxgbqf8td3pCQ2cEpv 15mH49iKSmlTcJ+PvJpGZcq/jE42u9/0YFHhozm8GfQdb9SOI/wBSsOqcXcLTUeAvbdqSBZe zuMRBivJQQI1esD9HuADmxdE7c4AeMlap9MvxvUtWk4ZJ/1Z3swMVCGzZb2Xg/9jZpLsyQzb lDbbTlEeyBACeED7DYLZI3d0SFKeJZ1SUyMmSOcr9zeSh4S4h4w8xgDDGmeDVygBQZa1HaoL Esb8Y4avOYIgYDhgkCh0nol7XQ5i/yKLtnNThubAcxNyryw1xSstnKlxPRoxtqTsxMAiSekk 0m3WJwvwd1s878HrQNK0orWd8BzzlSswzjNfQYLF466JOjHPWFOok9pzRs+ucrs6MUwDJj0S cITWU9Rxb04XyigY4XmZ8dywaxwi2ZVTEg+MD+sPmRrTw+5F+sU83cUstuymF3w1GmyofgsU Z+/ldjToHnq21MNa1wx0lCEipCCyE/8K9B9bg9pUwy5lfx7yORP3JuAUfCYb8DVSHWBPHKNj HTOLb2g2UT65AjZEQE95U2AY9iYm5usMqaWD39pAHfhC09/7NQARAQABtCVKYW5vc2NoIEZy YW5rIDxmcmFua2phQGxpbnV4LmlibS5jb20+iQI3BBMBCAAhBQJbm6Q+AhsjBQsJCAcCBhUI CQoLAgQWAgMBAh4BAheAAAoJEONU5rjiOLn4p9gQALjkdj5euJVI2nNT3/IAxAhQSmRhPEt0 AmnCYnuTcHRWPujNr5kqgtyER9+EMQ0ZkX44JU2q7OWxTdSNSAN/5Z7qmOR9JySvDOf4d3mS bMB5zxL9d8SbnSs1uW96H9ZBTlTQnmLfsiM9TetAjSrR8nUmjGhe2YUhJLR1v1LguME+YseT eXnLzIzqqpu311/eYiiIGcmaOjPCE+vFjcXL5oLnGUE73qSYiujwhfPCCUK0850o1fUAYq5p CNBCoKT4OddZR+0itKc/cT6NwEDwdokeg0+rAhxb4Rv5oFO70lziBplEjOxu3dqgIKbHbjza EXTb+mr7VI9O4tTdqrwJo2q9zLqqOfDBi7NDvZFLzaCewhbdEpDYVu6/WxprAY94hY3F4trT rQMHJKQENtF6ZTQc9fcT5I3gAmP+OEvDE5hcTALpWm6Z6SzxO7gEYCnF+qGXqp8sJVrweMub UscyLqHoqdZC2UG4LQ1OJ97nzDpIRe0g6oJ9ZIYHKmfw5jjwH6rASTld5MFWajWdNsqK15k/ RZnHAGICKVIBOBsq26m4EsBlfCdt3b/6emuBjUXR1pyjHMz2awWzCq6/6OWs5eANZ0sdosNq dq2v0ULYTazJz2rlCXV89qRa7ukkNwdBSZNEwsD4eEMicj1LSrqWDZMAALw50L4jxaMD7lPL jJbauQINBFubpD4BEADAcUTRqXF/aY53OSH7IwIK9lFKxIm0IoFkOEh7LMfp7FGzaP7ANrZd cIzhZi38xyOkcaFY+npGEWvko7rlIAn0JpBO4x3hfhmhBD/WSY8LQIFQNNjEm3vzrMo7b9Jb JAqQxfbURY3Dql3GUzeWTG9uaJ00u+EEPlY8zcVShDltIl5PLih20e8xgTnNzx5c110lQSu0 iZv2lAE6DM+2bJQTsMSYiwKlwTuv9LI9Chnoo6+tsN55NqyMxYqJgElk3VzlTXSr3+rtSCwf tq2cinETbzxc1XuhIX6pu/aCGnNfuEkM34b7G1D6CPzDMqokNFbyoO6DQ1+fW6c5gctXg/lZ 602iEl4C4rgcr3+EpfoPUWzKeM8JXv5Kpq4YDxhvbitr8Dm8gr38+UKFZKlWLlwhQ56r/zAU v6LIsm11GmFs2/cmgD1bqBTNHHcTWwWtRTLgmnqJbVisMJuYJt4KNPqphTWsPY8SEtbufIlY HXOJ2lqUzOReTrie2u0qcSvGAbSfec9apTFl2Xko/ddqPcZMpKhBiXmY8tJzSPk3+G4tqur4 6TYAm5ouitJsgAR61Cu7s+PNuq/pTLDhK+6/Njmc94NGBcRA4qTuysEGE79vYWP2oIAU4Fv6 gqaWHZ4MEI2XTqH8wiwzPdCQPYsSE0fXWiYu7ObeErT6iLSTZGx4rQARAQABiQIfBBgBCAAJ BQJbm6Q+AhsMAAoJEONU5rjiOLn4DDEP/RuyckW65SZcPG4cMfNgWxZF8rVjeVl/9PBfy01K 8R0hajU40bWtXSMiby7j0/dMjz99jN6L+AJHJvrLz4qYRzn2Ys843W+RfXj62Zde4YNBE5SL jJweRCbMWKaJLj6499fctxTyeb9+AMLQS4yRSwHuAZLmAb5AyCW1gBcTWZb8ON5BmWnRqeGm IgC1EvCnHy++aBnHTn0m+zV89BhTLTUal35tcjUFwluBY39R2ux/HNlBO1GY3Z+WYXhBvq7q katThLjaQSmnOrMhzqYmdShP1leFTVbzXUUIYv/GbynO/YrL2gaQpaP1bEUEi8lUAfXJbEWG dnHFkciryi092E8/9j89DJg4mmZqOau7TtUxjRMlBcIliXkzSLUk+QvD4LK1kWievJse4mte FBdkWHfP4BH/+8DxapRcG1UAheSnSRQ5LiO50annOB7oXF+vgKIaie2TBfZxQNGAs3RQ+bga DchCqFm5adiSP5+OT4NjkKUeGpBe/aRyQSle/RropTgCi85pje/juYEn2P9UAgkfBJrOHvQ9 Z+2Sva8FRd61NJLkCJ4LFumRn9wQlX2icFbi8UDV3do0hXJRRYTWCxrHscMhkrFWLhYiPF4i phX7UNdOWBQ90qpHyAxHmDazdo27gEjfvsgYMdveKknEOTEb5phwxWgg7BcIDoJf9UMC Message-ID: Date: Wed, 6 May 2020 16:03:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200506124636.21876-1-mhartmay@linux.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jZut8F33B4APfBdtVC0v4hTbISFH8KYqm" X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-05-06_07:2020-05-05,2020-05-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 bulkscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005060108 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jZut8F33B4APfBdtVC0v4hTbISFH8KYqm Content-Type: multipart/mixed; boundary="4hBbH78mIQ1Qsi4w7wHYYnvkZXsvYfagY" --4hBbH78mIQ1Qsi4w7wHYYnvkZXsvYfagY Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/6/20 2:46 PM, Marc Hartmayer wrote: > Add support for Protected Virtual Machine (PVM) tests. For starting a > PVM guest we must be able to generate a PVM image by using the > `genprotimg` tool from the s390-tools collection. This requires the > ability to pass a machine-specific host-key document, so the option > `--host-key-document` is added to the configure script. >=20 > Signed-off-by: Marc Hartmayer > --- > .gitignore | 1 + > configure | 8 ++++++++ > s390x/Makefile | 16 +++++++++++++--- > s390x/unittests.cfg | 20 ++++++++++++++++++++ > scripts/common.bash | 30 +++++++++++++++++++++++++++++- > 5 files changed, 71 insertions(+), 4 deletions(-) >=20 > diff --git a/.gitignore b/.gitignore > index 784cb2ddbcb8..1fa5c0c0ea76 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -4,6 +4,7 @@ > *.o > *.flat > *.elf > +*.img > .pc > patches > .stgit-* > diff --git a/configure b/configure > index 5d2cd90cd180..29191f4b0994 100755 > --- a/configure > +++ b/configure > @@ -18,6 +18,7 @@ u32_long=3D > vmm=3D"qemu" > errata_force=3D0 > erratatxt=3D"errata.txt" > +host_key_document=3D > =20 > usage() { > cat <<-EOF > @@ -40,6 +41,8 @@ usage() { > no environ is provided by the user (enable= d by default) > --erratatxt=3DFILE specify a file to use instead of errata.= txt. Use > '--erratatxt=3D' to ensure no file is used= =2E > + --host-key-document=3DHOST_KEY_DOCUMENT > + host-key-document to use (s390x only) > EOF > exit 1 > } > @@ -91,6 +94,9 @@ while [[ "$1" =3D -* ]]; do > --erratatxt) > erratatxt=3D"$arg" > ;; > + --host-key-document) > + host_key_document=3D"$arg" > + ;; > --help) > usage > ;; > @@ -207,6 +213,8 @@ PRETTY_PRINT_STACKS=3D$pretty_print_stacks > ENVIRON_DEFAULT=3D$environ_default > ERRATATXT=3D$erratatxt > U32_LONG_FMT=3D$u32_long > +GENPROTIMG=3Dgenprotimg > +HOST_KEY_DOCUMENT=3D$host_key_document > EOF > =20 > cat < lib/config.h > diff --git a/s390x/Makefile b/s390x/Makefile > index ddb4b48ecbf9..a57655dcce10 100644 > --- a/s390x/Makefile > +++ b/s390x/Makefile > @@ -17,12 +17,19 @@ tests +=3D $(TEST_DIR)/stsi.elf > tests +=3D $(TEST_DIR)/skrf.elf > tests +=3D $(TEST_DIR)/smp.elf > tests +=3D $(TEST_DIR)/sclp.elf > -tests_binary =3D $(patsubst %.elf,%.bin,$(tests)) > =20 > -all: directories test_cases test_cases_binary > +tests_binary =3D $(patsubst %.elf,%.bin,$(tests)) > +ifneq ($(HOST_KEY_DOCUMENT),) > +tests_pv_img =3D $(patsubst %.elf,%.pv.img,$(tests)) > +else > +tests_pv_img =3D > +endif > + > +all: directories test_cases test_cases_binary test_cases_pv > =20 > test_cases: $(tests) > test_cases_binary: $(tests_binary) > +test_cases_pv: $(tests_pv_img) > =20 > CFLAGS +=3D -std=3Dgnu99 > CFLAGS +=3D -ffreestanding > @@ -68,8 +75,11 @@ FLATLIBS =3D $(libcflat) > %.bin: %.elf > $(OBJCOPY) -O binary $< $@ > =20 > +%.pv.img: %.bin $(HOST_KEY_DOCUMENT) > + $(GENPROTIMG) --host-key-document $(HOST_KEY_DOCUMENT) --no-verify --= image $< -o $@ > + > arch_clean: asm_offsets_clean > - $(RM) $(TEST_DIR)/*.{o,elf,bin} $(TEST_DIR)/.*.d lib/s390x/.*.d > + $(RM) $(TEST_DIR)/*.{o,elf,bin,img} $(TEST_DIR)/.*.d lib/s390x/.*.d > =20 > generated-files =3D $(asm-offsets) > $(tests:.elf=3D.o) $(cstart.o) $(cflatobjs): $(generated-files) > diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg > index b307329354f6..6beaca45fb20 100644 > --- a/s390x/unittests.cfg > +++ b/s390x/unittests.cfg > @@ -16,6 +16,8 @@ > # # a test. The check line can contain multiple files > # # to check separated by a space but each check > # # parameter needs to be of the form =3D > +# pv_support =3D 0|1 # Optionally specify whether a test support= s the > +# # execution as a PV guest. > ######################################################################= ######## > =20 > [selftest-setup] > @@ -25,62 +27,80 @@ extra_params =3D -append 'test 123' > =20 > [intercept] > file =3D intercept.elf > +pv_support =3D 1 So, let's do this discussion once more: Why would we need a opt-in for something which works on all our current tests? I'd much rather have a opt-out or just a bail-out when running the test like I already implemented for the storage key related tests... I don't see any benefit for this right now other than forcing me to add another line to this file that was not needed before.. --4hBbH78mIQ1Qsi4w7wHYYnvkZXsvYfagY-- --jZut8F33B4APfBdtVC0v4hTbISFH8KYqm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEwGNS88vfc9+v45Yq41TmuOI4ufgFAl6yw6wACgkQ41TmuOI4 ufhhERAAkTUnnUrCGEoa3BVcyMZVYPXyGcAmolczB8cGHjwutwO/z1wJd7vtCp/k b+F0ijNkWtWneYvYg+ONQRMbHFYhvVtUTdXE2LjPK16LlaDMh++Mra7+UpaPXws7 GgeRJohAtlcfaYLgqQkkzRki1XJS01P2meGBfithejYNaehGEi4rLB/9opJ1olsX pgdqthBbSvqAR83tGBWiafzodndpRBsdfcfEnoR+TYV5z3ZJ94AkIcw8cF2jT7se RKmRkX2FTt6/3I9RgH4Qh5JBb4ADm0mSr0k0aoDZ/mLePvXEsYPZ7H/4dWgwEaYx a3YPXLPcSbD0/Moq3dIimx3CnCNrbyulCoDNfamVZOYGdYMcAUSFmRFNWxfULYu2 8dLcuKQ+o82/gALuS1FSSp+dv772YplpZTP8vPYlXsn6dnmyozFRZFXItu1mc9TE xXCz01pVcOfNVC+gt0v0DDCR1pRiokrih4akGCJN+QCPwc9q7gKyCGXaUOD+tFAI 9CVI4s6PysOrebCjXN433wt+/qKDhfEE/f49qrRs0qwnX4/0cO4v2Q/tYwrC54d9 VYTmcUMk5Irrbrjl8DJib7Jeycy1Asq3dhsZuz51W+A9e8LZQJDWTWotuVm9H3R8 TjzcV4h1TJIvZT3btRqB01wFKWYpP1jhIawGhFHjgHcPT7d72rg= =MmXm -----END PGP SIGNATURE----- --jZut8F33B4APfBdtVC0v4hTbISFH8KYqm--