From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB94B318ED2 for ; Mon, 13 Apr 2026 16:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099304; cv=none; b=cUGvByYgbOOLII+Kv+J8Au9vpg34Hr/AYBF8sALaFIRfJATOqdd3JeSnKVmRyspoQeLES+K2iIlRHpzXVxsN8kIy5KSpp8+A4X/vAPDafD6zVLiBHlcz7Y6k0cUDK7NwLTv8dM0t8lfyUQBBW5kgFlZi7cZUtTxcjsJ2NTM7IdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776099304; c=relaxed/simple; bh=ClzR7UQzXTe3HzyCT4OZzGbXNT6kioWjGLs7pHzfNTU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ZiBJmNDQzavqljmMYqzlSorNUFCj6uwIi2xSDs0teWH0WO8as8IAaGRSuCmFaUWAD8+DJggi22VhFSrMe0dydKy5vivKpUOUhCo5gtwlxBktQNd84QoZ8zPWGWPIE0dDy8g/trS49rUMN2k+X2nruFkLkCj4S5/lb+D8elEJVC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eR/noyel; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eR/noyel" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-82c1e1a6cfbso3340667b3a.0 for ; Mon, 13 Apr 2026 09:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776099302; x=1776704102; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=j5j4sXGBcxPPwUarrcuWs3/BHde3gD/Q8o6gGTTOXhQ=; b=eR/noyelvPKY4t4gNo0X8WpmWr1v4bP0pFA+JOsmZZybQ9ymJMYyaL4cxqiwFsMBZm aFVJzk0ooc92ftS8wCatx+q9Z/HEglQfhvwimdnFgApkw21ik0xIgTWvZgGtxuKU1Gwp Qz4TX6U8efTk8nDO0zKpFGj06KPTU3a8RAfkxoSI10yjJbMsA6ZpmQncCCEAhjkswr8k 2QP3WB73Uz0WQ8Jbmq/H87wi+AOonnR3DpVzVWs9laZKh0cK23bhlxRnHhA7TQSnFKLq vuZXBLfCZGnChVA2NHNr3lq+H1ZKVN182hrdDZyO0pBHP2szH2Ic8oxa7KwTNHLM+70r 6Z6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776099302; x=1776704102; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j5j4sXGBcxPPwUarrcuWs3/BHde3gD/Q8o6gGTTOXhQ=; b=ZrVTnbRCY8sUeHRH15BShjzzrwiFrY8qV5+TFznnfN1zvBXM7fY40lnn43tsNO1QWN RovyZdQ80T4vmSOliwGBfbkMwhRIyEWvpxpX2G/0l93830fB13cpXvNF8OvrGyE3tqHs itVhFZqOMiD0U30KfouXjR47Qdi116yC6Ur0IQSoY2iKFtyItRDnpqxpo/XeRVQCtffD f44g7PMkUNpbr5++yzCYLLpbRwMhepNXXhsLAR189M3nZJ35bN9EF1NJlaISWw5Me05u SPc6pO+RgAebRHO4DPil1Qe2N+QRLGBEjtMpX/wELyJQIyBbP5iXRHNo6tVY1xFOzVBc ZJyQ== X-Forwarded-Encrypted: i=1; AFNElJ/wmwCxPsEef/Krtpdkd8zEOWdbX5Sj1WScq6RqrW8OmEVWPnqLPdAI0GIJNSoiMi4xyCc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1+ltgHkjjt9O7sFgwnIRniydzVE7tktDnWnxGWSl3staPaWjN +9z45E+/7Lx8/cK1WDs3GyGDFCKF842W33ckAferxaABDHqOmqAwykeIVVA3bqSW1ga4PcozSMW FtJ78vw== X-Received: from pfgu29.prod.google.com ([2002:a05:6a00:99d:b0:82f:4d28:b8c5]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:aa09:b0:829:88e7:c88b with SMTP id d2e1a72fcca58-82f0c2ad4a8mr14168457b3a.19.1776099302146; Mon, 13 Apr 2026 09:55:02 -0700 (PDT) Date: Mon, 13 Apr 2026 09:55:00 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <202604131813.Sp3bcsFp-lkp@intel.com> Message-ID: Subject: Re: [kvm:queue 12/12] arch/x86/kvm/svm/avic.c:240:39: error: passing argument 1 of 'is_sev_es_guest' from incompatible pointer type From: Sean Christopherson To: Paolo Bonzini Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, kvm@vger.kernel.org, Farrah Chen Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 13, 2026, Paolo Bonzini wrote: > On Mon, Apr 13, 2026 at 6:42=E2=80=AFPM Sean Christopherson wrote: > > > > On Mon, Apr 13, 2026, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue > > > head: 8f65c76d62f1f07d68b8a14829a59049311547b1 > > > commit: 8f65c76d62f1f07d68b8a14829a59049311547b1 [12/12] Merge tag 'k= vm-x86-svm-7.1' of https://github.com/kvm-x86/linux into HEAD > > > config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/= 20260413/202604131813.Sp3bcsFp-lkp@intel.com/config) > > > compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 > > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/a= rchive/20260413/202604131813.Sp3bcsFp-lkp@intel.com/reproduce) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new = version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202604131813.Sp3bcsFp= -lkp@intel.com/ > > > > > > All errors (new ones prefixed by >>): > > > > > > arch/x86/kvm/svm/avic.c: In function 'avic_deactivate_vmcb': > > > >> arch/x86/kvm/svm/avic.c:240:39: error: passing argument 1 of 'is_s= ev_es_guest' from incompatible pointer type [-Wincompatible-pointer-types] > > > 240 | if (!is_sev_es_guest(svm->vcpu.kvm)) > > > | ~~~~~~~~~^~~~ > > > | | > > > | struct kvm * > > > In file included from arch/x86/kvm/svm/avic.c:31: > > > arch/x86/kvm/svm/svm.h:415:62: note: expected 'struct kvm_vcpu *' = but argument is of type 'struct kvm *' > > > 415 | static __always_inline bool is_sev_es_guest(struct kvm_vcp= u *vcpu) > > > | ~~~~~~~~~~~~~~= ~~~^~~~ > > > > > > > > > vim +/is_sev_es_guest +240 arch/x86/kvm/svm/avic.c > > > > > > 232 > > > 233 static void avic_deactivate_vmcb(struct vcpu_svm *svm) > > > 234 { > > > 235 struct vmcb *vmcb =3D svm->vmcb01.ptr; > > > 236 > > > 237 vmcb->control.int_ctl &=3D ~(AVIC_ENABLE_MASK |= X2APIC_MODE_MASK); > > > 238 vmcb->control.avic_physical_id &=3D ~AVIC_PHYSI= CAL_MAX_INDEX_MASK; > > > 239 > > > > 240 if (!is_sev_es_guest(svm->vcpu.kvm)) > > > 241 svm_set_intercept(svm, INTERCEPT_CR8_WR= ITE); > > > > Ha! Not my fault :-) >=20 > Yes, I have already pushed the right one. Heh, nope :-) diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c index 56f38a851c1b..adf211860949 100644 --- a/arch/x86/kvm/svm/avic.c +++ b/arch/x86/kvm/svm/avic.c @@ -237,7 +237,7 @@ static void avic_deactivate_vmcb(struct vcpu_svm *svm) vmcb->control.int_ctl &=3D ~(AVIC_ENABLE_MASK | X2APIC_MODE_MASK); vmcb->control.avic_physical_id &=3D ~AVIC_PHYSICAL_MAX_INDEX_MASK; =20 - if (!is_sev_es_guest(svm->vcpu)) + if (!is_sev_es_guest(&svm->vcpu)) svm_set_intercept(svm, INTERCEPT_CR8_WRITE); =20 /*