Re: [PATCH 07/17] KVM: x86/tdp_mmu: Centralize updates to present external PTEs

Sean Christopherson
2026-04-02T23:21:18Z

On Wed, Apr 01, 2026, Rick P Edgecombe wrote:
> On Tue, 2026-03-31 at 10:09 +0000, Huang, Kai wrote:
> > > @@ -1373,6 +1396,9 @@ static void kvm_tdp_mmu_age_spte(struct kvm *kvm,
> > > struct tdp_iter *iter)
> > >   {
> > >    u64 new_spte;
> > >
> > > + if (WARN_ON_ONCE(is_mirror_sptep(iter->sptep)))
> > > + return;
> > > +
> > >    if (spte_ad_enabled(iter->old_spte)) {
> > >    iter->old_spte = tdp_mmu_clear_spte_bits_atomic(iter-
> > > >sptep,
> > >    shadow_acce
> > > ssed_mask);
> >
> > AFAICT this chunk isn't related to "Centralize updates to present external
> > PTEs"?  Should it be in a separate patch?
>
> It was because we lose warning coverage in this patch for the aging case. Though
> the diff was from Sean. But my take was this just maintains coverage that
> already existed.

Yep, exactly.