Re: [PATCH 0/8] tree-wide: use g_clear_handle_id() for GSource cleanup

Matthew Penney
2026-04-08T10:13:02Z

Hi Daniel,

Thanks for the quick response.

I can confirm that I authored the commits in the series - the 'QEMU Token' user
just corresponds to the project access token I created and used to push my
work.

The redundant branches (e.g. 'b4/g-source-cleanup') were from previous attempts
to format and send the series properly.

Hopefully this clears up any confusion around authorship.

Best regards,
Matthew

Sent with Proton Mail secure email.

On Wednesday, 8 April 2026 at 09:40, Daniel P. Berrangé <berrange@redhat.com> wrote:

> On Wed, Apr 08, 2026 at 01:01:42AM +0000, Matthew Penney wrote:
> > This series replaces open-coded uses of g_source_remove() with
> > g_clear_handle_id() across the tree.
> >
> > This is a more modern (GLib >= 2.56) approach than directly calling
> > g_source_remove().
> >
> > g_clear_handle_id() simplifies cleanup of GSource IDs since it
> > checks the ID is valid, calls the cleanup function and zeros the ID.
> >
> > This reduces boilerplate and avoids open-coded calls to
> > g_source_remove().
> >
> > This series follows an earlier fix that removed a dangling GSource tag
> > and replaced an explicit call to g_source_remove() with
> > g_clear_handle_id().
> >
> > No functional changes.
> >
> > Link: https://gitlab.com/qemu-project/qemu/-/commit/34aad589019c8687fb3b19ba79d64d97071a7205
>
> Looking at your git repo fork, while the commits are creditted under
> your name, all the activity on the repo appears to have done by a bot
> account:
>
> https://gitlab.com/mj-penney/qemu/activity
>
> What's the situation here with authorship ?
>
> With regards,
> Daniel
> --
> |: https://berrange.com ~~ https://hachyderm.io/@berrange :|
> |: https://libvirt.org ~~ https://entangle-photo.org :|
> |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
>
>