From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roland Dreier <rdreier@cisco.com>
Subject: Re: [PATCH] regression: vmalloc easily fail.
Date: Tue, 28 Oct 2008 15:03:20 -0700
Message-ID: <adad4hkml7b.fsf@cisco.com>
References: <1225234513-3996-1-git-send-email-glommer@redhat.com>
	<49077E1A.5080105@redhat.com> <ada7i7so1o7.fsf@cisco.com>
	<20081028144255.05712d70@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Glauber Costa <glommer@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	aliguori@codemonkey.ws, npiggin@suse.de,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Krzysztof Helt <krzysztof.h1@poczta.fm>
To: Arjan van de Ven <arjan@infradead.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from sj-iport-6.cisco.com ([171.71.176.117]:40294 "EHLO
	sj-iport-6.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753084AbYJ1WDW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 28 Oct 2008 18:03:22 -0400
In-Reply-To: <20081028144255.05712d70@infradead.org> (Arjan van de Ven's
	message of "Tue, 28 Oct 2008 14:42:55 -0700")
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

 > I suspect it's a case of off-by-one... ALIGN() might round down, and
 > the "+ (PAGE_SIZE-1)" was there to make it round up.
 > Except for that missing -1 ...

ALIGN() has always rounded up, at least back to 2.4.