kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [PATCH v2 23/24] Refactor kvm&tcg function names in cpus.c
Date: Tue,  1 Feb 2011 22:16:03 +0100	[thread overview]
Message-ID: <ae24f42b04106da3d61a537d9035b27bc8730d04.1296594961.git.jan.kiszka@web.de> (raw)
In-Reply-To: <cover.1296594961.git.jan.kiszka@web.de>
In-Reply-To: <cover.1296594961.git.jan.kiszka@web.de>

From: Jan Kiszka <jan.kiszka@siemens.com>

Pure interface cosmetics: Ensure that only kvm core services (as
declared in kvm.h) start with "kvm_". Prepend "qemu_" to those that
violate this rule in cpus.c. Also rename the corresponding tcg functions
for the sake of consistency.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 cpus.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/cpus.c b/cpus.c
index 9c50a34..0d11a20 100644
--- a/cpus.c
+++ b/cpus.c
@@ -778,7 +778,7 @@ static void qemu_kvm_wait_io_event(CPUState *env)
 
 static int qemu_cpu_exec(CPUState *env);
 
-static void *kvm_cpu_thread_fn(void *arg)
+static void *qemu_kvm_cpu_thread_fn(void *arg)
 {
     CPUState *env = arg;
     int r;
@@ -811,7 +811,7 @@ static void *kvm_cpu_thread_fn(void *arg)
     return NULL;
 }
 
-static void *tcg_cpu_thread_fn(void *arg)
+static void *qemu_tcg_cpu_thread_fn(void *arg)
 {
     CPUState *env = arg;
 
@@ -930,7 +930,7 @@ void resume_all_vcpus(void)
     }
 }
 
-static void tcg_init_vcpu(void *_env)
+static void qemu_tcg_init_vcpu(void *_env)
 {
     CPUState *env = _env;
     /* share a single thread for all cpus with TCG */
@@ -938,7 +938,7 @@ static void tcg_init_vcpu(void *_env)
         env->thread = qemu_mallocz(sizeof(QemuThread));
         env->halt_cond = qemu_mallocz(sizeof(QemuCond));
         qemu_cond_init(env->halt_cond);
-        qemu_thread_create(env->thread, tcg_cpu_thread_fn, env);
+        qemu_thread_create(env->thread, qemu_tcg_cpu_thread_fn, env);
         while (env->created == 0)
             qemu_cond_timedwait(&qemu_cpu_cond, &qemu_global_mutex, 100);
         tcg_cpu_thread = env->thread;
@@ -949,12 +949,12 @@ static void tcg_init_vcpu(void *_env)
     }
 }
 
-static void kvm_start_vcpu(CPUState *env)
+static void qemu_kvm_start_vcpu(CPUState *env)
 {
     env->thread = qemu_mallocz(sizeof(QemuThread));
     env->halt_cond = qemu_mallocz(sizeof(QemuCond));
     qemu_cond_init(env->halt_cond);
-    qemu_thread_create(env->thread, kvm_cpu_thread_fn, env);
+    qemu_thread_create(env->thread, qemu_kvm_cpu_thread_fn, env);
     while (env->created == 0)
         qemu_cond_timedwait(&qemu_cpu_cond, &qemu_global_mutex, 100);
 }
@@ -966,9 +966,9 @@ void qemu_init_vcpu(void *_env)
     env->nr_cores = smp_cores;
     env->nr_threads = smp_threads;
     if (kvm_enabled())
-        kvm_start_vcpu(env);
+        qemu_kvm_start_vcpu(env);
     else
-        tcg_init_vcpu(env);
+        qemu_tcg_init_vcpu(env);
 }
 
 void qemu_notify_event(void)
-- 
1.7.1


  parent reply	other threads:[~2011-02-01 21:17 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 21:15 [PATCH v2 00/24] [uq/master] Patch queue, part II Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 01/24] kvm: x86: Fix build in absence of KVM_CAP_ASYNC_PF Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 02/24] Prevent abortion on multiple VCPU kicks Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 03/24] Stop current VCPU on synchronous reset requests Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 04/24] Process vmstop requests in IO thread Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 05/24] Trigger exit from cpu_exec_all on pending IO events Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 06/24] Leave inner main_loop faster on pending requests Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 07/24] Flatten the main loop Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 08/24] kvm: Report proper error on GET_VCPU_MMAP_SIZE failures Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 09/24] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 10/24] kvm: Handle kvm_init_vcpu errors Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 11/24] kvm: Provide sigbus services arch-independently Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 12/24] Refactor signal setup functions in cpus.c Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 13/24] kvm: Set up signal mask also for !CONFIG_IOTHREAD Jan Kiszka
2011-02-28 15:55   ` Avi Kivity
2011-02-28 16:02     ` Jan Kiszka
2011-02-28 16:05       ` Jan Kiszka
2011-02-28 16:16     ` Jan Kiszka
2011-02-28 16:45       ` Avi Kivity
2011-02-28 16:48         ` Avi Kivity
2011-02-28 16:49         ` Jan Kiszka
2011-02-28 16:54           ` Avi Kivity
2011-03-01  8:39             ` Avi Kivity
2011-03-01  8:58               ` Jan Kiszka
2011-03-01  9:03                 ` Avi Kivity
2011-02-01 21:15 ` [PATCH v2 14/24] kvm: Refactor qemu_kvm_eat_signals Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 15/24] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 16/24] Set up signalfd " Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 17/24] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 18/24] kvm: Add MCE signal support for !CONFIG_IOTHREAD Jan Kiszka
2011-02-01 21:15 ` [PATCH v2 19/24] Introduce VCPU self-signaling service Jan Kiszka
2011-02-01 21:16 ` [PATCH v2 20/24] kvm: Unconditionally reenter kernel after IO exits Jan Kiszka
2011-02-01 21:16 ` [PATCH v2 21/24] kvm: Remove static return code of kvm_handle_io Jan Kiszka
2011-02-01 21:16 ` [PATCH v2 22/24] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN Jan Kiszka
2011-02-01 21:16 ` Jan Kiszka [this message]
2011-02-01 21:16 ` [PATCH v2 24/24] Fix a few coding style violations in cpus.c Jan Kiszka
2011-02-04 13:54 ` [PATCH v2 00/24] [uq/master] Patch queue, part II Marcelo Tosatti
2011-02-04 16:29   ` Jan Kiszka
2011-02-04 16:37     ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae24f42b04106da3d61a537d9035b27bc8730d04.1296594961.git.jan.kiszka@web.de \
    --to=jan.kiszka@web.de \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).