From: "Nikunj A. Dadhania" <nikunj@amd.com>
To: Dave Hansen <dave.hansen@intel.com>,
linux-kernel@vger.kernel.org, thomas.lendacky@amd.com,
x86@kernel.org, kvm@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: bp@alien8.de, mingo@redhat.com, tglx@linutronix.de,
dave.hansen@linux.intel.com, dionnaglaze@google.com,
pgonda@google.com, seanjc@google.com, pbonzini@redhat.com
Subject: Re: [PATCH v5 13/14] x86/tsc: Mark Secure TSC as reliable clocksource
Date: Thu, 2 Nov 2023 11:23:34 +0530 [thread overview]
Message-ID: <ae267e31-5722-4784-9146-28bb13ca7cf5@amd.com> (raw)
In-Reply-To: <57d63309-51cd-4138-889d-43fbdf5ec790@intel.com>
On 10/30/2023 10:48 PM, Dave Hansen wrote:
> On 10/29/23 23:36, Nikunj A Dadhania wrote:
> ...
>> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
>> index 15f97c0abc9d..b0a8546d3703 100644
>> --- a/arch/x86/kernel/tsc.c
>> +++ b/arch/x86/kernel/tsc.c
>> @@ -1241,7 +1241,7 @@ static void __init check_system_tsc_reliable(void)
>> tsc_clocksource_reliable = 1;
>> }
>> #endif
>> - if (boot_cpu_has(X86_FEATURE_TSC_RELIABLE))
>> + if (boot_cpu_has(X86_FEATURE_TSC_RELIABLE) || cc_platform_has(CC_ATTR_GUEST_SECURE_TSC))
>> tsc_clocksource_reliable = 1;
>
> Why can't you just set X86_FEATURE_TSC_RELIABLE?
Last time when I tried, I had removed my kvmclock changes and I had set the X86_FEATURE_TSC_RELIABLE similar to Kirill's patch[1], this did not select the SecureTSC.
Let me try setting X86_FEATURE_TSC_RELIABLE and retaining my patch for skipping kvmclock.
Regards
Nikunj
1: https://lore.kernel.org/lkml/20230808162320.27297-1-kirill.shutemov@linux.intel.com/
next prev parent reply other threads:[~2023-11-02 5:53 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 6:36 [PATCH v5 00/14] Add Secure TSC support for SNP guests Nikunj A Dadhania
2023-10-30 6:36 ` [PATCH v5 01/14] virt: sev-guest: Use AES GCM crypto library Nikunj A Dadhania
2023-10-30 17:51 ` Tom Lendacky
2023-11-02 3:33 ` Nikunj A. Dadhania
2023-10-30 6:36 ` [PATCH v5 02/14] virt: sev-guest: Move mutex to SNP guest device structure Nikunj A Dadhania
2023-10-30 6:36 ` [PATCH v5 03/14] virt: sev-guest: Replace dev_dbg with pr_debug Nikunj A Dadhania
2023-10-30 6:36 ` [PATCH v5 04/14] virt: sev-guest: Add SNP guest request structure Nikunj A Dadhania
2023-10-30 18:16 ` Tom Lendacky
2023-11-02 4:01 ` Nikunj A. Dadhania
2023-10-30 6:36 ` [PATCH v5 05/14] virt: sev-guest: Add vmpck_id to snp_guest_dev struct Nikunj A Dadhania
2023-10-30 16:16 ` Dionna Amalie Glaze
2023-10-30 17:12 ` Tom Lendacky
2023-11-02 4:03 ` Nikunj A. Dadhania
2023-10-30 18:26 ` Tom Lendacky
2023-10-30 6:36 ` [PATCH v5 06/14] x86/sev: Cache the secrets page address Nikunj A Dadhania
2023-10-30 6:36 ` [PATCH v5 07/14] x86/sev: Move and reorganize sev guest request api Nikunj A Dadhania
2023-10-30 19:16 ` Tom Lendacky
2023-11-02 4:28 ` Nikunj A. Dadhania
2023-11-02 14:17 ` Tom Lendacky
2023-10-30 6:36 ` [PATCH v5 08/14] x86/mm: Add generic guest initialization hook Nikunj A Dadhania
2023-10-30 17:23 ` Dave Hansen
2023-11-02 4:30 ` Nikunj A. Dadhania
2023-10-30 19:19 ` Tom Lendacky
2023-11-02 5:08 ` Nikunj A. Dadhania
2023-10-30 6:36 ` [PATCH v5 09/14] x86/sev: Add Secure TSC support for SNP guests Nikunj A Dadhania
2023-10-30 16:46 ` Dionna Amalie Glaze
2023-11-02 5:13 ` Nikunj A. Dadhania
2023-10-30 20:26 ` Tom Lendacky
2023-11-02 5:36 ` Nikunj A. Dadhania
2023-11-02 14:29 ` Tom Lendacky
2023-11-02 5:41 ` Nikunj A. Dadhania
2023-11-02 10:36 ` Kirill A. Shutemov
2023-11-06 10:45 ` Nikunj A. Dadhania
2023-11-06 13:00 ` Kirill A. Shutemov
2023-10-30 6:36 ` [PATCH v5 10/14] x86/sev: Change TSC MSR behavior for Secure TSC enabled guests Nikunj A Dadhania
2023-10-30 6:36 ` [PATCH v5 11/14] x86/sev: Prevent RDTSC/RDTSCP interception " Nikunj A Dadhania
2023-10-30 20:32 ` Tom Lendacky
2023-11-02 5:47 ` Nikunj A. Dadhania
2023-10-30 6:36 ` [PATCH v5 12/14] x86/kvmclock: Skip kvmclock when Secure TSC is available Nikunj A Dadhania
2023-10-30 21:00 ` Tom Lendacky
2023-11-02 5:39 ` Nikunj A. Dadhania
2023-10-30 6:36 ` [PATCH v5 13/14] x86/tsc: Mark Secure TSC as reliable clocksource Nikunj A Dadhania
2023-10-30 17:18 ` Dave Hansen
2023-11-02 5:53 ` Nikunj A. Dadhania [this message]
2023-11-02 10:33 ` Kirill A. Shutemov
2023-11-02 12:07 ` Nikunj A. Dadhania
2023-11-02 12:16 ` Nikunj A. Dadhania
2023-11-02 12:38 ` Kirill A. Shutemov
2023-11-06 11:53 ` Nikunj A. Dadhania
2023-11-06 13:03 ` Kirill A. Shutemov
2023-10-30 6:36 ` [PATCH v5 14/14] x86/sev: Enable Secure TSC for SNP guests Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae267e31-5722-4784-9146-28bb13ca7cf5@amd.com \
--to=nikunj@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox