From: Paolo Bonzini <pbonzini@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>, kvm@vger.kernel.org
Cc: Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH v2] KVM: VMX: Remove unnecessary exception trampoline in vmx_vmenter
Date: Tue, 7 Apr 2020 10:21:34 +0200 [thread overview]
Message-ID: <ae555942-b2a1-be6c-e695-5c02bff554bd@redhat.com> (raw)
In-Reply-To: <20200406202108.74300-1-ubizjak@gmail.com>
On 06/04/20 22:21, Uros Bizjak wrote:
> The exception trampoline in .fixup section is not needed, the exception
> handling code can jump directly to the label in the .text section.
>
> Changes since v1:
> - Fix commit message.
>
> Cc: Sean Christopherson <sean.j.christopherson@intel.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> ---
> arch/x86/kvm/vmx/vmenter.S | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S
> index 81ada2ce99e7..56d701db8734 100644
> --- a/arch/x86/kvm/vmx/vmenter.S
> +++ b/arch/x86/kvm/vmx/vmenter.S
> @@ -58,12 +58,8 @@ SYM_FUNC_START(vmx_vmenter)
> ret
> 4: ud2
>
> - .pushsection .fixup, "ax"
> -5: jmp 3b
> - .popsection
> -
> - _ASM_EXTABLE(1b, 5b)
> - _ASM_EXTABLE(2b, 5b)
> + _ASM_EXTABLE(1b, 3b)
> + _ASM_EXTABLE(2b, 3b)
>
> SYM_FUNC_END(vmx_vmenter)
>
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-04-07 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 20:21 [PATCH v2] KVM: VMX: Remove unnecessary exception trampoline in vmx_vmenter Uros Bizjak
2020-04-07 8:21 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae555942-b2a1-be6c-e695-5c02bff554bd@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox