From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39774C433E0 for ; Fri, 31 Jul 2020 07:21:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11666207F5 for ; Fri, 31 Jul 2020 07:21:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jEKyvQT0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731603AbgGaHVg (ORCPT ); Fri, 31 Jul 2020 03:21:36 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:53640 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731507AbgGaHVg (ORCPT ); Fri, 31 Jul 2020 03:21:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596180094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YhINLqqhxnP4dI0gpE4qU/e48aN+/lH7whG0lTG2sOM=; b=jEKyvQT0wlbkvzNkQEtUmvC2ODAz327wMMKvdMv9mMS1N7cZaVJB6mpHLtugSUURx7SEwZ Aw+8hlO3r7mPdd0633emvRsPyrl0dsHfHd9BRxwiY3RB972Sha3qkxNG5gAhDIJM5H/Qrx KFxzxz7HWni1kkSKpp1WPCS0iIRALvg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-ncp4oxPNP2OLqv4gzieYhQ-1; Fri, 31 Jul 2020 03:21:30 -0400 X-MC-Unique: ncp4oxPNP2OLqv4gzieYhQ-1 Received: by mail-wr1-f69.google.com with SMTP id j16so8852449wrw.3 for ; Fri, 31 Jul 2020 00:21:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YhINLqqhxnP4dI0gpE4qU/e48aN+/lH7whG0lTG2sOM=; b=Pb8TTnDODaDIGsvZkSfiROeMjJsArBgzFx7n8g/hbmO8ssfVNhi1wXYdz7FnOdzt1h iWfmnckauke3QY4OHQcLHI2xHBLk5evTT6CBUOqmtSHx+9OMLJepPliPGAa3QNz48A4t hMq5jQrd46jginioLeADOHcZfREDVZ2vEvwG+dmoB7MbgGBvGg0k5E2U/gvKOYJUL8Uk j0xxmArwIwsW72HIEtS8S7MPsp3sTtCC/pO0HRqWC3HW+4RDOOX//kLP4qUpW1Rbf3/M b/ugM+Ta8dbg6H3Xq/SmVaDmiUYWE8Fz6q/1bLNez9O4M8KBNqI7f8ACWb6/7Zh8G/pC WHuA== X-Gm-Message-State: AOAM532t8vwTK3kvUEtgvFhiwX6VLipm2fazVoF00oblEDF5u5TY4QxX ORQLVUIeR0QBXTc1LiNATGBGp3QWK16ro7CZYL01tyXoSgJ8kEJ3EgRpJSWVMHa6TwQvJ5lsQpL dML+BlmpOzMvR X-Received: by 2002:a1c:1d52:: with SMTP id d79mr2761782wmd.82.1596180089308; Fri, 31 Jul 2020 00:21:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYuiwOQg3zrH0P/vMjCtmTUs3SPv1/R6CQYiqzJb5lGc+AXN0tsrZpBEo62hsb3u2/PJ4lTg== X-Received: by 2002:a1c:1d52:: with SMTP id d79mr2761767wmd.82.1596180089022; Fri, 31 Jul 2020 00:21:29 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:90a5:f767:5f9f:3445? ([2001:b07:6468:f312:90a5:f767:5f9f:3445]) by smtp.gmail.com with ESMTPSA id b186sm13204394wme.1.2020.07.31.00.21.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2020 00:21:28 -0700 (PDT) Subject: Re: [PATCH v3 3/3] KVM: SVM: Fix disable pause loop exit/pause filtering capability on SVM To: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel References: <1596165141-28874-1-git-send-email-wanpengli@tencent.com> <1596165141-28874-3-git-send-email-wanpengli@tencent.com> From: Paolo Bonzini Message-ID: Date: Fri, 31 Jul 2020 09:21:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1596165141-28874-3-git-send-email-wanpengli@tencent.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 31/07/20 05:12, Wanpeng Li wrote: > From: Wanpeng Li > > 'Commit 8566ac8b8e7c ("KVM: SVM: Implement pause loop exit logic in SVM")' > drops disable pause loop exit/pause filtering capability completely, I > guess it is a merge fault by Radim since disable vmexits capabilities and > pause loop exit for SVM patchsets are merged at the same time. This patch > reintroduces the disable pause loop exit/pause filtering capability support. > > Reported-by: Haiwei Li > Tested-by: Haiwei Li > Fixes: 8566ac8b (KVM: SVM: Implement pause loop exit logic in SVM) > Signed-off-by: Wanpeng Li > --- > v2 -> v3: > * simplify the condition in init_vmcb() > > arch/x86/kvm/svm/svm.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index c0da4dd..bf77f90 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -1090,7 +1090,7 @@ static void init_vmcb(struct vcpu_svm *svm) > svm->nested.vmcb = 0; > svm->vcpu.arch.hflags = 0; > > - if (pause_filter_count) { > + if (!kvm_pause_in_guest(svm->vcpu.kvm)) { > control->pause_filter_count = pause_filter_count; > if (pause_filter_thresh) > control->pause_filter_thresh = pause_filter_thresh; > @@ -2693,7 +2693,7 @@ static int pause_interception(struct vcpu_svm *svm) > struct kvm_vcpu *vcpu = &svm->vcpu; > bool in_kernel = (svm_get_cpl(vcpu) == 0); > > - if (pause_filter_thresh) > + if (!kvm_pause_in_guest(vcpu->kvm)) > grow_ple_window(vcpu); > > kvm_vcpu_on_spin(vcpu, in_kernel); > @@ -3780,7 +3780,7 @@ static void svm_handle_exit_irqoff(struct kvm_vcpu *vcpu) > > static void svm_sched_in(struct kvm_vcpu *vcpu, int cpu) > { > - if (pause_filter_thresh) > + if (!kvm_pause_in_guest(vcpu->kvm)) > shrink_ple_window(vcpu); > } > > @@ -3958,6 +3958,9 @@ static void svm_vm_destroy(struct kvm *kvm) > > static int svm_vm_init(struct kvm *kvm) > { > + if (!pause_filter_count || !pause_filter_thresh) > + kvm->arch.pause_in_guest = true; > + > if (avic) { > int ret = avic_vm_init(kvm); > if (ret) > Queued all three, thanks. Please do send a testcase for patch 1 however, I only queued it in order to have it in 5.8. Paolo