From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3113D1509AB; Tue, 21 Apr 2026 17:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.228.1.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776791251; cv=none; b=YoLVRP0rELpxGlS4rxsWEocB5iqK/F4XRFaPLOyRf4qkL5Sj7ocK6fh+ElZ++lxGds/hy8CLE+yK43WPlGS0PzTsN3UYHPPu6wcg3j5oOtq3Gl2bHIeZjP7t7UiIMBnRVG/6t6oP2c6OH6NNZl5hYN47mi99cjxjn2wAUMb1jaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776791251; c=relaxed/simple; bh=BmLatGy8n1zKmv3W1i69jDYO1lD52eKYiSdHSJdTpeE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hWmmbShRAnnRWeyuIgfALBggo4xC11vz7zRyTtJodnrjqaCuRUb28Y7iawPTgFYWVitNK4etXALUVQ2BeBV5KeMyrhRlr4p2vuvEMeGLlJ8FerHQlwVTMI6e9/6tnHwitHWvoS/I2zUj8sz1JPQYSlmLpWy70oOUfdDZU4As4Do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org; spf=pass smtp.mailfrom=kernel.crashing.org; arc=none smtp.client-ip=63.228.1.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost [127.0.0.1]) by gate.crashing.org (8.18.1/8.18.1/Debian-2) with ESMTP id 63LH4FuA3771909; Tue, 21 Apr 2026 12:04:15 -0500 Received: (from segher@localhost) by gate.crashing.org (8.18.1/8.18.1/Submit) id 63LH47sR3771903; Tue, 21 Apr 2026 12:04:07 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 21 Apr 2026 12:04:06 -0500 From: Segher Boessenkool To: Link Mauve Cc: linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Herbert Xu , "David S. Miller" , Juergen Gross , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Geoff Levand , Mahesh J Salgaonkar , "Oliver O'Halloran" , Anatolij Gustschin , Breno =?iso-8859-1?Q?Leit=E3o?= , Nayna Jain , Paulo Flabiano Smorigo , Eric Biggers , "Jason A. Donenfeld" , Ard Biesheuvel , Thorsten Blum , Thomas Huth , Jason Gunthorpe , David Hildenbrand , Alistair Popple , "Ritesh Harjani (IBM)" , Donet Tom , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Will Deacon , "Lorenzo Stoakes (Oracle)" , Paul Moore , Nam Cao , Alexander Gordeev , Sourabh Jain , Hari Bathini , Srikar Dronamraju , Shrikanth Hegde , Jiri Bohac , "Mike Rapoport (Microsoft)" , "Jiri Slaby (SUSE)" , Greg Kroah-Hartman , Andy Shevchenko , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Kees Cook , Stephen Rothwell , Xichao Zhao , Gautam Menghani , Peter Zijlstra , K Prateek Nayak , Guangshuo Li , Li Chen , Aboorva Devarajan , Petr Mladek , Feng Tang , "Nysal Jan K.A." , Aditya Gupta , Sayali Patil , Rohan McLure , Pasha Tatashin , Yeoreum Yun , Kevin Brodsky , "Matthew Wilcox (Oracle)" , Andrew Donnellan , "Vishal Moola (Oracle)" , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Athira Rajeev , Kajol Jain , Thomas Gleixner , Chen Ni , Haren Myneni , Jonathan Greental , Ingo Molnar , "Yury Norov (NVIDIA)" , Gaurav Batra , Nilay Shroff , Vivian Wang , Adrian =?utf-8?Q?Barna=C5=9B?= , "Rafael J. Wysocki (Intel)" , Thierry Reding , Yury Norov , "Mukesh Kumar Chaurasiya (IBM)" , Ruben Wauters , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-crypto@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, x86@kernel.org Subject: Re: [PATCH 2/2] powerpc: Run typos -w Message-ID: References: <20260421121420.26079-1-linkmauve@linkmauve.fr> <20260421121420.26079-3-linkmauve@linkmauve.fr> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260421121420.26079-3-linkmauve@linkmauve.fr> Hi! On Tue, Apr 21, 2026 at 02:14:14PM +0200, Link Mauve wrote: > diff --git a/arch/powerpc/boot/dts/fsl/ppa8548.dts b/arch/powerpc/boot/dts/fsl/ppa8548.dts > index f39838d93994..32558104b3a9 100644 > --- a/arch/powerpc/boot/dts/fsl/ppa8548.dts > +++ b/arch/powerpc/boot/dts/fsl/ppa8548.dts > @@ -95,7 +95,7 @@ i2c@3100 { > > /* > * Only ethernet controller @25000 and @26000 are used. > - * Use alias enet2 and enet3 for the remainig controllers, > + * Use alias enet2 and enet3 for the remaining controllers, Aliases. > diff --git a/arch/powerpc/boot/dts/mpc8308_p1m.dts b/arch/powerpc/boot/dts/mpc8308_p1m.dts > index 41f917f97dab..48a98449ecbb 100644 > --- a/arch/powerpc/boot/dts/mpc8308_p1m.dts > +++ b/arch/powerpc/boot/dts/mpc8308_p1m.dts > @@ -90,14 +90,14 @@ can@1,0 { > compatible = "nxp,sja1000"; > reg = <0x1 0x0 0x80>; > interrupts = <18 0x8>; > - interrups-parent = <&ipic>; > + interrupts-parent = <&ipic>; > }; interrupt-parent . All the names of properties have a meaning! Just as you cannot change a function name in C without changing all calls to it as well, you really should never change a property name (if you want stuff to keep on working, that is ;-) ). In this case, the property was never actually used (because of the typo). Maybe it wasn't needed? If you make changes to a DTS, post it *separately* from the rest of this series, and test it *thoroughly*. Just a "does it boot" test is certainly not enough. It could well be that fixing the typo (so that the property name becomes "interrupt-parent") makes the kernel no longer boot on the systems affected, or less obvious problems can show up. It will need to be tested and evaluated by whoever maintains the DTSes in question, really :-/ And you cannot test it works for one DTS and then conclude it will work everywhere, heh. Segher