From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7298E358D3D; Fri, 24 Apr 2026 08:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777019160; cv=none; b=JZLdYfUkC4slB9j7UlNDsfC+XPagDBnnVkVdX9xSqv+pAxX6mTDDrUUe0PW55dxJ7Ef2BPjLNU2uYkbyNiaSw7l6u0w3K8/SIIEjRuVlmOX3tSsCztuuFg5WBLyeCJMlffSC/oOWh7FH/rpPzJ02ObIk8gW0VAhnhlv36O/FcWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777019160; c=relaxed/simple; bh=qbpqHYHXo5cVVMvcWZZEGa2oGr0mmblnjVSPUfSnX7k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OAME/vuzV13/0vfKQ4S3X1LctghddCv+68Ynyt85eh2ht60qa9kt0TP6losUS0BHcV2WO+UssK5DFW6IhHREFgoHpYEQSGlcetEzoqqOdvDDP147KBzJ4LKDOQEq9uENvflwxhUQlDrIZhtnmHgUY/u/j03YY3L5jMlaxSEachQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=iyYMPc0Y; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="iyYMPc0Y" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63NIUb943291955; Fri, 24 Apr 2026 08:25:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=qbpqHYHXo5cVVMvcWZZEGa2oGr0mmb lnjVSPUfSnX7k=; b=iyYMPc0YmOBLHbzcWETwJRncMGhcF+idc3kRUPpiphRXE7 Hi+SBJkakrD6lwIwXn0qauX/EOVhr/YLtKg+UNd75jJDmhPZsTeky1CCWuvWbqMK CUn16OLtsnbhVAMrC26Tt8pMNmb8E0zGSrTkXXwTfX0owah55pacH5U/ohr7JnCj iDOKZVkyHVHNIhttE1yB0x2W+XDPx74xom0XGMihnLGo7WQvN4IjHERpMfSK/3Xz ZcnFKofZjbJqQu8wqKSzrEy5gThfD35qUt/y3TsOFpwqTaHpGBpX2tOKhqXDafYv UAYJjKGgSI4xWn9LIVerQskdhUqNZHC60dYnJztA== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dphfrm81m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Apr 2026 08:25:35 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 63O8KWKM019120; Fri, 24 Apr 2026 08:25:34 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dpjkya0uh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Apr 2026 08:25:33 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 63O8PVgG50528662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Apr 2026 08:25:32 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E04EB2004E; Fri, 24 Apr 2026 08:25:31 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3154B20040; Fri, 24 Apr 2026 08:25:27 +0000 (GMT) Received: from Gautams-MacBook-Pro.local (unknown [9.43.77.7]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 24 Apr 2026 08:25:26 +0000 (GMT) Date: Fri, 24 Apr 2026 13:55:18 +0530 From: Gautam Menghani To: Peter Fang Cc: Paolo Bonzini , Sean Christopherson , Madhavan Srinivasan , Nicholas Piggin , Yosry Ahmed , Ritesh Harjani , Michael Ellerman , "Christophe Leroy (CS GROUP)" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] KVM: Take gpa_t in kvm_vcpu_map[_readonly]() Message-ID: References: <20260408001137.3290444-1-peter.fang@intel.com> <20260408001137.3290444-4-peter.fang@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408001137.3290444-4-peter.fang@intel.com> X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: wBygo57Phfjx6n0uHlbxhJ9GYvH1qDtX X-Proofpoint-ORIG-GUID: 2Vc1kq0JQ7XgGNb8DZGjRTzmC2-piCiM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDA3NiBTYWx0ZWRfXxm6Uzqq5Bp7u fkKJyf60yQlmdLJCU5AaAOzg0KlxPY07KEC++J+kEhZoYRh3+Uy+np02Mvg6gCcFjnaWL7J7p5K 3uVlW2ik8Fdx+HsFgyuI1sQtRmrrnLlccb/yfdmsoLdO5d7YflPB7yX3LzoRU+JYH58JHd2HxsP uoTSQI1QuCNqOlvVJbI9Ma+sOjHxejmcVqdk4FCuPHchcj1+7Uhr1rJa3by0zBR2X4G38VZIsse WO5KoSOHxAsn1A9nhopSp5fIhybeVH6LNozsDZ3hvqrcibRPYb7IP9YpIwvY10dGFb8NZx6cmtD X7rKbFE18ccbir0wnGyjJduv1l3nbtLLY/HdudpLZjB18H1khfc2ST5kfY1Ne8V2aNTzA3g7k22 j4fmaMbsn291hRCaG38fbVdW0gpHDBs9htd36LSIiGZH6B4nwACpmqwoynstE8nJRsi3zXuyJwf sArsyNxLOKPnR7AjQpQ== X-Authority-Analysis: v=2.4 cv=SJxykuvH c=1 sm=1 tr=0 ts=69eb28ff cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VwQbUJbxAAAA:8 a=1XWaLZrsAAAA:8 a=SXutj9_lnH9CGaSYosoA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1011 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240076 On Tue, Apr 07, 2026 at 05:11:30PM -0700, Peter Fang wrote: > Move the conversion from a gpa_t to a gfn_t into kvm_vcpu_map() and > kvm_vcpu_map_readonly() so that they take a gpa_t directly, reducing > boilerplate at call sites. For this refactor, shouldn't the prototypes continue to take in gpa? I think this was agreed in v1? [1] Am I missing something? [1] : https://lore.kernel.org/kvm/ac8BOGXIPMnJ7kIg@google.com/ Thanks, Gautam