From: Steffen Eiden <seiden@linux.ibm.com>
To: mhartmay@linux.ibm.com
Cc: frankja@linux.ibm.com, imbrenda@linux.ibm.com,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
nrb@linux.ibm.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v1] s390x/Makefile: simplify Secure Execution boot image generation
Date: Tue, 9 Jan 2024 15:59:33 +0100 [thread overview]
Message-ID: <af124c42-946d-46c8-b01f-d0bc9fb99d91@linux.ibm.com> (raw)
In-Reply-To: <20231121172338.146006-1-mhartmay@linux.ibm.com>
LGTM.
> Changes:
> + merge Makefile rules for the generation of the Secure Execution boot
> image
> + fix `parmfile` dependency for the `selftest.pv.bin` target
> + rename `genprotimg_pcf` to `GENPROTIMG_PCF` to match the coding style
> in the file
> + always provide a customer communication key - not only for the
> confidential dump case. Makes the code little easier and doesn't hurt.
>
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
> ---
> s390x/Makefile | 40 +++++++++++++++++-----------------------
> 1 file changed, 17 insertions(+), 23 deletions(-)
[...]
next prev parent reply other threads:[~2024-01-09 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 17:23 [kvm-unit-tests PATCH v1] s390x/Makefile: simplify Secure Execution boot image generation Marc Hartmayer
2024-01-09 13:27 ` Marc Hartmayer
2024-01-09 14:59 ` Steffen Eiden [this message]
2024-01-10 10:44 ` Janosch Frank
2024-01-10 16:23 ` Marc Hartmayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af124c42-946d-46c8-b01f-d0bc9fb99d91@linux.ibm.com \
--to=seiden@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).