From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB40E37A494 for ; Tue, 28 Apr 2026 19:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777405969; cv=none; b=igiQbMPk6c6ama8NzagcQ5Lm+v+J/V+flMmKv+eP8fezFI27OpOeyhOYno0nhNZVg3VBl1vgZd2kc7KbjueP+etXD9xHGZGzH96r7BKRl5wXq/dmEPlBRmvxUwKreJ1zVcLHhpAWrKFRcv5Y0ahvm2HcxcvcvAE+8xZwsPf7FPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777405969; c=relaxed/simple; bh=EdF6NqLMXj+vo4TMcPGE8M5ypFpIZGyhqbD7NyYtkA4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=et/oFLeUn/SlT5/mcJ5SeQwbzxkawiGHHgvqaPeLa8Jr6ygL3UMZgK0B3fRwSgedLmiv87aKt+QcYKNssCSfWqNbMKJnDmS6h2WZY7wNFc/p0kbgZPiXscMyA50f2IA3XQCUbPGiunxSNLE2lFIUQih3nymOEha3WXdNszi6szk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lSTjhffE; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lSTjhffE" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c79798cd9b9so4453961a12.2 for ; Tue, 28 Apr 2026 12:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777405967; x=1778010767; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=3s28yegQ9fVQN3KSZhlWBZCHr39ir/gqDmXWLfmjY4U=; b=lSTjhffEBJSbSVVUCyOgznBSPWLP2+oO0otHTTg0ANM/ITngvU3tnJRWu6DWJhhqm0 0/1lIPNKk9XgSuKPvRj87lz9+ToYr4QSgsTJNzYqzt6KmDii0A+2p0dABNYSap4YUhd9 zjLQuHqLGj5j9ePEA2/dzG7T1bPpsbPfQYD5RXbaILibU4Gc5VeUKNimQU1+UQ3ebkYs bwJqirrVe3/pcQYBsI9fbPmtWBmFdpdF8d7u1/c/idPlhAlqtjxeUGT0wUOJmARXwQ79 HlmtUBpL5LTDAsFrMhsBzghhhvZMrxAHI3TKlKq+8Hs9st6wKlVAcvfPREhL/I6pKynW gFuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777405967; x=1778010767; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3s28yegQ9fVQN3KSZhlWBZCHr39ir/gqDmXWLfmjY4U=; b=OxxNK4MJJBrAXwrCgZgdPW4V0lWFqDJ4GCkTEa5vjjfBqIwkyzJMkbG6/CT+MTs4tf WyaDApbU0jmG17p6TIfGsbzdBTCSLfK4op0KWx4fsy5zc9oWbzJrRPlEStihl46aDejN A4H0smwdV7DhnlCGn3SAX4TDMWRrC08D4RrGHzvEr8VsNi3YRjeegkv90GGFWiC9sZBh TB6tiS5KZCtoGloRlNUlDnBZE4YED67k5TYVeA8/MRlIKGEf9QBmxLlQswzErcqVzgsj Pen7QQ9zzMVWb5natgt/+0hVXhi7smm8/wMb1eCv9LE0NgR96JBE0iu03zJ226Ui+XXk F6kQ== X-Forwarded-Encrypted: i=1; AFNElJ+RKtc5V0AFHQX/z1pBQM9PTC/UurOW7jYXl9x1QSxepZP4BIPtwLc6KzJSOHHPuvN/cmI=@vger.kernel.org X-Gm-Message-State: AOJu0YyZyVYr87bCtmkuN5WRQ7AoPnLgic3Gc3oTbUbOtU37od9cGoCS VUp7d8swLCiqKbMzJY1cMZPCshujrX/Ra1o/V7ZjFBOwra3CBr2K6BnJnrYf6Q8ay5ywELUaxKN jxugp5g== X-Received: from pfbk21.prod.google.com ([2002:a05:6a00:b015:b0:82f:790c:3922]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2d85:b0:82a:6de8:fa50 with SMTP id d2e1a72fcca58-834ea5cb4b4mr674937b3a.18.1777405966843; Tue, 28 Apr 2026 12:52:46 -0700 (PDT) Date: Tue, 28 Apr 2026 12:52:45 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260202-vfio-selftest-only-64bit-v2-1-9c3ebb37f0f4@fb.com> <20260427231217.GA1670652@nvidia.com> Message-ID: Subject: Re: [PATCH v2] vfio: selftests: only build tests on arm64 and x86_64 From: Sean Christopherson To: David Matlack Cc: Jason Gunthorpe , Matt Evans , Ted Logan , Alex Williamson , Shuah Khan , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="us-ascii" On Tue, Apr 28, 2026, David Matlack wrote: > On 2026-04-27 06:55 PM, Sean Christopherson wrote: > > On Mon, Apr 27, 2026, Jason Gunthorpe wrote: > > > Even though this is a 64 bit build. > > > > Heh, it's much funnier when it's happening to someone else. :-) > > > > KVM selftests went through these exact pains. I'm pretty sure these are the > > relevant commits (the empty targets one may or may not apply to VFIO). > > > > 9af04539d474dda4984ff4909d4568e6123c8cba KVM: selftests: Override ARCH for x86_64 instead of using ARCH_DIR > > 67730e6c53d70fb31618230f81c4acee9f72eaa3 KVM: selftests: Use canonical $(ARCH) paths for KVM selftests directories > > 43fbd8cd389faa9760c5152b1c58e893c812953b KVM: selftests: Provide empty 'all' and 'clean' targets for unsupported ARCHs > > KVM selftests don't prevent 32-bit x86 builds though, Yes they do? x86 is an alias for x86_64 (or vice versa), and so the i386 target gets binned into the empty target provided by tools/testing/selftests/kvm/Makefile. And KVM selftests most definitely don't play nice with 32-bit. > which is part of what we're trying to do here. > > For example running... > > $ make -C tools/testing/selftests/kvm ARCH=x86 CC="gcc -m32" > > ...produces a lot of -Wformat errors that were also seeing in VFIO selftests > from the kernel test robot. Uh, don't do that? KVM selftests can't even get past the preprocessor with -m32. Either the kernel test robot is trolling y'all, or there's something missing in the VFIO configuration, because I'm not seeing any magic in KVM to guard against the above.