Re: [PATCH v8 15/21] x86/virt/tdx: Refresh TDX module version after update

Edgecombe, Rick P
2026-04-30T21:35:25Z

On Thu, 2026-04-30 at 12:14 -0700, Dave Hansen wrote:
> > Do not refresh the rest of tdx_sysinfo. Refreshing them at runtime could
> > disrupt running software that relies on the previously reported values.
>
> This needs more explanation. I think the reasoning is quite nuanced.
>
> tdx_sysinfo is just a cache of what the TDX module is and can do. If
> that changes, it means the TDX module changed. So you somehow need to
> argue why it's OK to hide those changes from the tdx_sysinfo users.
>
> Why would they be confused by tdx_sysinfo changes but not by the TDX
> module *itself* changing?

We shouldn't refresh them because they don't change, right Chao? It's not
because we are hiding things?

>
> > Note that major and minor versions are not refreshed because runtime updates
> > are supported only between releases with identical major and minor versions.
>
> I'd rather have this in code than a changelog comment.
>
> If they can't change then warn if they do.