From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD2BF36A027 for ; Wed, 10 Jun 2026 19:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781119129; cv=none; b=ZdfdoP6F0wBj6koGL6cy/0jT2u25Meru4Wq9B6b7zVnhrPF8LfPVLA9UQ+sJPsa6uNSRzXum2sWQXwesgNX/LNuh+Mhhmv8oPHP+4zIP3a5mo25/cXdQvLDnoXEe2j4/UWd6s1r+4h/soxPeCR5bhpz5FrA8qaotrKYIpGrMZK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781119129; c=relaxed/simple; bh=bWOieN7hFnS5AkVT6IUrpQaoTZ6d+J/rfYok78HffKw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MFdlueLbW5gw7Zt/xr4wD8Sfz0CCQI4TU3p5LhcOP1E8fycByWvD91KUjEfDWqEzb8nrbKhZnG38dBNSgdUqkgJNp1TqeBn57E3nXrPS6biN0YmfNZoK6cmpXrup0rlfM/xMX39rdEip5GXVVEGXpr0az8lOkGZjTSwgS93QTe8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=s+M0xMnC; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="s+M0xMnC" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-36d98b5a68fso12208856a91.2 for ; Wed, 10 Jun 2026 12:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781119127; x=1781723927; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=EEBmDx98caEzFpRXeIqJTAyOlpfmMPXYTcbS9AlAlm8=; b=s+M0xMnCpcYNTag+MHk5EqjdbQK2YtLt+nt3rS6LCDtpqzEtXHY+t/aW54YfW7Qm+D 665zKwgRpB26CvhzckSPBaaT6kA+EONfP9OEy0JXEdvmBlmpfba1UGt8y4WNywGyMR+e 0AILd2caQ9J9ETenSEs1vMg9vNX/TfBBV8+YLppyUI3lYaPK9IBFKIjlK0gK73uiOdV1 PldzZW3eHtJYE8mX9bNBRQkfw8qPkpL+xIceYnEy06hGKPKWZFV9A7YPHNxiyaf+5KJk Ax0c8g3VdkFiqMcvUSyGEKUgw28QxChVaAhxddAyDFzTn9yoGcYk6s2kMYn1mql1ofpB Kjxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781119127; x=1781723927; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EEBmDx98caEzFpRXeIqJTAyOlpfmMPXYTcbS9AlAlm8=; b=G2/uvOe+JjLy8sz94LpU2NlvD4DNtLQpm92fWqmcyyttbd4mwwF4sN2cUjwCTCjGtl nUG9otii0qDihBQXh6H1GlomVfrPNmla6qscURd7+9DDkXPm9cBiVCDP1Rc6aKLxImh+ +YHfmlQobWD7pUMnXnAHVNUiDHNuqVhRKB20VWE1npvU8pVficNeaOIa0seZUnpSWD9A BSyldCC5v0hcOhqcRea4ffs5/g+dtrnEpWGrLbNUofCJRuIy/NhaQjwxlUeZH9+Oo3hD 0vhJcflpp0P+wwhHiIFdqCeHP6qAuBI6eUhLGKF2YKnRl7e9TuFjHW6/1Ze7Boy3Gz49 qyPg== X-Gm-Message-State: AOJu0Yw2YzpnGZSjNgPPsrEhxmliAR6SdU+7W/wkcMF/ickrh8xB3JD1 EVP36ruo2rCcdWV56MMemBDXz0So1ZUNw/NuN74aVf9snNZBkHh4+SxOuwxt0uh/Kv16rIxFFTQ 7LkBvwQ== X-Received: from pjji9.prod.google.com ([2002:a17:90a:6509:b0:36b:cf62:6827]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2741:b0:366:10f1:3d86 with SMTP id 98e67ed59e1d1-370f0b55ebbmr28954281a91.22.1781119126862; Wed, 10 Jun 2026 12:18:46 -0700 (PDT) Date: Wed, 10 Jun 2026 12:18:46 -0700 In-Reply-To: <20260610010314.DB8861F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260610005338.2967132-2-seanjc@google.com> <20260610010314.DB8861F00893@smtp.kernel.org> Message-ID: Subject: Re: [PATCH v6 01/18] KVM: selftests: Build and link selftests/vfio/lib into KVM selftests From: Sean Christopherson To: sashiko-reviews@lists.linux.dev Cc: kvm@vger.kernel.org, David Matlack , Josh Hilke Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Jun 10, 2026, sashiko-bot@kernel.org wrote: > > diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/s= elftests/kvm/Makefile.kvm > > index e0ddd3ff9472d..14316358fd9fb 100644 > > --- a/tools/testing/selftests/kvm/Makefile.kvm > > +++ b/tools/testing/selftests/kvm/Makefile.kvm > > @@ -257,6 +257,7 @@ OVERRIDE_TARGETS =3D 1 > > # which causes the environment variable to override the makefile). > > include ../lib.mk > > include ../cgroup/lib/libcgroup.mk > > +include ../vfio/lib/libvfio.mk >=20 > [Severity: Low] > Does including libvfio.mk here break the "make clean all" sequence for KV= M=20 > selftests? David and/or Josh, can you verify whether Sashiko is hallucinating or has a legitimate concern? > In tools/testing/selftests/vfio/lib/libvfio.mk, the output directory is > eagerly created at parse time: >=20 > LIBVFIO_O_DIRS :=3D $(shell dirname $(LIBVFIO_O) | uniq) > $(shell mkdir -p $(LIBVFIO_O_DIRS)) >=20 > The directory is also added to EXTRA_CLEAN.=20 >=20 > If a developer runs "make clean all", Make will parse the included libvfi= o.mk=20 > and run the shell mkdir command at parse time. Then it executes the clean= =20 > target, which deletes the newly created libvfio directory. Finally, it=20 > executes the all target, but the compilation fails with a "No such file o= r=20 > directory" error because the output directory was deleted and isn't recre= ated > in the build recipe. >=20 > > =20 > > INSTALL_HDR_PATH =3D $(top_srcdir)/usr >=20 > [ ... ] >=20 > --=20 > Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260610005338.29= 67132-1-seanjc@google.com?part=3D1