From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22D6A27057D for ; Thu, 25 Jun 2026 15:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782402030; cv=none; b=DVUBlkiLhKvk6tCpZ5Gi5HASoJudO870yjiqRmlx/yPSar3er6BoADalXhiR5GXwENOdjoX5W7TsQAnVSta0Y7g5go7wTs959iB8RvRL5kyUlFCB96iDbsxe6USdkT47uvM2FFkizpBFEpOmtG8bwV4Ye7a6RSD8Qt/hL7HOAy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782402030; c=relaxed/simple; bh=wnycnk35ivpQHERfilV0c1wBVrlSSxbqgktgJps4HzY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FPIo3XzGqVzfVlmXJ8eABd4bPxmUHMvahYLcQKP0AR0NH2w1HOHDg4EXSaqWcGecSlLoSgWNpzBclL09S6bs/L/oWtY43iBOwSwJFdP6dlMHisOIYXyXIKbl2sR19oqN1E9wZUgK7t6iDuZKZO9hPvY34jHZPy6lPqvBt1Jzce4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=O1HkzZQI; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="O1HkzZQI" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-8423efbfb61so1770639b3a.0 for ; Thu, 25 Jun 2026 08:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782402028; x=1783006828; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Itjo2jMjkwhBM0k9+OlfOfXdIDoAWufeDNJNDd1hXfc=; b=O1HkzZQIi+MnRkSybj5bbHuNPOdQm0Cmmkp8R2vnMeuw9GWpob8A+A/aD4CDhOrWgP FJWl+84GxCOD51HXoVsHR9kMqxc0JN7hEHkV/ZXBReJ5S+BiDH5VKRRcuoOFAOyHvjlt Q+IMC3Rx+3t+vBvSw0G+3Q+y5kUa5TeEfSfy8Bpsp0XtvORO3v5FaT7VZdS/Y7VFGLlX 0pg4Dshd8wn1n0dXEir7JeZzp6LGx1xIHBxPAZRpY//ieK0H6vF1eNPSDpUfyQ1vK1a5 Ve9TtzFxPu/KyrX0abS2rMpjTgJzrWKggNpa4IRUcEzwHDRqASoj5uZQ2pXXTguf7WNc 6thQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782402028; x=1783006828; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Itjo2jMjkwhBM0k9+OlfOfXdIDoAWufeDNJNDd1hXfc=; b=hTPZbCISxYIz/x07iFvHFAWA/2khPQRmGIm3szNfprNVueV+9Bx1SnaqXbyV3y9oaS d41kCD/8GIDt+RiRVE4HBSbNbOLZ7ckEIrswaleJ7EQ5dBSxe7WKbGhhKhu81ppSPx4i BcspZW/SUh8LkboISmElcmgWqL6p89n23buWDYJLc2m1/p5ppWx2aE4EgrpamWROwuMa eOYLa587cf6wHBIAWXJ9whKwpcArZ3y6GzXaNPbxdKkP6NkFwmLasp6DDN0x0f/adZl3 ED5Z/AeoDK8ojqr/p3I9X/f3JqdAS0PdvMvsfav0vxVrk8HQdY7chukvckMRS9IhbNsd 0RQQ== X-Forwarded-Encrypted: i=1; AFNElJ9U2Paxcb4jlh/0tsf2oRt62i9HBx88UZbXFmfipDVXv0WW+5vAt7y3v5JC5UNiy0wQPdE=@vger.kernel.org X-Gm-Message-State: AOJu0YxO4rqKaLGZsDC8xgY1/8VGFQdK4t4cAwTJJm30TPhGXFzMni1h FYtavBY2BMHan8shcmbA/ss2005cNlA0oVna+j+XG1zfshIRgCDHKBtNfwm8Kv2ZNqU2lxEF7qK n/YDtXg== X-Received: from pgbdk2.prod.google.com ([2002:a05:6a02:c82:b0:c85:9dd2:d11e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:cc97:b0:3b4:5c6f:cf30 with SMTP id adf61e73a8af0-3bd4b25b347mr3615613637.38.1782402027934; Thu, 25 Jun 2026 08:40:27 -0700 (PDT) Date: Thu, 25 Jun 2026 08:40:27 -0700 In-Reply-To: <6ed7d12a-c3a1-4572-8385-754e6d5b8b44@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com> <20260618-gmem-inplace-conversion-v8-18-9d2959357853@google.com> <6ed7d12a-c3a1-4572-8385-754e6d5b8b44@kernel.org> Message-ID: Subject: Re: [PATCH v8 18/46] KVM: guest_memfd: Handle lru_add fbatch refcounts during conversion safety check From: Sean Christopherson To: "David Hildenbrand (Arm)" Cc: Ackerley Tng , aik@amd.com, andrew.jones@linux.dev, binbin.wu@linux.intel.com, brauner@kernel.org, chao.p.peng@linux.intel.com, jmattson@google.com, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, liam@infradead.org, Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Youngjun Park , Qi Zheng , Shakeel Butt , Kiryl Shutsemau , Baoquan He , Jason Gunthorpe , Vlastimil Babka , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev Content-Type: text/plain; charset="us-ascii" On Thu, Jun 25, 2026, David Hildenbrand (Arm) wrote: > On 6/25/26 02:35, Sean Christopherson wrote: > > One thought I had, to avoid the IPIs that draining all per-CPU caches requires, > > was to disallow putting guest_memfd pages in folio batches, e.g. by hacking > > something into folio_may_be_lru_cached(). But due to taking a per-lru lock, > > that would penalize the relatively hot path and definitely common operation of > > faulting in guest memory. On the other hand, memory conversion is already a > > relatively slow operation and is relatively uncommon compared to page faults, > > (and likely very uncommon for real world setups). I.e. having to drain all > > caches if conversion isn't safe penalizes a relatively slow, relatively uncommon > > path. > > Yeah, the lru_add_drain_all is rather messy. > > We have similar code in > > collect_longterm_unpinnable_folios(), where we first try a lru_add_drain(), to > then escalate to a lru_add_drain_all(). > > Maybe we could factor that (suboptimal code) out to not have to reinvent the > same thing multiple times? As discussed in the guest_memfd call, we should do this straightaway, i.e. instead of merging this series as-is, so that we don't export lru_add_drain_all() only to drop the export a kernel or two later, and can instead export the helper to drain any batches for a folio (or set of folios/pages).