Re: [PATCH kvmtool 0/6] x86 compilation fixes and arm64 PMU improvements

[Will Deacon <will@kernel.org>]

On Thu, Jun 18, 2026 at 01:47:28PM +0100, Alexandru Elisei wrote:
> Hi Will,
> 
> On Tue, Jun 16, 2026 at 10:11:11AM +0100, Will Deacon wrote:
> > Hey Alexandru,
> > 
> > On Mon, Mar 23, 2026 at 03:02:15PM +0000, Alexandru Elisei wrote:
> > > The first two patches fix the following compilation errors on x86 when
> > > using gcc 15.2.1:
> > > 
> > > disk/core.c: In function ‘disk_img_name_parser’:
> > > disk/core.c:27:21: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> > >    27 |                 sep = strstr(arg, ":");
> > >       |                     ^
> > > disk/core.c:39:21: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> > >    39 |                 sep = strstr(cur, ",");
> > >       |                     ^
> > > virtio/9p.c: In function ‘virtio_9p_rootdir_parser’:
> > > virtio/9p.c:1503:18: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
> > >  1503 |         tag_name = strstr(arg, ",");
> > >       |                  ^
> > > 
> > > I couldn't reproduce the errors on arm64 using aarch64-linux-gnu-gcc 15.1.0
> > > and 14.2.0. I tried doing make with V=1 and it looked to me like kvmtool
> > > uses the same flags on x86 as on arm64, so I assumed it's because of the
> > > difference in compilers and I didn't dig further.
> > > 
> > > The remaining of the patches are there to improve PMU initialisation and
> > > error reporting.
> > 
> > Do you plan to post a v2 of these? I just ran into the 'const' issue
> > myself, so I'd love to see this stuff land after addressing the handful
> > of review comments I left on this version.
> 
> Yes, I was just about to put the finishing touches on v2 locally, I'll send
> it soon.

Thank you!

Will