From: Yosry Ahmed <yosry@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Brendan Jackman <brendan.jackman@linux.dev>,
sashiko-reviews@lists.linux.dev,
Brendan Jackman <jackmanb@google.com>,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
kvm@vger.kernel.org
Subject: Re: [PATCH v2 06/13] KVM: VMX: Use higher-level allocator
Date: Tue, 23 Jun 2026 00:29:02 +0000 [thread overview]
Message-ID: <ajnTJ03IxVnBXWdp@google.com> (raw)
In-Reply-To: <ajm_dEqauYLBi-7T@google.com>
On Mon, Jun 22, 2026 at 04:04:20PM -0700, Sean Christopherson wrote:
> On Mon, Jun 22, 2026, Brendan Jackman wrote:
> > On Mon Jun 22, 2026 at 10:10 AM UTC, sashiko-bot wrote:
> > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > > - [Medium] The commit message incorrectly states that `__alloc_pages_node()` allows passing `NUMA_NO_NODE`, while the opposite is true.
> > > --
> > >
> > > commit 7bd439c242125db27305b61b14c9972fb028282a
> > > Author: Brendan Jackman <jackmanb@google.com>
> > >
> > > KVM: VMX: Use higher-level allocator
>
> While you're dealing with nits, can you massage the shortlog to something like:
>
> KVM: VMX: Use no-underscores API when allocating pages for a specific NUMA node
>
> "Use higher-level allocator" is extremely vague, and arguably misleading because
> the "allocator" being used isn't changing. Which is kinda the point: *nothing*
> is changing in practice.
Maybe "higher-level allocator API"?
no-underscores is just.. meh :P
next prev parent reply other threads:[~2026-06-23 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 10:01 [PATCH v2 00/13] mm: Some cleanups for page allocator APIs Brendan Jackman
2026-06-22 10:01 ` [PATCH v2 06/13] KVM: VMX: Use higher-level allocator Brendan Jackman
2026-06-22 10:10 ` sashiko-bot
2026-06-22 10:21 ` Brendan Jackman
2026-06-22 23:04 ` Sean Christopherson
2026-06-23 0:29 ` Yosry Ahmed [this message]
2026-06-22 10:05 ` [PATCH v2 00/13] mm: Some cleanups for page allocator APIs Vlastimil Babka (SUSE)
2026-06-22 13:08 ` Lorenzo Stoakes
2026-06-22 13:15 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajnTJ03IxVnBXWdp@google.com \
--to=yosry@kernel.org \
--cc=brendan.jackman@linux.dev \
--cc=jackmanb@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox