From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 409F5450911 for ; Tue, 30 Jun 2026 15:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834920; cv=none; b=uIJz6f7T5kOACFsmSPZgtP6qr8+Ccl1GKSWT1reZAyAmqg8f2+QHAtjN7dKYUQYICuir3A5R2W/8ZAE+O+hsqK27ZUFQq5u2FC/8g70YE9d4M8tQ/eK4k58VsAasH4cQn1X2b9FKHV9XqV9umCx+Vbvv3tzcvULz6VNz8BDY/mw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834920; c=relaxed/simple; bh=q/CdBZIJ6A6qBJyymYNRI6oVTAoCPywZ7vcualAVIBs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G3kM8bVfJvmuEKXdWUzzH9dgwtguZNquDrWG/x/i6HbMHoQU7/n2ZdZd87XuboTfCC8EV9gOv4w1SZHWl8M5dXqeds/hS/IyZM0aqsQf668zP/mJo1DdAllAnUk05i1Xz4uPu+4ABmIsJiojFcQnXliNmAkOPRBEvpwnSXLnxY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=hAXgfuyB; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="hAXgfuyB" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-516d0db9372so37577941cf.2 for ; Tue, 30 Jun 2026 08:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1782834918; x=1783439718; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BHpENWZilS5aqo8aP9kraE35F/fs2tmonTK7cFttpS4=; b=hAXgfuyBmNSRLBE9y2YF+F07dfSGqHp1xa4sOxR62JYnFeKn0O8SVUpt0MG/md/bBA JctoHB5oCxWZ0Vqte8bR8RSDqbwrPbLPyAVhB0DByHbOdA2IOjZEXwL28LDk2LiqVjrv z7cG0BHGgqC45FdoWw1cu4SJuJyQa88fRtGXXXfw7jyqkOqfCXplQUZeMMFCZELfo79Z 1rk+m2RY+h+2uqsjj4YAZSp59JxW4a4ytdwsdrD3N7DKSKtyf+EXlgO8ty+/hiKhPyOz 5gPFlMDUP1DBAOlIJqYE17f25yvB/zUT9IPprAkfMavu6WBQtA17ghH9sjittg5ZdSha jlVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782834918; x=1783439718; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BHpENWZilS5aqo8aP9kraE35F/fs2tmonTK7cFttpS4=; b=IidezEuGR+wjSVPR6I8hhoFq4P1zvzcjlvMqEJZcTSDKJfxCi94BUlu/lXMOUFIQHI yH/WHOV6yxNxzwXVsQHWgCNKdB/CHmPf+4OwToDpD9+3ZMOVFynClc71qJnJO87YVX4+ SGhrjWOGldlggsQ/5zCR4LI1oL3M810Bm8Qr3xIfntSTvEyWh5MhmyDeB0fFi7U39UUZ XmQ/zQpit9QEQJzofsD/hQztF2yD3+cc/QER2Hjc3tfUu1yhY8q4zoqlzQhPexjfeChM +gRNNTDwbu1YpTszkNH4J0wsEea9ixm+bq0ioYvmatuEJXc+qmQTW+SXgNX6nJqp5v19 NaFg== X-Forwarded-Encrypted: i=1; AFNElJ/e2hyXq0Gi/GkrEfUOEniA20+SyZoa1RnjFmeNuScLQ4ubx8z38R067EzdwFeLbG3hTqM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw17HmydTWOHPfBweE/tRwMOzljvENAOJw56CTQ3RX61UPTtn+V OsDB+EJqo/vD5/lLcCjAuDdSVsEJvgkWoWHzxDn5/ay8+IZu3joy8WVXPh6M5KpdQNs= X-Gm-Gg: AfdE7cljX6idWoPnl9XxwX0iZoRjA7v1LVTZ14mVYe64GAX0trsEsYi2X2vdIMW+RLr HlGpFqOIiLrAdJx+3mkUk09BDpEFdXcv4k6WebJhyPRazLZbbZErL5djchT5AuksfuDhQkQBkl9 z7/TVIJuN23Kx7GQNp83aEBCS4WKrnLZvRIY2YLc4Mcsi7JJJNuPx95ZLBbwqHDenxCKvPdvwrv mPCDzmxPi4aTNtYrMMfF0Eiqcdvy3fdqLmlQcrSihAr2/NJP5D1FMZtNYhLH/Xdd9fg6VNQdYDW gXsO/BirQzRPkvFPbkUshmTpJRyzIZVolQ22FqbJ+73Msinaf63UcsCh666nk1Z/Q0t9VN54obe zMMq5FNdRZJGyQcvYFxd4Hyqr6U+HlEXe+RyKRpGXpcBE+ZRq8mypo7Ijzlc70Ou7mIX5KzsXjz oMHW598e4rssNsv0nBTIlnWmH3D0EMzLTl42MeDpopJs4Tbnn6cx5Eps6eEgbysqiNgRdC X-Received: by 2002:a05:622a:586:b0:51a:8c97:fb94 with SMTP id d75a77b69052e-51c10911601mr53620781cf.61.1782834918282; Tue, 30 Jun 2026 08:55:18 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c1080d149sm23102481cf.1.2026.06.30.08.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 08:55:17 -0700 (PDT) Date: Tue, 30 Jun 2026 11:55:12 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 09/30] mm/rmap: parameterise anon_vma_interval_tree_*() by anon_vma Message-ID: References: <1c1df7b905ef340cbf2effef769a4e770a8e0eb1.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 30, 2026 at 04:49:45PM +0100, Lorenzo Stoakes wrote: > On Tue, Jun 30, 2026 at 11:46:46AM -0400, Gregory Price wrote: > > On Mon, Jun 29, 2026 at 01:23:20PM +0100, Lorenzo Stoakes wrote: > > > Similar to what we did with mapping_interval_tree*(), let's declare > > > anon_vma_interval_tree*() in terms of anon_vma rather than rb_root_cached. > > > > > > In each case the rb tree referenced is &anon_vma->rb_root, so just pass > > > anon_vma and the functions can figure this out themselves. > > > > > > Additionally, rename 'node' to 'avc', 'index' to 'pgoff_start', and 'last' > > > to 'pgoff_last' to make clear what is being passed. > > > > > > > would it be possible to split the pure rename changes out from the > > changed function declarations? It's hard to pick out this as something > > that needs to be looked at as more than just a %s/x/y/ > > Hmmm do I have to? :P I mean, no :] > I mean sure I can on a respin potentially, but it is a > pretty trivial change? Just mechnically as above. > And yeah certainly not worth a respin. Just learning some of the friction points of reviewing as I spend a little more time doing it every day. ~Gregory