From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37F342CB05 for ; Thu, 9 Jul 2026 15:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612563; cv=none; b=dxPEJvVF9N9aIqTfOqa2JtTR9r3TU1cPO2cLBJynfiGaLrKPiJEXgxj6MBofBoiSyfIaMAAIVbIvf/2rapBLapbpd+gy2iPxicqa1zTo+yMj3uY8ypPM6zt0CZrth6gYUFYpRX/zF8MGCOyCiWQvj/KYySU4nvocyhW4U+ZejpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612563; c=relaxed/simple; bh=GOt99IJ7fgZPI8QmxyNzz1MEgzG9KnOmLnnihrfLrQE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PwXvVs2Z1Z5MJMyBggl4DFiKz0TGAfTJTKld3MAK/QSyKuQno24aGyGGah6VjdAxp9X++ikt2InxblIZs6YLmG3hIOv16D/ZFYHw84a7Hxyn8mqcA1lOCv212viY1Rgsaqx8r2xM5X0q10+coukjrVCGbuljlMwriAudaO1PoII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=sMpYtpBL; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="sMpYtpBL" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-51c1805b8a7so20092831cf.3 for ; Thu, 09 Jul 2026 08:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783612560; x=1784217360; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QupnWz0oLATZw6wM2bylQaqDWCRhZF5lJVU8oFwJF/g=; b=sMpYtpBLCayfT80R4wzbFZw9l7ecn/vectK5E5n8YBo3056+zypO+Cc5p+yKRJvgIH D/H6T9Xrdz6iMSYSYJvVieLq3byHbILjhri9t9JTeNg3KDdjrBUV59FOiPGxnwtT9VLy HF1d3IK7IocXO7FJq05gOC0dLYoa87K4H1Npkig9QMat1/arxBuPsjrF4STTmp+4SQnQ Vd1Ce49g4dasiNP2aD+fvBhZQJshbx6AC4CXzbMk76CVDp6xBP46+fI2JhSkG6d84zie Pt83KOr106cJz+pCklgtC47DW1rTZUKmoVq5ykQpYsi9pRg2A/xacQcZB/ubsxgpernK 7WxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612560; x=1784217360; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QupnWz0oLATZw6wM2bylQaqDWCRhZF5lJVU8oFwJF/g=; b=bZmbBr3+QmZILmIc8YuhdzhkGxJrP5cPRvYRYEG3BfltgEEPuhJpgjY41F6CDLtONE TnM4wQbkWR+YSBRL7JI92VLAFl4iPAM+2EAWVljl/jLM8h6tFJy9NY5J+AEtcDJlKOOP hcpXjyu9PyvUaIXa6p4jLUv0Msc/7No11sh9f8CsVxObfpR52qfxtGrUv3wG9tf/Vf0K ETlMJVSoFaLmcgj8EjATX+qNo00fULLOJX1/h+TgZMiZIy71dIBUiuI7E804mikyUJ+1 v4rUGybdgTtKl6axLl9h988AH3U7QkjaFY6oP3ybe4/JX0py78rXrOiKgxLbBOjNSk8L nnlQ== X-Forwarded-Encrypted: i=1; AHgh+Rp2DN9pAVCiCqon7x4ViyKljVdYgPYksti3Zo0Qr65PEPg4E1pfp09mqEvzXpsMmSYtaDs=@vger.kernel.org X-Gm-Message-State: AOJu0YwNMCufQ3IMChxlmgyTh8yUKMtdf5dMQyu2Ad+ySIMZH3GELxBY 7+qsMFnlwM2ZpATl9fIrCFp3y4/kMyxG2Ez9u60iuBq79vLU0vr5GvlgQ5WBP5LDsB4= X-Gm-Gg: AfdE7clcfACSmfJUi5x71WthitPtjgMTRZbXJBTjAgqhGfR3jmUodXIxGM87PJV3hUC T8xoA6mDypbcfI2fBTqE+wip83xKvaR83kmybh59tAx3yutqgFeSbwCTQX65Ld2tyb6L9axuyeL O8kuIR76SRAOHpU2pFXdxV0hNZ3Kj1uxEoNw50FY2r8C+PO5KPl/yXv4+lp1RyHBL4XHJcdE84P 1Ljzp4f9UxtAhhSbPDfoIAUr4+dUOy6m3X0u9TAmQop9MQTd58W7napyqOVgkrx2R9kCIgpuNkS YczZLWrPO3TsyDnCnQE8ZPlmz7UKiN/C8yko8jwTLUnAEQOXNScevbQK4BD1/6Qi/5BtL7Vx6rk aUphRnMoBf/y/qgMrgrDlCizNz690lsWC+gWzaE2eXwZ1B2MvGhr5NR78xwXM8tUSFQcWOcwSit 6Qb7LpvQpLQt4D9HhQeVWWquW03jPTjXobZlXpYOZHXNJ4eCdzFn/4ZeFjNSLuuOBwiwpO X-Received: by 2002:a05:622a:311:b0:51c:185b:29e0 with SMTP id d75a77b69052e-51c8b2ae67bmr82998651cf.10.1783612559586; Thu, 09 Jul 2026 08:55:59 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41d2d688sm169684691cf.17.2026.07.09.08.55.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:55:59 -0700 (PDT) Date: Thu, 9 Jul 2026 11:55:54 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 19/30] mm: use linear_page_[index, delta]() consistently Message-ID: References: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 29, 2026 at 01:23:30PM +0100, Lorenzo Stoakes wrote: > There are a number of places where we open code what linear_page_index() > and linear_page_delta() calculate. > > Replace this code with the appropriate functions for consistency. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes one nit Reviewed-by: Gregory Price ... > diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c > index c09bbe04be6c..536c25d8dcee 100644 > --- a/drivers/comedi/comedi_fops.c > +++ b/drivers/comedi/comedi_fops.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -2462,7 +2463,7 @@ static int comedi_vm_access(struct vm_area_struct *vma, unsigned long addr, > { > struct comedi_buf_map *bm = vma->vm_private_data; > unsigned long offset = > - addr - vma->vm_start + (vma->vm_pgoff << PAGE_SHIFT); > + addr - vma->vm_start + (vma_start_pgoff(vma) << PAGE_SHIFT); > Obviously correct, but was this intended for a different patch? ~Gregory