From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FC6437F73C for ; Fri, 10 Jul 2026 19:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783711568; cv=none; b=EIzqgpR0azDd+pywVx3+h+1HUJlGFe/yMP22hfnf49FQ2ubHo0LER9cMR5iUOyce8mlvNVTSoTH3MPlzeXMq4wwPWVqOjEVO3VFnVtA8Twil49jUa3mq67aa8mjBCZi4zAHKr3sOKTW+G3o0a/uQzxtwk3+53f6eOUBUFldfAhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783711568; c=relaxed/simple; bh=QOojT1E2vhWM7tSRUHih+fCOI5zTfyzCTjJ63JRhM4w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jxzdmgpe5UTxqVjGZdv2VUQZ67uLkIlqa2gBQKPw3wIwCp2rlT0gJKfgdi7+8gK//tcf7mb0GkeGXX3R0WKgZLZtIQKMjwEdMPchPmDV5q9JJ4YWzkSR/JvsBmxHpaws5nJHfvTyMJOL0FtYhFQ2RngAwPm9Vn1gEXHQ1XQLsbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=dbm+yKTe; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="dbm+yKTe" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-92e51d3d83cso67183385a.2 for ; Fri, 10 Jul 2026 12:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783711565; x=1784316365; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aHwFumUUjp1dZn3azv3jRxV2z4/4b2Y11BxxEMyANyA=; b=dbm+yKTeJMcBsc/CYkcTAQ4TIaGcuSrF3MF8158c1/hSDk31EH/NClDCmOcYl88b3+ hXK2sJzbsspq3YRmQe/WvOsgPfE3Qzw5eyC/EKH6hSvkj/mG9cOY7C4On4sX5yfxN23N IIZT62bWwMkkXTTwstqxKOhh8SSCO4kYe+3dI0dJ/f0zNPLVc0f/SCNfGd7jQQdwLW8y BbAHzwTvJM0kOtacFFyDuHKqRY4VG9oFO8eAMNtw/Gb2mSJuYiE890oQvrnVkH2rMIL/ 9/oLWYzMWVDHe+7TRYQoM0jPmN3lg+xFcC9eeEkkAzAAR19IeCxBEu5izY1fuWnQK5w2 rTwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783711565; x=1784316365; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aHwFumUUjp1dZn3azv3jRxV2z4/4b2Y11BxxEMyANyA=; b=labMia34h2hBDXJkfMPPR4wUpdeu153TSsxHCzH5pQBb86+M8xGJ0ePhq8jO63r/GG 7rgWdvpZA+syVZ2gaowcGZVXEEX8N+j0niZb5VxN0SFr6/KOborIHatfY5xP8r6Qgm/t RvR7uV9Swx4xUY20LxHLpBs0dfJ680h8CgvoBZRkm+Vy1g13Q3vEa2Tl7IdOYYiiAw3H h3K5PbrHpAq67nBQpcQ2Xmv7i8DHiyyjPx9c+/SrRApewho6dsLuD+SzJmQBIAlLVlJn paaj1Jp3Q+T1g42U/vnrLjwUPDWshiQeGUR2E9+/AGJQSz8J5IukjSXpKidRHJT/f7Ur lifw== X-Forwarded-Encrypted: i=1; AHgh+RpT/j0kxB4g/IbjN3y36DQScmg7dS0PTiDdYmeRxrAY+xah/aMHNkUt8ocnLA+lLfj/vT0=@vger.kernel.org X-Gm-Message-State: AOJu0YzlEyr2Q22ZAPePGwco4q4q1S4/rLEkoQ+O3sjjsvFMgxMxuTgD P4vO1LY4ZNInQ39a35tTvbOoAQp8u3Ala/pQxi6c/J4w5COI65E0ft3yODJJZXUzfdY= X-Gm-Gg: AfdE7cmWJ/k0iRJL8NM+AIm4GCK9Ri9BX7ooEBuhKJkLAhS2r2L72LTaXDGRQyXRwiz R0HPAzQ7RRYTHHzhB9LXd5xqv77QbDLfDmaxInk79CEitEooTXJSgxczRa61vkTWIk8sUwFJvUd Zg5vMi+sQPs1MxgZU+bLxsiE03WadY9A3NGLs77GNsEUp19xcmEt+sPqDU7akYCMgVcYIjUbrCP rDIJQTGlpQbvCngs4gtknPIos58rzzqeuBT+rbjvUXx+l1V2uw2y4OxGPj6+nS1WYw7jnGT/SC3 izgSCb265MxQTZlP5TTvSfju17V9ygq9FwP/FAZMOCqOTk9wjBRJf608/y22BXl7lW/DSdFE2BQ 8AxDzi7KFQcqqL4dgZAaOrJKG2zV7rWyUCD54PhbWN3J7PBXaoQZMW/ulANi0xaVZjEOEK4RIpw MrpAivgNPRmw0ZYWd9MZpHbEQJtMaQ3D76/Yj7NXAxgMKxirEtAr//TSCI4TNFMijg4uA5ETlQf 2V8Sbs= X-Received: by 2002:a05:620a:2993:b0:915:8502:f7f6 with SMTP id af79cd13be357-92ef2b575e8mr66564685a.35.1783711565033; Fri, 10 Jul 2026 12:26:05 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5d37540sm265182485a.38.2026.07.10.12.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 12:26:04 -0700 (PDT) Date: Fri, 10 Jul 2026 15:25:59 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 27/30] mm/vma: correct incorrect vma.h inclusion Message-ID: References: <22d0f4e3fe11f6fd1312734e242d008267ad142c.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22d0f4e3fe11f6fd1312734e242d008267ad142c.1782735110.git.ljs@kernel.org> On Mon, Jun 29, 2026 at 01:23:38PM +0100, Lorenzo Stoakes wrote: > The only files which should be including vma.h are the implementation files > for the core VMA logic - vma.c, vma_init.c, and vma_exec.c. > > This is in order to allow for userland testing of core VMA logic. In this > cases, vma_internal.h and vma.h are included, providing both the > dependencies upon which the core VMA logic requires and its declarations. > > Userland testable VMA logic is achieved by having separate vma_internal.h > implementations for userland and kernel. > > Callers other than the core VMA implementation should include internal.h > instead. This header does not need to include vma_internal.h as it only > contains the vma.h declarations, for which the includes already present > suffice. > > Update code to reflect this, update comments to reflect the fact there are > 3 VMA implementation files and document things more clearly. > > While we're here, slightly improve the language of the comment describing > vma_exec.c. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Gregory Price > +/* > + * To allow for userland testing we place internal dependencies in > + * vma_internal.h and external VMA API declarations in vma.h. > + */ ... > +/* > + * To allow for userland testing we place internal dependencies in > + * vma_internal.h and external VMA API declarations in vma.h. > + */ ... > +/* > + * To allow for userland testing we place internal dependencies in > + * vma_internal.h and external VMA API declarations in vma.h. > + */ Do you actually need 3 copies of this comment or just one copy in vma_internal.h?