From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B19939934D for ; Fri, 10 Jul 2026 20:20:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783714808; cv=none; b=HlvTQcrpLRy0WVoV6D1UoVIcQo0HYxKJSUTKOLAVZ0QgPVIEoc/G/aFMJ8zRZPkTyBnOiM7oGHp49qbifWRWd9tZRPeCrcRuYpfJvu3a7OEJvMcV5hMpqYOWRKxbNrTljDoA/q47+2lndUWCJKjedQqoVJH9D/l0fsQlppTjzLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783714808; c=relaxed/simple; bh=hY0ihDWAncS8x5azfJXUc95BFne8Ovg7UFiz7I6gZN4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ojNfny8YadmDfSF0noer+Yd/Tk+6bFMORgklzq457wMrhtQt+9rndo5EgfPAsEZyUWUFl4vtWqIcD7JhnG7il/N18X6Iqe0m9xrmVj8EzfmVr9aXwP9AFSlR4MPMMKXnaJtlXj0K8xNxj6PRsPhAkTgtJ9/nhUG3uvNBUBTwN8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=X3mYeLKC; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="X3mYeLKC" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-51c2cce930cso13412411cf.0 for ; Fri, 10 Jul 2026 13:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783714804; x=1784319604; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Atx/vDG1sDwzZEMAHR3NGh72ccSeLTTbFrhohwZH8Yk=; b=X3mYeLKCTjrKKg7CrKhhtCpJiHPHVx9i7wyXOXHXJaNZNTkaIVryh75DoorULOx84m TM+OwWO82Wa5PBzq/bp3fBMco7tSum+uO7dHKjgCrcAOtrj2ZcQoqjcMRdW+2pjSQB+w tlu3tni9BW495YqGesm+7e+WSEHEYWpHM5hPATAn+CpKpWPA/cUG+5VCwhc5PCHe0PUS MFkXf6cktWK5db+chO1jL7u4Y/QBBpOwl8MiEg45GxqUmoLXqyMpkCjPR69yebLQ4Enu QCcQoXAuwRIe5dPzaJOvDluq2JLNeIY5o4vGwaqPBzmc1kC+TmHXnJkELSBsdLoTg8vE umKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783714804; x=1784319604; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Atx/vDG1sDwzZEMAHR3NGh72ccSeLTTbFrhohwZH8Yk=; b=YdXOmHeFa0NLNHzVcu3biPzuC6m8sAD/euMdpdcI7EBiz+r2Rl8HuoGeXiRBhi6wAu EJTp5DHPwkD3ifaD32fgCA0itFangIiJj5/PCbaDE7uclcsdbnpX3MxpImefP65nAX8M 50wGUQUkaKQLqQ/Cq9DoaG0mD/t8NjuN2HwokV3xgwdr0dgcTjatIG8s8Oxf0wNAufWT VIMhs4UhmzCtd9PLGhjO1IMMAlZs9Hp/ZMOynZwu0JbhWpGb9qL+/96vOYy4/AgHEZ/x AiqAXWA+1Z1czgN4VYlX8i9p5N8AkHKaLKyP06ec4DcGLT9YzRdjVX9s0fBNBH6gHqtI qDeQ== X-Forwarded-Encrypted: i=1; AHgh+RqrvFu+vNvoLoDP/S7nDSt7g/ggs6gcE4PuJU5tVfWeblQ8eh+ffqK2f3a7JM5fli23jxU=@vger.kernel.org X-Gm-Message-State: AOJu0YyG61yfzkKZSupxptb6HIs7gqPxvD18+wGz/FpV78PiIdpQg9aH 6CjD4reIptLHjBp48GsWDjxMl8DuNYIM2AgbxqoriFS1rTOLGJhLm//m2TtYYiKrjF4= X-Gm-Gg: AfdE7cnjrhVM10UAg3/+BvoZ+cvR8ydzsmGtTHxK6BYqLx1AYz6AqpEWioacxv0YZLu L///yuzUVZaE5o2ZFqKO9TkhtH1M5jaZgspTiQPI7eHVBl9v0/cIS4kTGJStpeu9tzVA9haFmQb v/UD92HKaOT1vR6WJUIQ3kaZILgUFJr57gzxMnt2X+jE/2KM5uYG+/6p3+AgHUjzsyE8o+4//q9 PWl5QltZdS96YyRg8HOixVbWEn4MwnbFGHkz2jIMrGbzVbWNyiprNVMOLDR89m1WAJE0E08SBaG rnuXHwEo8nBgqpxF3FvjFsLCZdl6JFrm0I+HRc59flnt69xLBYgO6CUCjK+zUKb67FnPyP0j5Yn wIqS47jzgEBdTeEi2XIxmZ2L9TJTQVx9+NaTy+Jb+h6iYAXt90s8DUmsM12+zI5yC1YVD2t0mkY unIZ1rcuOGF0Sh405MGE4GNdTkSoRMEUIJQm5f4tfeaQHP73bnJ/zflBHIQIW5Dfmfcmq+ X-Received: by 2002:ac8:7c56:0:b0:51c:1291:911c with SMTP id d75a77b69052e-51cbf0e0649mr5096251cf.14.1783714804352; Fri, 10 Jul 2026 13:20:04 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd50e10f4sm49427896d6.1.2026.07.10.13.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 13:20:03 -0700 (PDT) Date: Fri, 10 Jul 2026 16:19:58 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 29/30] tools/testing/vma: default VMA flag bits to 64-bit Message-ID: References: <27cd07f6dd862d92410cf9db03f7c11e5f66854d.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27cd07f6dd862d92410cf9db03f7c11e5f66854d.1782735110.git.ljs@kernel.org> On Mon, Jun 29, 2026 at 01:23:40PM +0100, Lorenzo Stoakes wrote: > With all of the sanitisers turned on, setting the VMA flag bits depth to > 128 by default results in overly long build times. > > Reduce this to 64 - we can always manipulate these later for testing of > larger bitmaps as needed. > > Signed-off-by: Lorenzo Stoakes Seems like this causes instrumented inlining to go crazy. static inline void bitmap_or(...) { if (small_const_nbits(nbits)) *dst = *src1 | *src2; else __bitmap_or(dst, src1, src2, nbits); ^^^^ this branch is being hit ^^^^ } tl;dr: __bitmap_or() gets emitted and then the sanitizers have to instrument a ton of inlined functions instead of the compiler simply injecting a couple 'or' instructions. if you wanted to keep the coverage you could do something like # These can be varied to test different sizes. NUM_VMA_FLAG_BITS ?= 64 NUM_MM_FLAG_BITS ?= 64 CFLAGS += -DNUM_VMA_FLAG_BITS=$(NUM_VMA_FLAG_BITS) -DNUM_MM_FLAG_BITS=$(NUM_MM_FLAG_BITS) w/ make NUM_VMA_FLAG_BITS=128 would let you still test the branch but not by default. anyway: Reviewed-by: Gregory Price ~Gregory