From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9F503B42C8 for ; Fri, 10 Jul 2026 21:10:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783717804; cv=none; b=UQkOUH9lX6fAvXlAwQHUgq6EBU2N1YWo7cI2IuPnXu770VtyRZD5fe5aF1nEwtRVy6idTi16knaWguyyahSpKuwMKtxN8W4KaBqzZFEPumtAYbItJSTTMnjsrMuXPu6tz/FqN+mRPjrhRwY2z4f+l7tOpRbvMPdk7g5aF+gZvCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783717804; c=relaxed/simple; bh=dNW60Nn0Pk4RAFrYvjK4f4wy+wh7S7nAq4Uli4yrIhU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NgvEun1M+e2l7Af2utkJkTIy86pftdjXW7iG6QNiGOkrBR5wWYcbvTb842nECUiFkqnFZqrBYA0ukoCcI8Nj82Nc/v3BwNRpXSQs6APLvdI+RIFt2+xoOIH+7tDkUJHobr1401JNanaoyNGqeEYjx6qGqJ2ExaPZoPbg8AltpoY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=IeOfG/44; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="IeOfG/44" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-8eeadbc5e21so10662706d6.3 for ; Fri, 10 Jul 2026 14:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783717801; x=1784322601; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=FM5wmgcpnXqQ2LPOtHbLfNIfX5IHSF2YMfcySjsQd8k=; b=IeOfG/44lUDhZNIy2n53/oJ2urnUwg/8zqSNAqnWhDDzsuc2hRT/2MJ44iW3PIUUdY 0cKCLWB1ldejcRPaxLKKE2HNwwb5n6ERzHg4JGWFDufdCh56F770PixKeR5QwDzQznz1 Jmx/9iGCwJs5BmrWXg5kE7KtFI3LPyXEmWOGL3lAh64raZt3/H3BRH4jM+3Ckk1pq0gS AVdCqYlgpu3IdxLLPaWkz2qyyo3FTRx6zjiABH8qF1KwW2Jm/HULxy3PrZTkOXDKa4ZT b0yZMAD13765/Yo1FNsj9VMVnFaBJKi3QlTJITHTFpoqoSFecjMGs9mDCknxy9BlA7ql oyTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783717801; x=1784322601; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FM5wmgcpnXqQ2LPOtHbLfNIfX5IHSF2YMfcySjsQd8k=; b=klSwYh2CWJjKc2bVHlxeuLZrkO1hlNNld61WMVknwl03oCMEp3KYcgNqmcJpWKc+ii +DtSbWHFsFw6tVqr1Aa1LCQIXioyUFCvTYRRS4yGYHuoC+de50Wu8F/rDnoEaTDQbacs Mq+57IPn/aIwHWU3z/Xxz9DT1xEDqsvkNo81l7jue7xpVZ4q5E/Y6k9XZE1pUO8FS6Ns 0+7PbP/4cavFekoJlzQe2LvEbiwupBsSYGC/Fwqzh8r7j+Buev3TcHGLAjgTVYDka6Ut M2+lYIkatZY2p0jMP8mlqobdDFlDlbN0bnxtyJV8RZy8njLrfzO4+MuBczRh6k7b81IS TTuw== X-Forwarded-Encrypted: i=1; AHgh+RrvjY36izbuWvZvfWvEJ48XuoeMYact6WSm92A/LtozJ00uxIkPFU3p4r9/ZGzDcUvtxjA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7yN63Zzs40IrsV+MXAoHcbe9RxqMZVeuaI0qQeogAtGf5qQ7C XoVrTygl3ZiRgFOoaVwQm7YZnEaTG4doHZo561hbJudqZEgijEhIpSwnmnnqAY+uPC0= X-Gm-Gg: AfdE7clDiNzs0rr90Jd75lwoc2mK1DX+hAoqIG3sYdsvXh400CHV4drmDYaUhgT6PEp jcL2+U3b8nCyoAxZKnAAizZcI4Vsk776iKAwnPQC38WpOUCtRxX/OCGwHRpdM4epZxSeNefXCpK 3Fx9wI63iDBWnCrTpS9DKSBTtgGaa3ruVD57oYP3qPjagcbQ4clWrATSmElBkgGfz6kJsgeN/ZU J5Cba17WfIdb1jVrin+nkmVoNG56ttnlGmqDnQCULcAsoFWSD7k2TxFjs3eKWBh07qJhX2g449I tzl5nF26wZJbH/tZswDO/gxRYD2GmNzYLU/FMmDhWARW0hrAKlDkByXKxPbEY8Im/kErNVaUO9L t3esPkCmWt8sO1h5TXOdOanS+UH2T6YU3oy2Eo2WbB3poxctGbtqQhpvUE11ufcal8VhLeuUAIK kprULBmz+M2tqrUKOtKPSnUrIq+pTlmvvapgns5xSGjsG/VsgOR6wYaSydd6i+LJqgoH87 X-Received: by 2002:a05:6214:31a1:b0:8d1:d1e1:8360 with SMTP id 6a1803df08f44-90400b7f3e1mr9010646d6.39.1783717800595; Fri, 10 Jul 2026 14:10:00 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd87c8d4csm52955776d6.44.2026.07.10.14.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 14:09:59 -0700 (PDT) Date: Fri, 10 Jul 2026 17:09:54 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Jann Horn , Lance Yang , Pedro Falcato , Russell King , Dinh Nguyen , Simon Schuster , "James E.J. Bottomley" , Helge Deller , Alexander Viro , Christian Brauner , Jan Kara , Dan Williams , Matthew Wilcox , Muchun Song , Oscar Salvador , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Miaohe Lin , Naoya Horiguchi , Xu Xin , Chengming Zhou , SJ Park , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Hugh Dickins , Peter Xu , Kees Cook , Marek Szyprowski , Robin Murphy , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Steven Rostedt , Mathieu Desnoyers , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Huang Rui , Matthew Auld , Jason Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Ankit Agrawal , Alex Williamson , Paolo Bonzini , Shakeel Butt , Usama Arif , linux-mm@kvack.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, Russell King Subject: Re: [PATCH v2 33/33] tools/testing/vma: output compared expression on ASSERT_[EQ, NE]() Message-ID: References: <20260710-b4-pre-scalable-cow-v2-0-2a5aa403d977@kernel.org> <20260710-b4-pre-scalable-cow-v2-33-2a5aa403d977@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710-b4-pre-scalable-cow-v2-33-2a5aa403d977@kernel.org> On Fri, Jul 10, 2026 at 09:17:14PM +0100, Lorenzo Stoakes wrote: > Update the macros to output the compared values at hex for easier debugging > when test asserts fail. > > We have to be careful not to re-evaluate expressions as they may have > side-effects. So update the code to take local copies and use these for > both the test and the debug output. Aw you found it before i reported it :] > > Also remove unused IS_SET() macro. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Gregory Price