From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <error27@gmail.com>
Subject: [patch] add some unlocks on error paths irq_comm.c
Date: Tue, 10 Nov 2009 10:57:09 +0200 (SAST)
Message-ID: <alpine.DEB.2.00.0911081905380.8081@bicker>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: avi@redhat.com, mtosatti@redhat.com
To: kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-bw0-f227.google.com ([209.85.218.227]:51209 "EHLO
	mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752171AbZKJI5U (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 10 Nov 2009 03:57:20 -0500
Received: by bwz27 with SMTP id 27so4302065bwz.21
        for <kvm@vger.kernel.org>; Tue, 10 Nov 2009 00:57:24 -0800 (PST)
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

There were a couple unlocks missing.  They were found by smatch static 
checker.  Compile tested.

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27@gmail.com>

--- orig/virt/kvm/irq_comm.c	2009-11-08 19:00:50.000000000 +0200
+++ devel/virt/kvm/irq_comm.c	2009-11-08 19:04:45.000000000 +0200
@@ -209,6 +209,7 @@
 				sizeof(kvm->arch.irq_sources_bitmap));
 
 	if (irq_source_id >= sizeof(kvm->arch.irq_sources_bitmap)) {
+		mutex_unlock(&kvm->irq_lock);
 		printk(KERN_WARNING "kvm: exhaust allocatable IRQ sources!\n");
 		return -EFAULT;
 	}
@@ -229,6 +230,7 @@
 	mutex_lock(&kvm->irq_lock);
 	if (irq_source_id < 0 ||
 	    irq_source_id >= sizeof(kvm->arch.irq_sources_bitmap)) {
+		mutex_unlock(&kvm->irq_lock);
 		printk(KERN_ERR "kvm: IRQ source ID out of range!\n");
 		return;
 	}