From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH] kvm tool: Remove the __stringify* defination from the
 util.h
Date: Sat, 16 Apr 2011 12:47:18 +0300 (EEST)
Message-ID: <alpine.DEB.2.00.1104161247000.5863@tiger>
References: <1302896625-11041-1-git-send-email-prasadjoshi124@gmail.com> <BANLkTime5Zwqj0pLy6_Kxo1BTaLiOEto8A@mail.gmail.com> <20110416094535.GB24711@elte.hu>
Mime-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-1709685706-1302947238=:5863"
Cc: Prasad Joshi <prasadjoshi124@gmail.com>, kvm@vger.kernel.org,
	asias.hejun@gmail.com, gorcunov@gmail.com, levinsasha928@gmail.com,
	chaitanyakulkarni15@gmail.com
To: Ingo Molnar <mingo@elte.hu>
Return-path: <kvm-owner@vger.kernel.org>
Received: from filtteri1.pp.htv.fi ([213.243.153.184]:48035 "EHLO
	filtteri1.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758590Ab1DPJrU (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 16 Apr 2011 05:47:20 -0400
In-Reply-To: <20110416094535.GB24711@elte.hu>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1709685706-1302947238=:5863
Content-Type: TEXT/PLAIN; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: 8BIT

On Sat, 16 Apr 2011, Ingo Molnar wrote:

>
> * Pekka Enberg <penberg@kernel.org> wrote:
>
>> On Fri, Apr 15, 2011 at 10:43 PM, Prasad Joshi <prasadjoshi124@gmail.com> wrote:
>>> Include the Linux kernel header file linux/stringify.h file instead of
>>> redefining the __stringify* macros
>>>
>>> Signed-off-by: Prasad Joshi <prasadjoshi124@gmail.com>
>>> ---
>>>  tools/kvm/include/kvm/util.h |    5 ++---
>>>  1 files changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/tools/kvm/include/kvm/util.h b/tools/kvm/include/kvm/util.h
>>> index ae033cc..c308f3f 100644
>>> --- a/tools/kvm/include/kvm/util.h
>>> +++ b/tools/kvm/include/kvm/util.h
>>> @@ -1,3 +1,5 @@
>>> +#include "../../../../include/linux/stringify.h"
>>
>> #include <linux/stringify.h> should just work, no?
>
> Only if kernel headers are installed. Also, and perhaps more importantly, in
> the context of perf it was more robust to use the same kernel repo's source
> code that perf resides in - should there be any fixes needed it's a lot easier
> to remedy things.

We do this in the Makefile:

-I../../include -I../../arch/$(ARCH)/include/

so it should just work.
--8323329-1709685706-1302947238=:5863--