From: Pekka Enberg <penberg@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com,
gorcunov@gmail.com, prasadjoshi124@gmail.com
Subject: Re: [PATCH 6/7] kvm tools: Rename command source files
Date: Sat, 9 Jul 2011 01:24:46 +0300 (EEST) [thread overview]
Message-ID: <alpine.DEB.2.00.1107090124190.2927@tiger> (raw)
In-Reply-To: <1310162174-3426-6-git-send-email-levinsasha928@gmail.com>
On Sat, 9 Jul 2011, Sasha Levin wrote:
> Rename kvm-[command] into builtin-[command] to prevent
> clashes with non-command files such as kvm-cpu.h
>
> Suggested-by: Pekka Enberg <penberg@kernel.org>
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
I see this when I apply your patch:
penberg@tiger:~/linux/tools/kvm$ make
builtin-help.c:5:25: error: common-cmds.h: No such file or directory
KVMTOOLS_VERSION = 3.0.rc5.683.g44315f
builtin-help.c:5:25: error: common-cmds.h: No such file or directory
make: *** No rule to make target `builtin-help.d', needed by `kvm'. Stop.
next prev parent reply other threads:[~2011-07-08 22:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 21:56 [PATCH 1/7] kvm tools: Add 'kvm version' command Sasha Levin
2011-07-08 21:56 ` [PATCH 2/7] kvm tools: Properly add 'kvm list' to command list Sasha Levin
2011-07-08 21:56 ` [PATCH 3/7] kvm tools: Properly add 'kvm debug' " Sasha Levin
2011-07-08 21:56 ` [PATCH 4/7] kvm tools: Update 'kvm pause' documentation Sasha Levin
2011-07-08 21:56 ` [PATCH 5/7] kvm tools: Properly add 'kvm balloon' to command list Sasha Levin
2011-07-08 21:56 ` [PATCH 6/7] kvm tools: Rename command source files Sasha Levin
2011-07-08 22:24 ` Pekka Enberg [this message]
2011-07-09 6:47 ` Sasha Levin
2011-07-08 21:56 ` [PATCH 7/7] kvm tools: Rename debug options under 'kvm run' Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1107090124190.2927@tiger \
--to=penberg@kernel.org \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox