From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH 1/3] kvm tools: Make keyboard termination go through regular termination path Date: Thu, 11 Aug 2011 17:04:09 +0300 (EEST) Message-ID: References: <1313066636-28332-1-git-send-email-levinsasha928@gmail.com> <1313070086.3456.17.camel@lappy> <1313070518.3456.18.camel@lappy> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com To: Sasha Levin Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:57974 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379Ab1HKOEN (ORCPT ); Thu, 11 Aug 2011 10:04:13 -0400 Received: by bke11 with SMTP id 11so999924bke.19 for ; Thu, 11 Aug 2011 07:04:12 -0700 (PDT) In-Reply-To: <1313070518.3456.18.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 11 Aug 2011, Sasha Levin wrote: >> You get a different printf: >> >> $ grep -r "KVM session" *.c >> builtin-run.c: printf("\n # KVM session ended normally.\n"); >> term.c: printf("\n # KVM session terminated.\n"); >> >> It's nice to see that the user terminated the session without going >> through reboot cycle. Dunno how much it matters but it'd be nice to keep >> it since it's already there. > > Hm... In that case, how about changing it to "# KVM session > terminating..." which will be followed by "# KVM session terminated" > when the guest is actually dead? It would just add more noise. Oh well, I applied your patch. Pekka