From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH 1/7] kvm tools: Print version when running 'kvm --version' Date: Fri, 12 Aug 2011 18:39:46 +0300 (EEST) Message-ID: References: <1313162460-14397-1-git-send-email-levinsasha928@gmail.com> <20110812152240.GA20279@walimis-desktop> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Sasha Levin , kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com To: walimis Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:59059 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752885Ab1HLPjv (ORCPT ); Fri, 12 Aug 2011 11:39:51 -0400 Received: by bke11 with SMTP id 11so1735048bke.19 for ; Fri, 12 Aug 2011 08:39:50 -0700 (PDT) In-Reply-To: <20110812152240.GA20279@walimis-desktop> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 12 Aug 2011, walimis wrote: >> @@ -24,6 +24,7 @@ struct cmd_struct kvm_commands[] = { >> { "balloon", kvm_cmd_balloon, NULL, 0 }, >> { "list", kvm_cmd_list, NULL, 0 }, >> { "version", kvm_cmd_version, NULL, 0 }, >> + { "--version", kvm_cmd_version, NULL, 0 }, > Although it works, I think it's not good way to implement a option > as a command. Well, I already merged the patch because the whole series was so super-cool. What downsides are there to implementing the alias like this? Pekka