From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [patch] vhost: NULL vs ERR_PTR bug Date: Wed, 15 Jul 2015 10:21:12 -0400 (EDT) Message-ID: References: <20150715111659.GA22854@mwanda> <20150715142420-mutt-send-email-mst@redhat.com> <55A64574.1090907@bfs.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "Michael S. Tsirkin" , Dan Carpenter , Igor Mammedov , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, kernel-janitors@vger.kernel.org To: walter harms Return-path: In-Reply-To: <55A64574.1090907@bfs.de> Sender: kernel-janitors-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, 15 Jul 2015, walter harms wrote: > > > Am 15.07.2015 13:28, schrieb Michael S. Tsirkin: > > On Wed, Jul 15, 2015 at 02:16:59PM +0300, Dan Carpenter wrote: > >> There is only one caller for vhost_kvzalloc() and it expects NULL on > >> allocation failure. Most people would probably expect that so let's > >> change ERR_PTR(-ENOMEM) to NULL. > >> > >> Fixes: 4de7255f7d2b ('vhost: extend memory regions allocation to vmalloc') > >> Signed-off-by: Dan Carpenter > > > > Ouch. Thanks a lot for noticing this, and it's a good thing > > you did before Linus merged it. > > I'll squash this into Igor's patch and redo my pull request. > > > > Is this function needed at all ? > > e.g. I followed vzalloc() to __vmalloc_node_range() > > a check for size==0 seems to be done there. At least it looks like one could return the result of vzalloc directly? julia > > re, > wh > > > >> > >> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > >> index a9fe859..99d613b 100644 > >> --- a/drivers/vhost/vhost.c > >> +++ b/drivers/vhost/vhost.c > >> @@ -686,7 +686,7 @@ static void *vhost_kvzalloc(unsigned long size) > >> if (!n) { > >> n = vzalloc(size); > >> if (!n) > >> - return ERR_PTR(-ENOMEM); > >> + return NULL; > >> } > >> return n; > >> } > > -- > > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >