From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 1/2] cpuid: Add a helper in scattered.c to return
 cpuid leaf info
Date: Tue, 8 Nov 2016 16:11:36 +0100 (CET)
Message-ID: <alpine.DEB.2.20.1611081606310.3501@nanos>
References: <1478595148-4462-1-git-send-email-he.chen@linux.intel.com> <1478595148-4462-2-git-send-email-he.chen@linux.intel.com> <20161108103008.drrg2dovlxkvs7du@pd.tnic>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Cc: He Chen <he.chen@linux.intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?ISO-8859-2?Q?Radim_Kr=E8m=E1=F8?= <rkrcmar@redhat.com>,
        Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Luwei Kang <luwei.kang@intel.com>,
        Piotr Luc <Piotr.Luc@intel.com>
To: Borislav Petkov <bp@alien8.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20161108103008.drrg2dovlxkvs7du@pd.tnic>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Tue, 8 Nov 2016, Borislav Petkov wrote:
> On Tue, Nov 08, 2016 at 04:52:27PM +0800, He Chen wrote:
> > +struct cpuid_regs {
> > +	u32 eax, ebx, ecx, edx;
> > +};
> 
> Why do you export this? It is used in cpuid.c only.

Because I asked for it. We should have this stuff in one place to avoid the
next name clash.
 
What's worse with that patch is, that it does two things in one go:

    - cleanup that whole cpuid_regs mess

    - add the new function

That should clearly be seperated into two patches.

Thanks,

	tglx