From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH 2 of 3] mm_take_all_locks Date: Thu, 5 Jun 2008 09:15:41 -0700 (PDT) Message-ID: References: <082f312bc6821733b1c3.1212680169@duo.random> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Andrew Morton , Christoph Lameter , Jack Steiner , Robin Holt , Nick Piggin , Peter Zijlstra , kvm@vger.kernel.org, Kanoj Sarcar , Roland Dreier , Steve Wise , Linux Kernel Mailing List , Avi Kivity , linux-mm@kvack.org, general@lists.openfabrics.org, Hugh Dickins , Rusty Russell , Anthony Liguori , Chris Wright , Marcelo Tosatti , Eric Dumazet , "Paul E. McKenney" , Izik Eidus , Anthony Liguori , Rik van Riel To: Andrea Arcangeli Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:60201 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753591AbYFEQSj (ORCPT ); Thu, 5 Jun 2008 12:18:39 -0400 In-Reply-To: <082f312bc6821733b1c3.1212680169@duo.random> Sender: kvm-owner@vger.kernel.org List-ID: Just a small comment fix. On Thu, 5 Jun 2008, Andrea Arcangeli wrote: > + /* > + * AS_MM_ALL_LOCKS can't change from under us because > + * we hold the global_mm_spinlock. There's no global_mm_spinlock, you mean the 'mm_all_locks_mutex'. (There was at least one other case where you had that comment issue). Linus