From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 05/28] kvm tools: 64-bit tidy; use PRIx64 when printf'ing
 u64s and link appropriately
Date: Wed, 7 Dec 2011 19:21:04 +0200 (EET)
Message-ID: <alpine.LFD.2.02.1112071919400.1646@tux.localdomain>
References: <cover.1323141075.git.matt@ozlabs.org> <4EDD8E4D.5000309@ozlabs.org> <1323159238.3882.6.camel@lappy> <20111206082827.GA30062@elte.hu> <20111206100538.GA8178@bloggs.ozlabs.ibm.com> <20111206102428.GB15966@elte.hu> <4EDF0F60.8080301@ozlabs.org>
 <20111207081602.GA8023@elte.hu> <4EDF60BF.2020700@redhat.com>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Ingo Molnar <mingo@elte.hu>, Matt Evans <matt@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>,
	Sasha Levin <levinsasha928@gmail.com>, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <4EDF60BF.2020700@redhat.com>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 12/07/2011 09:16 AM, Ingo Molnar wrote:
>>> >  That's what's happening here; we're __powerpc64__ and
>>> >  !__KERNEL__, tools/kvm/include/linux/types.h includes
>>> >  asm/types.h so gets the int-l64.h definition of __u64, as
>>> >  above.  :/
>>> >
>>> >  builtin-run.c:389: error: format `%llx' expects type `long
>>> >  long unsigned int', but argument 2 has type `u64'
>> So either define __KERNEL__ or patch a __NEW_USERSPACE__ define
>> into power/asm/types.h and use it - if the PowerPC folks agree
>> with that approach.
>> 
>> Sane userspace should not be prevented from using the same sane
>> types the kernel is already using:-)

On Wed, 7 Dec 2011, Paolo Bonzini wrote:
> I should dig up that patent of mine for "apparatus for conversion of circular 
> motion to rectilinear ('wheel')".

What's your point?

We use kernel types for obvious reasons and it trying to use <stdint.h> 
for the PPC port is just begging for trouble.

 			Pekka