From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH] kvm tools: Fix segfault when failing to initialize KVM Date: Wed, 1 Feb 2012 09:05:34 +0200 (EET) Message-ID: References: <1328062060-17262-1-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: mingo@elte.hu, gorcunov@gmail.com, asias.hejun@gmail.com, kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:35461 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753213Ab2BAHFs (ORCPT ); Wed, 1 Feb 2012 02:05:48 -0500 Received: by lagu2 with SMTP id u2so481548lag.19 for ; Tue, 31 Jan 2012 23:05:47 -0800 (PST) In-Reply-To: <1328062060-17262-1-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 31 Jan 2012, Sasha Levin wrote: > Might happen when hardware virtualization is not supported. > > Reported-by: Ingo Molnar > Signed-off-by: Sasha Levin > --- > tools/kvm/builtin-run.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c > index 6ded1d2..a67faf8 100644 > --- a/tools/kvm/builtin-run.c > +++ b/tools/kvm/builtin-run.c > @@ -997,6 +997,10 @@ static int kvm_cmd_run_init(int argc, const char **argv) > } > > kvm = kvm__init(dev, hugetlbfs_path, ram_size, guest_name); > + if (IS_ERR_OR_NULL(kvm)) { > + r = PTR_ERR(kvm); How is this going to work when 'kvm' is NULL? It'd be best if kvm_init() never returned NULL on error. > + goto fail; > + } > > kvm->single_step = single_step; > > -- > 1.7.8.4 > >