From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH] kvm: optimize ISR lookups Date: Tue, 22 May 2012 00:44:39 +0200 (CEST) Message-ID: References: <20120521163727.GA13337@redhat.com> <20120521215127.GH17031@redhat.com> <20120521222449.GJ17031@redhat.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: kvm@vger.kernel.org, Avi Kivity , Marcelo Tosatti , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from www.linutronix.de ([62.245.132.108]:33891 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755465Ab2EUWoo (ORCPT ); Mon, 21 May 2012 18:44:44 -0400 In-Reply-To: <20120521222449.GJ17031@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Michael, On Tue, 22 May 2012, Michael S. Tsirkin wrote: > On Tue, May 22, 2012 at 12:14:18AM +0200, Thomas Gleixner wrote: > > On Tue, 22 May 2012, Michael S. Tsirkin wrote: > > > > > On Mon, May 21, 2012 at 11:04:25PM +0200, Thomas Gleixner wrote: > > > > > @@ -242,6 +262,25 @@ static inline void apic_clear_irr(int vec, struct kvm_lapic *apic) > > > > > apic->irr_pending = true; > > > > > } > > > > > > > > > > +static inline void apic_set_isr(int vec, struct kvm_lapic *apic) > > > > > +{ > > > > > + if (!__apic_test_and_set_vector(vec, apic->regs + APIC_ISR)) > > > > > + ++apic->isr_count; > > > > > + ASSERT(apic->isr_count > MAX_APIC_VECTOR); > > > > > > > > I'm really curious what you observed when defining DEBUG in that file. > > > > > > > > Clearly you never did. > > > > > > Sorry :( > > > Yes clearly silly, thanks for pointing this out. > > > > That's all you have a reply for? That's the least of the problems .... > > Others are not my fault :) Interesting. The other changes you added are not your fault? So you provided a patch which you didn't author completely. You merily added the bogus ASSERTs, right ? Can you please explain why there is only your SOB on that patch? Thanks, tglx