From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5A1C433E1 for ; Sat, 22 Aug 2020 18:31:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A6D32086A for ; Sat, 22 Aug 2020 18:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728609AbgHVSbe (ORCPT ); Sat, 22 Aug 2020 14:31:34 -0400 Received: from orcam.me.uk ([81.187.245.177]:32992 "EHLO orcam.me.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727893AbgHVSbe (ORCPT ); Sat, 22 Aug 2020 14:31:34 -0400 X-Greylist: delayed 400 seconds by postgrey-1.27 at vger.kernel.org; Sat, 22 Aug 2020 14:31:33 EDT Received: from bugs.linux-mips.org (eddie.linux-mips.org [IPv6:2a01:4f8:201:92aa::3]) by orcam.me.uk (Postfix) with ESMTPS id CC3F02BE086; Sat, 22 Aug 2020 19:24:49 +0100 (BST) Date: Sat, 22 Aug 2020 19:24:47 +0100 (BST) From: "Maciej W. Rozycki" To: Thomas Bogendoerfer cc: Greg KH , Paolo Bonzini , Jiaxun Yang , Huacai Chen , Aleksandar Markovic , kvm@vger.kernel.org, linux-mips@vger.kernel.org, Fuxin Zhang , Huacai Chen , stable@vger.kernel.org Subject: Re: [PATCH] MIPS: VZ: Only include loongson_regs.h for CPU_LOONGSON64 In-Reply-To: <20200810093158.GA6026@alpha.franken.de> Message-ID: References: <1596891052-24052-1-git-send-email-chenhc@lemote.com> <20200808153123.GC369184@kroah.com> <2b2937d0-eae6-a489-07bd-c40ded02ce89@flygoat.com> <20200809070235.GA1098081@kroah.com> <5ffc7bb1-8e3f-227a-7ad0-cec5fc32a96a@redhat.com> <20200810074417.GA1529187@kroah.com> <5522eef8-0da5-7f73-b2f8-2d0c19bb5819@redhat.com> <20200810090310.GA1837172@kroah.com> <20200810093158.GA6026@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 10 Aug 2020, Thomas Bogendoerfer wrote: > > > It's not just this #include, there's a couple dozen mach-* directories; > > > changing how they work would be up to the MIPS maintainers (CCed), and > > > it would certainly not be a patch that can be merged in stable@ kernels. > > > > > > arch/mips/kernel/cpu-probe.c has the same > > > > > > #ifdef CONFIG_CPU_LOONGSON64 > > > #include > > > > > > for example, so apparently they're good with this. So if I don't pick > > > up the patch to fix the build it would be in all likelihood merged by > > > MIPS maintainers. The only difference will be how long the build > > > remains broken and the fact that they need to worry about KVM despite > > > the presence of a specific maintainer. > > > > Ok, fair enough, but in the long-run, this should probably be fixed up > > "properly" if this arch is still being maintained. > > I have it on my todo list. My plan is to move stuff out of mach-* directories, > which aren't needed there. This should solve issues like the one here. Correct, it looks like another maintainer's oversight. The asm/mach-/ directories are there for platform variants of generic stuff found in asm/mach-generic/. So if something is not there in asm/mach-generic/, then it must not be in any other asm/mach-/ subdirectory either. Regular platform headers need to go under asm//. Compare asm/mach-dec/ vs asm/dec/, or asm/mach-sibyte/ vs asm/sibyte/, and so on. So this `loongson_regs.h' piece belongs to asm/loongson64/ rather than asm/mach-loongson64/. Maciej