From mboxrd@z Thu Jan 1 00:00:00 1970 From: malc Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW() Date: Mon, 25 Jul 2011 14:46:21 +0400 (MSD) Message-ID: References: <1311583872-362-1-git-send-email-avi@redhat.com> <4E2D3CC2.7000206@redhat.com> <0AF62DBC-C10D-4C06-9FE3-CCE8AF912462@suse.de> <4E2D3F3E.70303@redhat.com> <060B54D0-566A-4749-BD7C-B3035C7E1792@suse.de> <4E2D40F0.1070604@redhat.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Avi Kivity , Blue Swirl , Peter Maydell , QEMU-devel Developers , "kvm@vger.kernel.org list" To: Alexander Graf Return-path: Received: from fe01x03-cgp.akado.ru ([77.232.31.164]:63223 "EHLO akado.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751673Ab1GYKqa (ORCPT ); Mon, 25 Jul 2011 06:46:30 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 25 Jul 2011, Alexander Graf wrote: > > On 25.07.2011, at 12:09, Avi Kivity wrote: > > > On 07/25/2011 01:04 PM, Alexander Graf wrote: > >> On 25.07.2011, at 12:02, Avi Kivity wrote: > >> > >> > On 07/25/2011 12:56 PM, Alexander Graf wrote: > >> >> > > >> >> > That argument can be used to block any change. You'll get used to it in time. The question is, is the new interface better or not. > >> >> > >> >> I agree that it keeps you from accidently malloc'ing a struct of pointer size. But couldn't we also just add this to checkpatch.pl? > >> > > >> > Better APIs trump better patch review. > >> > >> Only if you enforce them. The only sensible thing for QEMU_NEW (despite the general rule of upper case macros, I'd actually prefer this one to be lower case though since it's so often used) would be to remove qemu_malloc, declare malloc() as unusable and convert all users of qemu_malloc() to qemu_new(). > > > > Some qemu_mallocs() will remain (allocating a byte array or something variable sized). > > Right. But then we really do need a check in checkpatch.pl to see if someone's using qemu_new for simple structs. > > > I agree qemu_new() will be nicer, but that will have to wait until Blue is several light-days away from Earth. > > Blue, any disagreement on adding qemu_new() as a macro? Something used > that often in upper case would seriously disturb the reading flow :) So do not use it then, macros should be uppercase. -- mailto:av1474@comtv.ru