From mboxrd@z Thu Jan 1 00:00:00 1970 From: malc Subject: Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support Date: Mon, 25 Jul 2011 19:16:27 +0400 (MSD) Message-ID: References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-12-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from fe02x03-cgp.akado.ru ([77.232.31.165]:64675 "EHLO akado.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751271Ab1GYPQd (ORCPT ); Mon, 25 Jul 2011 11:16:33 -0400 In-Reply-To: <1311602584-23409-12-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 25 Jul 2011, Avi Kivity wrote: > As with the rest of the memory API, the caller associates an eventfd > with an address, and the memory API takes care of registering or > unregistering when the address is made visible or invisible to the > guest. > > Signed-off-by: Avi Kivity [..snip..] > +static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a, > + MemoryRegionIoeventfd b) > +{ > + if (a.addr.start < b.addr.start) { > + return true; > + } else if (a.addr.start > b.addr.start) { > + return false; > + } else if (a.addr.size < b.addr.size) { > + return true; > + } else if (a.addr.size > b.addr.size) { > + return false; > + } else if (a.match_data < b.match_data) { > + return true; > + } else if (a.match_data > b.match_data) { > + return false; > + } else if (a.match_data) { > + if (a.data < b.data) { > + return true; > + } else if (a.data > b.data) { > + return false; > + } > + } > + if (a.fd < b.fd) { > + return true; > + } else if (a.fd > b.fd) { > + return false; > + } Braces.. > + return false; > +} > + [..snip..] -- mailto:av1474@comtv.ru