From: Sean Christopherson <seanjc@google.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Ackerley Tng <ackerleytng@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH v5 7/7] KVM: guest_memfd: Rework PREPARE config and hook into a more generic CONVERT
Date: Thu, 23 Jul 2026 13:33:42 -0700 [thread overview]
Message-ID: <amJ6pnTqGepoM9Bt@google.com> (raw)
In-Reply-To: <6c560199-1461-443a-b68e-e0297398c731@intel.com>
On Wed, Jul 22, 2026, Xiaoyao Li wrote:
> On 7/22/2026 12:24 AM, Sean Christopherson wrote:
> > I.e. have this at the end of this prep work:
> >
> > static bool kvm_gmem_is_private_mem(struct inode *inode, pgoff_t index)
> > {
> > return kvm_arch_has_private_mem(kvm) &&
> > !(GMEM_I(inode)->flags & GUEST_MEMFD_FLAG_INIT_SHARED);
> > }
>
> I'm wondering if we really need to check kvm_arch_has_private_mem() here. It
> looks checking GUEST_MEMFD_FLAG_INIT_SHARED is sufficient.
Ya, I came to the same conclusion and ended up dropping that line so that the
patch would be a guaranteed "No functional change intended".
prev parent reply other threads:[~2026-07-23 20:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 23:10 [PATCH v5 0/7] KVM: guest_memfd: reclaim()/convert() cleanups Sean Christopherson
2026-07-14 23:10 ` [PATCH v5 1/7] KVM: guest_memfd: Plumb the number of pages and max order into .invalidate() Sean Christopherson
2026-07-14 23:52 ` Ackerley Tng
2026-07-15 8:15 ` Fuad Tabba
2026-07-16 7:09 ` Xiaoyao Li
2026-07-21 16:42 ` Sean Christopherson
2026-07-14 23:10 ` [PATCH v5 2/7] KVM: guest_memfd: Rename invalidate() arch hook to reclaim() and isolate it Sean Christopherson
2026-07-14 23:53 ` Ackerley Tng
2026-07-15 8:19 ` Fuad Tabba
2026-07-16 10:04 ` Xiaoyao Li
2026-07-14 23:10 ` [PATCH v5 3/7] KVM: guest_memfd: Drop the redundant printk on arch gmem_prepare() failure Sean Christopherson
2026-07-15 8:21 ` Fuad Tabba
2026-07-16 10:05 ` Xiaoyao Li
2026-07-14 23:10 ` [PATCH v5 4/7] KVM: guest_memfd: Fold __kvm_gmem_prepare_folio() into its sole caller Sean Christopherson
2026-07-14 23:39 ` sashiko-bot
2026-07-14 23:55 ` Ackerley Tng
2026-07-21 16:39 ` Sean Christopherson
2026-07-22 1:30 ` Sean Christopherson
2026-07-14 23:10 ` [PATCH v5 5/7] KVM: guest_memfd: Explicitly pass number of pages to kvm_arch_gmem_prepare() Sean Christopherson
2026-07-14 23:10 ` [PATCH v5 6/7] KVM: x86: Combine .gmem_prepare()+.gmem_invalidate() into .gmem_convert() Sean Christopherson
2026-07-15 0:06 ` Ackerley Tng
2026-07-15 0:10 ` Sean Christopherson
2026-07-15 9:50 ` Fuad Tabba
2026-07-15 9:48 ` Fuad Tabba
2026-07-17 3:42 ` Ackerley Tng
2026-07-21 16:10 ` Sean Christopherson
2026-07-21 18:13 ` Ackerley Tng
2026-07-21 18:55 ` Sean Christopherson
2026-07-14 23:10 ` [PATCH v5 7/7] KVM: guest_memfd: Rework PREPARE config and hook into a more generic CONVERT Sean Christopherson
2026-07-15 0:09 ` Ackerley Tng
2026-07-15 9:53 ` Fuad Tabba
2026-07-16 9:35 ` Xiaoyao Li
2026-07-16 21:42 ` Ackerley Tng
2026-07-17 3:56 ` Xiaoyao Li
2026-07-21 16:24 ` Sean Christopherson
2026-07-22 3:25 ` Xiaoyao Li
2026-07-23 20:33 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amJ6pnTqGepoM9Bt@google.com \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=tabba@google.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox