Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Vipin Sharma <vipinsh@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev,
	kvm-riscv@lists.infradead.org,  pbonzini@redhat.com,
	borntraeger@linux.ibm.com, frankja@linux.ibm.com,
	 imbrenda@linux.ibm.com, anup@brainfault.org,
	atish.patra@linux.dev,  zhaotianrui@loongson.cn,
	maobibo@loongson.cn, chenhuacai@kernel.org,  maz@kernel.org,
	oliver.upton@linux.dev, ajones@ventanamicro.com
Subject: Re: [PATCH v4 6/9] KVM: selftests: Add various print flags to KVM selftest runner
Date: Wed, 29 Jul 2026 12:14:24 -0700	[thread overview]
Message-ID: <ampREGtEqKh8_-Ua@google.com> (raw)
In-Reply-To: <20260331194202.1722082-7-vipinsh@google.com>

On Tue, Mar 31, 2026, Vipin Sharma wrote:
> @@ -27,10 +34,14 @@ class TestRunner:
>          return test
>  
>      def _log_result(self, test_result):
> -        logger.info("*** stdout ***\n" + test_result.stdout)
> -        logger.info("*** stderr ***\n" + test_result.stderr)
> -        logger.log(test_result.status,
> -                   f"[{test_result.status.name}] {test_result.test_path}")
> +        print_level = self.print_stds.get(test_result.status, "full")
> +
> +        if (print_level == "full" or print_level == "stdout"):
> +            logger.info("*** stdout ***\n" + test_result.stdout)

IMO, when the print_level is exactly stdout or stderr, the runner shouldn't spit
out the "*** std{out,err} ***" line, as it's pure noise.  E.g.

        print("\033[2K", end="\r", flush=True)
        if (print_level == "full"):
            logger.info("*** stdout ***\n" + test_result.stdout)
            logger.info("*** stderr ***\n" + test_result.stderr)
        elif (print_level == "stdout"):
            logger.info(test_result.stdout)
        elif (print_level == "stderr"):
            logger.info(test_result.stderr)

> +        if (print_level == "full" or print_level == "stderr"):
> +            logger.info("*** stderr ***\n" + test_result.stderr)
> +        if (print_level != "off"):
> +            logger.log(test_result.status, f"[{test_result.status.name}] {test_result.test_path}")
>  
>      def start(self):
>          ret = 0
> -- 
> 2.53.0.1118.gaef5881109-goog
> 

  reply	other threads:[~2026-07-29 19:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 19:41 [PATCH v4 0/9] KVM: selftests: Create KVM selftests runner Vipin Sharma
2026-03-31 19:41 ` [PATCH v4 1/9] KVM: selftest: Create KVM selftest runner Vipin Sharma
2026-06-11  1:17   ` Ackerley Tng
2026-06-11 19:08     ` Sean Christopherson
2026-06-11 20:16       ` Ackerley Tng
2026-06-12  1:07         ` Sean Christopherson
2026-06-12 19:45           ` Ackerley Tng
2026-06-12 23:56             ` Sean Christopherson
2026-06-16 16:15               ` Ackerley Tng
2026-06-16 18:29                 ` Vipin Sharma
2026-06-16 21:43     ` Vipin Sharma
2026-06-16 23:04       ` Ackerley Tng
2026-03-31 19:41 ` [PATCH v4 2/9] KVM: selftests: Provide executables path option to the " Vipin Sharma
2026-03-31 19:41 ` [PATCH v4 3/9] KVM: selftests: Add timeout option in selftests runner Vipin Sharma
2026-07-29 19:39   ` Sean Christopherson
2026-03-31 19:41 ` [PATCH v4 4/9] KVM: selftests: Add option to save selftest runner output to a directory Vipin Sharma
2026-03-31 19:41 ` [PATCH v4 5/9] KVM: selftests: Run tests concurrently in KVM selftests runner Vipin Sharma
2026-03-31 19:41 ` [PATCH v4 6/9] KVM: selftests: Add various print flags to KVM selftest runner Vipin Sharma
2026-07-29 19:14   ` Sean Christopherson [this message]
2026-03-31 19:42 ` [PATCH v4 7/9] KVM: selftests: Print sticky KVM selftests runner status at bottom Vipin Sharma
2026-03-31 19:42 ` [PATCH v4 8/9] KVM: selftests: Add rule to generate default tests for KVM selftests runner Vipin Sharma
2026-07-29 19:07   ` Sean Christopherson
2026-03-31 19:42 ` [PATCH v4 9/9] KVM: selftests: Provide README.rst " Vipin Sharma
2026-07-29 19:09   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ampREGtEqKh8_-Ua@google.com \
    --to=seanjc@google.com \
    --cc=ajones@ventanamicro.com \
    --cc=anup@brainfault.org \
    --cc=atish.patra@linux.dev \
    --cc=borntraeger@linux.ibm.com \
    --cc=chenhuacai@kernel.org \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=maobibo@loongson.cn \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=vipinsh@google.com \
    --cc=zhaotianrui@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox