From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00C9D1A3A80 for ; Tue, 11 Aug 2026 21:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786484497; cv=none; b=JCn4ZvkzzH4GLm/ipWN62j3mZEKuxtRK2F8p3ORqEQ883QdEltTABtEk39QeQB4qYQN8kbDLyIBKwRMaIPlgKVEu0iQsGr8Xc87KCHv/XImCSZPsr3xSqfTKPsAnfuJDWsgsUIU6yRMd+qg4/bDbHtWSre+bPpkb5MpUnHzXCqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786484497; c=relaxed/simple; bh=FvL1OIHi5wTi2D/EqC1IPZskKU1S4aFodr7CB5Lb86E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ux76Yjaafnm7D5IUmWzmHZT93JWNL4a7+itf7FTVzf8sPQM5XWHP5pNK2LqR2DmMjHyk/mT0YnxcSk6WGOfYbWYRGeOk9X2VjixAMRLqm+opReRT7Uo14vFy6ILH9n7Faat6F8ctVpoWmh2zKl4aeXHsBuPm7IwEvrPfqXwUINg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AvIwBnWp; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AvIwBnWp" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-84e3007a2b7so334788b3a.0 for ; Tue, 11 Aug 2026 14:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786484495; x=1787089295; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wkXfErZCu5pJKU3h2uo9xlPOj99O2IlT6yAUBX8IRnQ=; b=AvIwBnWpVHQXlETPQzZh/ditSlTb/iItTVKY8jwe69cWVRtG6HPJhTWjB9KXYD4FrP JgO4bEP1YRU2GPEFHC8FBxdcjGFH7W0c1BZhFnn4yPUMITNMVBJ2InqkSn4CYtQ/ldDC t88zaeAsmLClYkdk5jQriZF4GR5ykK2s8bTWPmywgx8wh+bheVy6wV0xwEDs2KKi6bWf 4otO/tHM5agIu5fVApcSISo01q+FwnXVaQX5B/JBTes834ZlfHbCwVzPioZQk7dznm2p 6+DYtFJdha+Vb4Pu8f/aTS8lkvW+RDYsyMoh4kHGqe5Mp4DSCdLxm73By2v/ZOHZ+z2F Lq6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786484495; x=1787089295; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wkXfErZCu5pJKU3h2uo9xlPOj99O2IlT6yAUBX8IRnQ=; b=iJwYQpGcSWKTMi5zn5XH6yARaH5aWQfQghsa9mUtqDxIu0vEluHeb+MHY7RLY1rEOG 4x0pkzAFSldV3rFqNkqOUDI50mir3Ph/fu9EJz86ZeG+hybW27J3AbX0RBZpliR6Es2U OQy2oMP+GLodSF/sQVL+ifsK1Tt+KW8F5KaoSXR7t2j3797sYe9JISyX4HCmkU2kX+94 uk8Kqe1/iahlRbiaFBnxia2Wcfui5hHYim3h0fha/akwYSrhcqH9rP13CYvYSJXEEzL1 81Cf3nqEht1Uxn95JeWKavCVV9YyD5uGHOI2fz4ecGZcgmq7IOV9kVjnun2w8NiBAy/K xOfQ== X-Forwarded-Encrypted: i=1; AHgh+RpHB4I8Kc6pTfFxte6uBJZcGE5/D7um/L4Z6BooGiCNzFmJerSndAMpJewkICqg83pGWn4=@vger.kernel.org X-Gm-Message-State: AOJu0YyvofPVmo/oHHKxkB9ay6sXUcrSje2659vL/PIJ4e4v8pYy9Siu 14KyfyV7e2SWJ0rXdBFkSGnVL7me66Ez1R4eqLg4c5+cqRhzoFeLPt5sEWkmdacEMg== X-Gm-Gg: AR+sD13fRijihqdiAiiLk7zKRJSU37HupbmGDQ1NXBJO8SRIG/RU53U8yVc1Fg8lGyj QewpSgUOwDU0xO0VB/EtzN36mz0ns9PPfJZgA3lBGLGKanroCg2gR5M8RpZrXjC24+C2nfj0Zpt 4hkOUHUM2fL5qY2bpS/M6NCAH751hOwRR5tQGUKFDXaTNRYljU2UYP/WnmEUy/v4phwuJZYeao4 t/rAJSWjXy3bv35tTO6tyAgUQzFB1BuVfP2tZbFm4615knP4RZIBUWjvQYY6/kz8kMPyJWqNv+U o12mrTC7RrW6hk6Zs3JG50l6w92Ggnc3dyKw/QfwLve7+j0hg1PGxcu7CBYOTFUFKeZc+OB2aQj Sltfxx5NX+ikxUo2X4f5QeoYheFWOWCV2yfqLjx2VBFc+x6FhXqKm5tj418KnjjlYwY+DJRb+Yg IZb7nHt3sJtUbYxBicDBFvi5OpiKaSScLdVwidzkqNRo/4Onkq+1y6MIGObezp4J/ddCGckjLLM F+cwRu2lcZ3DtueisPpLh4CdOiR6g== X-Received: by 2002:a05:6a00:3a26:b0:845:36a0:9eb2 with SMTP id d2e1a72fcca58-84fb5560093mr241098b3a.34.1786484494638; Tue, 11 Aug 2026 14:41:34 -0700 (PDT) Received: from google.com (132.200.185.35.bc.googleusercontent.com. [35.185.200.132]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84fb1f2598dsm255623b3a.47.2026.08.11.14.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 14:41:33 -0700 (PDT) Date: Tue, 11 Aug 2026 21:41:30 +0000 From: David Matlack To: Sean Christopherson Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Josh Hilke , kvm@vger.kernel.org Subject: Re: [kvm-x86:selftests2] [KVM] a262fc49e0: kselftests.kvm.make.fail Message-ID: References: <202608071656.86e9fd06-lkp@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 2026-08-07 10:21 PM, David Matlack wrote: > On 2026-08-07 11:35 AM, Sean Christopherson wrote: > > On Fri, Aug 07, 2026, kernel test robot wrote: > > > > > > > > > Hello, > > > > > > kernel test robot noticed "kselftests.kvm.make.fail" on: > > > > > > commit: a262fc49e0aafdeeb1b4fd8cb0d79a0fde447757 ("KVM: selftests: Build and link selftests/vfio/lib into KVM selftests") > > > https://github.com/kvm-x86/linux selftests2 > > > > > > [test failed on linux-next/master 78bc8af4affb9a732504eb22eeac7d1e50883853] > > > > > > in testcase: kselftests > > > version: kselftests-x86_64-848acc8ffe1b-1_20260804 > > > with following parameters: > > > > > > group: kvm > > > > > > > > > config: x86_64-rhel-9.4-kselftests > > > compiler: gcc-14 > > > test machine: 224 threads 2 sockets Intel(R) Xeon(R) Platinum 8480CTDX (Sapphire Rapids) with 256G memory > > > > > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-lkp/202608071656.86e9fd06-lkp@intel.com > > > > > > > > > /usr/src/perf_selftests-x86_64-rhel-9.4-kselftests-a262fc49e0aafdeeb1b4fd8cb0d79a0fde447757/tools/testing/selftests/vfio/lib/drivers/ioat/ioat.c:12:10: fatal error: hw.h: No such file or directory > > > 12 | #include "hw.h" > > > | ^~~~~~ > > > compilation terminated. > > > make[1]: *** [../vfio/lib/libvfio.mk:32: > > > /usr/src/perf_selftests-x86_64-rhel-9.4-kselftests-a262fc49e0aafdeeb1b4fd8cb0d79a0fde447757/tools/testing/selftests/kvm/libvfio/drivers/ioat/ioat.o] > > > Error 1 make[1]: *** Waiting for unfinished jobs.... > > > /usr/src/perf_selftests-x86_64-rhel-9.4-kselftests-a262fc49e0aafdeeb1b4fd8cb0d79a0fde447757/tools/testing/selftests/vfio/lib/drivers/dsa/dsa.c:14:10: > > > fatal error: registers.h: No such file or directory > > > 14 | #include "registers.h" > > > | ^~~~~~~~~~~~~ > > > compilation terminated. > > > make[1]: *** [../vfio/lib/libvfio.mk:32: > > > /usr/src/perf_selftests-x86_64-rhel-9.4-kselftests-a262fc49e0aafdeeb1b4fd8cb0d79a0fde447757/tools/testing/selftests/kvm/libvfio/drivers/dsa/dsa.o] > > > Error 1 make[1]: Leaving directory > > > '/usr/src/perf_selftests-x86_64-rhel-9.4-kselftests-a262fc49e0aafdeeb1b4fd8cb0d79a0fde447757/tools/testing/selftests/kvm' > > > make: *** [Makefile:218: all] Error 2 > > > > Any chance the file is literally just not there? Makefile.kvm's -I$( > to: > > > > -I/usr/src/perf_selftests-x86_64-rhel-9.4-kselftests-a262fc49e0aafdeeb1b4fd8cb0d79a0fde447757/tools/testing/selftests/vfio/lib/drivers/dsa > > > > which matches the directory of the input file: > > > > -c/usr/src/perf_selftests-x86_64-rhel-9.4-kselftests-a262fc49e0aafdeeb1b4fd8cb0d79a0fde447757/tools/testing/selftests/vfio/lib/drivers/dsa/dsa.c > > > > so AFAICT the makefile is working as intended? > > I think this is a problem in how the kernel test robot builds selftests. > > hw.h and registers.h are symlinks to headers in the kernel source tree. > The selftests build works fine for me when I check out the entire kernel > tree at commit a262fc49e0aafdeeb1b4fd8cb0d79a0fde447757 and build the > KVM selftests. > > But if I delete one of the symlink destinations, I see the same error. > > $ ls -l tools/testing/selftests/vfio/lib/drivers/dsa/registers.h > [...] tools/testing/selftests/vfio/lib/drivers/dsa/registers.h -> ../../../../../../../drivers/dma/idxd/registers.h > > $ rm drivers/dma/idxd/registers.h > > $ make -C tools/testing/selftests/kvm -s > /usr/local/google/home/dmatlack/kernel/trees/kvm/tools/testing/selftests/vfio/lib/drivers/dsa/dsa.c:14:10: fatal error: registers.h: No such file or directory > 14 | #include "registers.h" > | ^~~~~~~~~~~~~ > compilation terminated. > make: *** [../vfio/lib/libvfio.mk:32: /usr/local/google/home/dmatlack/kernel/trees/kvm/tools/testing/selftests/kvm/libvfio/drivers/dsa/dsa.o] Error 1 > > Maybe the kernel test robot doesn't download the entire kernel tree when > building selftests? Yeah this seems to be the cause of the build failure. The lkp project only grabs a subset of the kernel directories when packaging up the kernel to build selftests, so it will not have access to the symlink targets used by VFIO selftests: https://github.com/intel/lkp-tests/blob/bbbc29c495d9617f28dbc8b799cf0dac9a1ca54e/lib/tests/pkgbuild.sh#L484 I'll get the ball rolling on fixing this in lkp.