Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Tony Lindgren <tony.lindgren@linux.intel.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Peter Fang <peter.fang@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Kiryl Shutsemau <kas@kernel.org>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev,
	kvm@vger.kernel.org, Binbin Wu <binbin.wu@linux.intel.com>
Subject: Re: [PATCH v3 4/4] virt: tdx-guest: Allocate Quote buffer dynamically
Date: Thu, 3 Sep 2026 09:33:17 +0300	[thread overview]
Message-ID: <apkUrXh4FJJua4mN@tlindgre-MOBL1> (raw)
In-Reply-To: <bf51e3d3-cf28-4155-9915-683bf6c848a4@intel.com>

On Thu, Sep 03, 2026 at 02:21:35PM +0800, Xiaoyao Li wrote:
> On 7/29/2026 8:29 PM, Peter Fang wrote:
> > A new TDX module ABI reports the TD Quote size limit in a metadata
> > field. This size used to be fixed at 128 KB.
> > 
> > The guest driver's Quote buffer is shared with the host VMM. The current
> > fixed size may be too small for Quotes using schemes such as
> > post-quantum cryptography (PQC), where larger certificate chains can
> > increase the Quote size significantly.
> > 
> > Allocate the Quote buffer based on the reported limit. This avoids
> > wasting memory on platforms that do not require larger Quotes. Older
> > platforms fall back to the default 128 KB buffer.
> 
> I think we need to justify why using the value reported by TDX module
> (i.e., QUOTE_MAX_SIZE) is safe.
> 
> From "Intel TDX Module Extension for Quoting" spec,
> 
>   QUOTE_MAX_SIZE that specifies the maximum size of the buffer that must be
>   allocated to contain the Intel TDX Quote received from Intel TDX Module.
> 
> So, TDX module only guarantees that QUOTE_MAX_SIZE is big enough to hold
> the quote that is generated by the TDX module. But for the current tdx
> guest driver, it doesn't know how host will generate the quote. Host can
> generate the SGX-based quote and we need to justify the QUOTE_MAX_SIZE will
> be enough for such case.

And can we assume the TDX module provided size does not change after init
with a TDX module update?

  reply	other threads:[~2026-09-03  6:33 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 12:29 [PATCH v3 0/4] tdx-guest: Make Quote buffer size dynamic Peter Fang
2026-07-29 12:29 ` [PATCH v3 1/4] x86/tdx: Add helper to query maximum TD Quote size Peter Fang
2026-09-03  6:04   ` Tony Lindgren
2026-07-29 12:29 ` [PATCH v3 2/4] virt: tdx-guest: Calculate the Quote buffer size safely Peter Fang
2026-07-29 18:29   ` Kuppuswamy Sathyanarayanan
2026-09-03  5:33   ` Xiaoyao Li
2026-09-03  6:05   ` Tony Lindgren
2026-09-03  9:18   ` Binbin Wu
2026-07-29 12:29 ` [PATCH v3 3/4] virt: tdx-guest: Use a variable to store the Quote buffer size Peter Fang
2026-07-29 12:58   ` sashiko-bot
2026-09-03  5:25     ` Peter Fang
2026-07-29 18:47   ` Kuppuswamy Sathyanarayanan
2026-09-02 23:15     ` Peter Fang
2026-09-03  5:59       ` Xiaoyao Li
2026-09-03  6:31   ` Tony Lindgren
2026-09-03  9:17   ` Binbin Wu
2026-07-29 12:29 ` [PATCH v3 4/4] virt: tdx-guest: Allocate Quote buffer dynamically Peter Fang
2026-07-29 12:55   ` sashiko-bot
2026-09-03  7:04     ` Peter Fang
2026-09-03  6:21   ` Xiaoyao Li
2026-09-03  6:33     ` Tony Lindgren [this message]
2026-07-29 21:21 ` [PATCH v3 0/4] tdx-guest: Make Quote buffer size dynamic Edgecombe, Rick P
2026-08-11 22:40   ` Edgecombe, Rick P
2026-08-12 14:08     ` Sean Christopherson
2026-08-12 16:02       ` Edgecombe, Rick P
2026-08-12 16:43         ` Sean Christopherson
2026-08-12 17:22           ` Edgecombe, Rick P
2026-08-12 22:37             ` Peter Fang
2026-08-12 22:47               ` Edgecombe, Rick P
2026-08-12 23:10                 ` Sean Christopherson
2026-08-12 23:30                   ` Edgecombe, Rick P
2026-08-13 19:32                     ` Artem Bityutskiy
2026-08-13 20:14                       ` Edgecombe, Rick P
2026-08-14  5:45                         ` Artem Bityutskiy
2026-08-14  7:37                           ` Peter Fang
2026-08-14 15:55                           ` Edgecombe, Rick P
2026-08-15 11:39                             ` Artem Bityutskiy
2026-08-17 17:26                               ` Edgecombe, Rick P
2026-08-18 11:09                                 ` Artem Bityutskiy
2026-08-18 20:37                       ` Sean Christopherson
2026-08-18 23:46                         ` Edgecombe, Rick P
2026-08-19 14:57                         ` Artem Bityutskiy
2026-08-12 23:27                 ` Peter Fang
2026-08-12 21:02         ` Peter Fang
2026-08-27 22:22   ` Peter Fang
2026-08-27 22:41     ` Edgecombe, Rick P

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apkUrXh4FJJua4mN@tlindgre-MOBL1 \
    --to=tony.lindgren@linux.intel.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kas@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peter.fang@intel.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox