Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: David Matlack <dmatlack@google.com>
To: Alex Williamson <alex.williamson@nvidia.com>
Cc: Alex Williamson <alex@shazbot.org>, kvm <kvm@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
	Yi Liu <yi.l.liu@intel.com>
Subject: Re: [PATCH 3/4] selftests/vfio: Extend mix_and_match timeout to 90s
Date: Wed, 9 Sep 2026 21:42:18 +0000	[thread overview]
Message-ID: <aqHSuljynlgmVxmN@google.com> (raw)
In-Reply-To: <20260901215358.2421359-4-alex.williamson@nvidia.com>

On 2026-09-01 03:53 PM, Alex Williamson wrote:
> Systems with firmware first error handling can see heavy SMM load
> as a result of the mix_and_match induced IOMMU errors.  For devices
> like igb that get wedged on these errors, the resulting FLR is delayed
> waiting for the transaction pending register to clear, which never
> occurs.  However, due to the background SMM, the backoff delays in
> PCI code wildly exceed their timeouts.  As a result, the whole test
> can report failure.
> 
> Extend the mix_and_match timeout to a value shown to complete reliably
> on such systems, with ~2x margin.
> 
> Assisted-by: Qwen3.8-27B
> Signed-off-by: Alex Williamson <alex.williamson@nvidia.com>

With the caveat that shortlog should be "vfio: selftests: ...",

Reviewed-by: David Matlack <dmatlack@google.com>

> ---
>  tools/testing/selftests/vfio/vfio_pci_driver_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vfio/vfio_pci_driver_test.c b/tools/testing/selftests/vfio/vfio_pci_driver_test.c
> index 761bf117d624..1d532f944cee 100644
> --- a/tools/testing/selftests/vfio/vfio_pci_driver_test.c
> +++ b/tools/testing/selftests/vfio/vfio_pci_driver_test.c
> @@ -190,7 +190,7 @@ TEST_F(vfio_pci_driver_test, send_msi)
>  	ASSERT_EQ(1, value);
>  }
>  
> -TEST_F(vfio_pci_driver_test, mix_and_match)
> +TEST_F_TIMEOUT(vfio_pci_driver_test, mix_and_match, 90)
>  {
>  	u64 value;
>  	int i;
> -- 
> 2.53.0
> 

  reply	other threads:[~2026-09-09 21:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 21:53 [PATCH 0/4] vfio: Fix cdev second-open and harden selftests Alex Williamson
2026-09-01 21:53 ` [PATCH 1/4] vfio: Reject a second cdev open before mutating shared device state Alex Williamson
2026-09-09 22:27   ` David Matlack
2026-09-10 13:51   ` Jason Gunthorpe
2026-09-01 21:53 ` [PATCH 2/4] selftests/vfio: Wait out transient -EBUSY on open/bind Alex Williamson
2026-09-09 21:40   ` David Matlack
2026-09-10 22:50     ` Alex Williamson
2026-09-01 21:53 ` [PATCH 3/4] selftests/vfio: Extend mix_and_match timeout to 90s Alex Williamson
2026-09-09 21:42   ` David Matlack [this message]
2026-09-01 21:53 ` [PATCH 4/4] selftests/vfio: Extend timeout for runner executions Alex Williamson
2026-09-09 21:51   ` David Matlack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqHSuljynlgmVxmN@google.com \
    --to=dmatlack@google.com \
    --cc=alex.williamson@nvidia.com \
    --cc=alex@shazbot.org \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox