From: Kiryl Shutsemau <kirill@shutemov.name>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: dave.hansen@linux.intel.com, rick.p.edgecombe@intel.com,
xiaoyao.li@intel.com, linux-coco@lists.linux.dev,
kvm@vger.kernel.org, x86@kernel.org,
"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH v2] x86/tdx: Harden exports
Date: Fri, 25 Sep 2026 12:19:39 +0100 [thread overview]
Message-ID: <arZYKKo7fHFzosNY@thinkstation> (raw)
In-Reply-To: <20260917110714.1587301-1-nik.borisov@suse.com>
On Thu, Sep 17, 2026 at 02:07:14PM +0300, Nikolay Borisov wrote:
> tdx_* function aren't supposed to be used by the kernel at large, rather
> they are mostly used by KVM and a very small number of them are exposed
> via the tdx-guest/tdx-host drivers. Reflect this fact in their
> EXPORT_SYMBOL* declarations.
Subject could be better. Something like "x86/tdx: Restrict attestation
exports to the tdx-guest driver"?
The changelog still talks about KVM and tdx-host. Rewrite it.
> Reported-by: Michal Koutný <mkoutny@suse.com>
Maybe Suggested-by rather than Reported-by? There is no bug here.
> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
With that fixed you can use my:
Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
--
Kiryl Shutsemau / Kirill A. Shutemov
prev parent reply other threads:[~2026-09-25 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 11:07 [PATCH v2] x86/tdx: Harden exports Nikolay Borisov
2026-09-18 9:36 ` Peter Fang
2026-09-18 10:03 ` Nikolay Borisov
2026-09-18 20:25 ` Peter Fang
2026-09-25 7:42 ` Nikolay Borisov
2026-09-25 11:19 ` Kiryl Shutsemau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arZYKKo7fHFzosNY@thinkstation \
--to=kirill@shutemov.name \
--cc=dave.hansen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=mkoutny@suse.com \
--cc=nik.borisov@suse.com \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox