From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D65149AA43 for ; Mon, 28 Sep 2026 10:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790591485; cv=none; b=IRaqBEFeRbhQUivtZLz5mYaCg/e+SLMg3QlpX7E+gSeQ9Msi6t0+HuaQ63TDV2JjsmaAgY/pSR5dt3itfWiumN1uywP98uuvXMFDyKehmHe9ui0CBM2fyp7OV/jex8OboJQWZZBRhfmTqLGoVdfK/iGYPBLL7LtDuDrqEL0a0S4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790591485; c=relaxed/simple; bh=ZcL7dYl+t7tDUahafwYFHtczoNBxBHDjjQvSaDt7MN4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V4J3hH0NEQuUpolQJLpw+P5clX0737Lk5YtYlGlxVzvRWMCJ2YWDmCHE8lxwIQW69PuOaU3hO5J0XMHicdSp4ENWrXN1JKbhEduX1cq5VwemK20UnEIBVdmFsknfOB4F51FitMOL/ke6Z5C68mSOAh+NZJFcqTbwhrZXGgXoNWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bQZWVKzd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LLfHoAqM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bQZWVKzd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LLfHoAqM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790591481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ncJygWXyDwSDtfOrrDTJhD8n3lBQBywOBBfJbF/rpYs=; b=bQZWVKzdJalQOmfxPiYO9LLC2bpVvWX8TGz5uNBPJXw7/6UP2slhlCNonQu+Kw81/D8m9r YDVEn/ss3ZkDWNYXOco/9DqOnQeFRsxa3vYfr8Qh3LHAS9Owp6ntis2W4n2VdG0yhhRw/U cmc3Rr+mzPpXVZRwhPwgTkZ8ONXYXh0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-yfIwvOmZPNCNI7D0AqVdWw-1; Mon, 28 Sep 2026 06:31:20 -0400 X-MC-Unique: yfIwvOmZPNCNI7D0AqVdWw-1 X-Mimecast-MFC-AGG-ID: yfIwvOmZPNCNI7D0AqVdWw_1790591479 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49e6ba4abdfso31312255e9.1 for ; Mon, 28 Sep 2026 03:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1790591479; x=1791196279; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ncJygWXyDwSDtfOrrDTJhD8n3lBQBywOBBfJbF/rpYs=; b=LLfHoAqMX1aMROUtL7jkYlwegXn6NLXlwBpFOXDCTW7ZREhmIOhxtopDrJNxvH1jMr 57hgESpRVS2aMMkqYtnXfI9aItZn4+WXxI8Z2G4BS0dz48bidd56trrg41UfYQnE9Tci IJIoHS3oxPSiTcfdTsg14HRyhT26x1Tux9t+fiIJMH1x+Vw8AmlVtDwm37MDstfAQx5o 3nz0lmJScXPLi7g0HI9AcX4hcWuzHVxVNGNg2tu1msfp4Z6owAa2sX767r8O81TQQJ5B aN++X9pVsZxNBVNCZjwoRVdu9d8wSZXhHTd/YXQTIvlX3d6o2qIehIHlxSFFQ+EsjrnP tghg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790591479; x=1791196279; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ncJygWXyDwSDtfOrrDTJhD8n3lBQBywOBBfJbF/rpYs=; b=HU1+z4SpaehFn+UbnLPrH16n87DmIvlSi1H676rIDKKywa51Uxdzk5wK1++Oe1vTrW Wqoc/W1DvSks+WvIBFv74Qm8tkb656CcTSeAP+j2UcwL+BdePj2x5qmNWpx/rBaXb3pl EQG+N1wDPrv/++QeMEgFkVGTQm1xCPw89QUarBDLz0AjuA0GkWRap/dBPp7B1j5mNBPN G7CnZ8YDvyVfla8lbcgqrDT4mbiHwhNREk1RPmcudBT3NeedNA2PAUam7Padp2AkT9ly aGalqWjl3kFD91yUbcifWIZ9mnyAVrmbqNXIW4LdZiw7lC6bR4mfCKuzcjY47mPx1v50 71jA== X-Forwarded-Encrypted: i=1; AKwUvBx/8vppO3Jrj1Nun9+UAtTQP96yKCFqqzaWRHfzJ24wiSPKdJgr/D+m/wMApibdpM8f9Co=@vger.kernel.org X-Gm-Message-State: AFuF++kP7N3/dPA65sItyHVRi+CM/9ytsfDpALy79vBaMeNHw6ZS7XKW o2qws1T5wnoCuuQzEHnbLSdS5f1RLihsPdXVVsTKANeIUQg0Xhr6VNblRH+iD9UrBCtHjU29mPX /BILNoXWV99H6U+OjMS6eN53TaMG59v8b41QnfwGAoqpR4e6vPDPWMg== X-Gm-Gg: AYBFou0mSxNzkm1x4eKj1526nAFxHIKIJkpZip3CZO/nKhABjtmfbNy0bi+Biq/Hp9G Jb9Qnak/xl3ou7uqJF2/lZYeO8gJD7xWWN4QWTudRwas4AR1FgKeUtU2KFk/tsJ6arNheSlOawJ MSehagOEFm23wiqjsNTmd4tZc3cT1rVmHgbLMy8pPX13K7tNnRP64VI1D+Z/TeeFwcB1xH9spv2 r6WlupRVZq3OJSa6uBkqZrpRHB0LplVEpZxaRrAcSCAPGjdGSePPXroGeDiSnRhRgvcpG5h5Edu T1DPMnMeVEEMSDtxbYfD6/L3jKKbcXlwZTjyM4rFuX4I1PrAqfOH+6yUA7ZmvAYpV+sgvCu2y1X qCAJi X-Received: by 2002:a05:600c:a10d:b0:49f:e8bf:8f9b with SMTP id 5b1f17b1804b1-49fe8bf91bbmr166404275e9.4.1790591479279; Mon, 28 Sep 2026 03:31:19 -0700 (PDT) X-Received: by 2002:a05:600c:a10d:b0:49f:e8bf:8f9b with SMTP id 5b1f17b1804b1-49fe8bf91bbmr166403775e9.4.1790591478661; Mon, 28 Sep 2026 03:31:18 -0700 (PDT) Received: from sgarzare-redhat ([193.207.134.73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4887a64ed6esm29113119f8f.29.2026.09.28.03.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 03:31:18 -0700 (PDT) Date: Mon, 28 Sep 2026 12:31:05 +0200 From: Stefano Garzarella To: Michal Luczaj Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Eugenio =?utf-8?B?UMOpcmV6?= , "David S. Miller" , Xuan Zhuo , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Asias He , kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2 3/5] vsock: Enforce no-transport invariant for TCP_LISTEN sockets Message-ID: References: <20260915-vsock-connect-reset-closing-v2-0-a1d9abb472f7@rbox.co> <20260915-vsock-connect-reset-closing-v2-3-a1d9abb472f7@rbox.co> <0bc40e5c-8790-4a36-84bc-80e0bfe6b504@rbox.co> <6c1516ca-4699-4d9b-af6e-c7762759d495@rbox.co> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c1516ca-4699-4d9b-af6e-c7762759d495@rbox.co> On Thu, Sep 24, 2026 at 11:26:47PM +0200, Michal Luczaj wrote: > On 9/24/26 12:17, Stefano Garzarella wrote: > > On Tue, Sep 22, 2026 at 03:18:13PM +0200, Michal Luczaj wrote: > >> ... > >> I've addressed all your other comments for v2 and went through Ashiko's > >> reports (side effects of lockless peer_shutdown write, imperfect > >> no-transport TCP_LISTENER enforcement). I've decided to try the > >> eager-unassign approach. I think/hope this way we sidestep the lockless > >> writes and enforce the invariant without breaking the API, while fixing the > >> bugs. > >> > >> This should probably be RFC, but I'm posting as v3[1] so netdev's LLM can > >> have a go (too). Hope I'm not breaking any workflow. Let me know what you > >> think. > > > > I think you can add RFC also on a v3 patch, just to make it clear you > > are not sure it's ready to be merged. > > > > That said, thanks for that :-) I'll take a look today or next week > > because I'm off tomorrow. > > > > I'm just worried it's becoming too big for net. Anyway, I'll comment > > there. > > Yeah, I get it. Would you rather have a single net.git patch[1] for the > original report + keep all the rest for net-next, or do the whole series as > is, but slowly at net-next? I'd go with the first option. Let's try to get the fix into net first, and then move the rest to net-next at a reasonable pace. WDYT? > > [1]: Basically > https://lore.kernel.org/netdev/20260915-vsock-connect-reset-closing-v2-4-a1d9abb472f7@rbox.co/ > + your comments addressed + addressing one of Sashiko's comments, and > ignoring the transport-reset-surprise one > Yeah, that! Thanks, Stefano