From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F0084B0E3B for ; Mon, 28 Sep 2026 11:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790596073; cv=none; b=R9p2NE5+gZdr11WZJuJpj+iBZFfeOLW2fgb6aSO1PuiAG2YUtvIs0SzH5aAkQPtvxIyATiiCyvhrU+5Unp11Uglv4gxI3DMZWEewfsQyYsoU02jdg5chiB9ktwEkcUNrfioePiuVBSkjL2Z8o20iJZmd1isxk7ol35vszmtpjMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790596073; c=relaxed/simple; bh=LIT5hc4I/KCwzgMO1/jfNE4vgXCaBu5jqCHZaIl9H04=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RVA1SMQr+sMXCFL1jUIoeOvtgKyhcsnjlArLwtBdygJcCP8Lv6H1emkr06TpWKiPsq/Au8Ko7G97VVOFPrwq53pCdgkZIduqiPrmcU3spGQbf+ZFvWTMqC1eC/Ql7kDavwAREIrJrETSC3WmQder+d4iE2nNMPi0ogQPSBBFczs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=At0wjbfq; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="At0wjbfq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790596070; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=NjotLUCJ/k2E4ZritQW+gd2g5P+2FmAFsu90Sg7rJRE=; b=At0wjbfqfKXh2+JPdIOry1rKAs3HXXigPqNFeCrfCy+XgZa96douWxdQ0ThEE7ivVJwNP0 gA0CBVgAxB6bIc9FQV7d6RUMHMWBC2A7YHud5OWdEDMYBSrG28ohg/ocxvGUYuJMzVJ4HQ 71qxlPTUEGn48pVPmSA00tlBORSxrg0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-MhEhCx3IN_y2-ehBGw9HJA-1; Mon, 28 Sep 2026 07:47:47 -0400 X-MC-Unique: MhEhCx3IN_y2-ehBGw9HJA-1 X-Mimecast-MFC-AGG-ID: MhEhCx3IN_y2-ehBGw9HJA_1790596065 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EB78D195395B; Mon, 28 Sep 2026 11:47:44 +0000 (UTC) Received: from redhat.com (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 705B61800345; Mon, 28 Sep 2026 11:47:41 +0000 (UTC) Date: Mon, 28 Sep 2026 12:47:38 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: Yonggang Luo , qemu-devel@nongnu.org, Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "Edgar E. Iglesias" , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , Alistair Francis , Peter Maydell , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-arm@nongnu.org, kvm@vger.kernel.org Subject: Re: [PATCH v4 40/55] meson: link shared objects into qemu-system Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20260926070057.1234-1-luoyonggang@gmail.com> <20260926070057.1234-41-luoyonggang@gmail.com> <8733uthabd.fsf@pond.sub.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8733uthabd.fsf@pond.sub.org> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On Mon, Sep 28, 2026 at 01:41:58PM +0200, Markus Armbruster wrote: > Yonggang Luo writes: > > > Extract common_ss, system_ss, and family-common objects into one > > qemu-system binary. Only arm, aarch64, microblaze-softmmu are > > listed; a new target must have arch_srcs equal to target_info_def > > only (target-info-def.c). Config headers stay in arch_genh. > > > > - Union non-TARGET_* keys with y taking precedence > > - Reject leftover arch_srcs on participating targets > > - Reject TARGET_* conditions on common_ss and system_ss > > - Link SDL, install the binary, and apply Darwin entitlements > > > > Adding a target that still has per-target sources fails meson, for > > example: > > > > combined qemu-system leftover for : > > expected: > > target-info-def.c > > arch_srcs: > > target/microblaze/mmu.c > > target/microblaze/machine.c > > target-info-def.c > > > > Signed-off-by: Yonggang Luo > > Watch query-target lie: > > $ qemu-system -S -nodefaults -display none -qmp stdio > {"QMP": {"version": {"qemu": {"micro": 50, "minor": 1, "major": 11}, "package": "v11.1.0-1902-g88f617913a"}, "capabilities": ["oob"]}} > qemu-system: warning: nic xlnx.xps-ethernetlite.0 has no peer > {"execute": "qmp_capabilities", "arguments": {"enable": ["oob"]}} > {"return": {}} > {'execute': 'query-target'} > --> {"return": {"arch": "aarch64"}} > > Perhaps you can fix this by reordering patches. If you can't, > deficiencies like this one need a prominent mention in the commit > message. What do you think the behaviour of 'query-target' ought to be in this scenario ? The 'none' machine has no associated target. Should we add a 'none' or 'unspecified' target to SysEmuTarget, or should we just declare that "query-target" will report an error if no target is activate. I'd probably lean towards the latter. Latter in this series is a new 'query-targets' command that can enumerate all available targets in 'qemu-system', so 'query-target' merely tells us which is active (if any). Perhaps 'query-targets' should in fact tell us that straightaway, such that we can declare 'query-target' to be obsolete (and even deprecate it) With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|