From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4AD4BD787 for ; Mon, 28 Sep 2026 12:08:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790597337; cv=none; b=eKB03vkMK6vgEuKcGdKz6SrHHuzGi5eJTbvwOzwc7MzTHYz30Gj5c5N6jpjzbtylH6JMSk72mxjkSjC1jfyCcSl049Pui9MIEhPND8r0MavXiq+cxLmcQ6ThkXgmdlSuPTYmdAq5+O+OWxktBVNj3VBvBv19PtjxyepqL2eIdng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790597337; c=relaxed/simple; bh=jv3DbVdJUuWO51NTHItA52aaFLLI0BnGtv7aNcMnjE8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ShjgeCAYeUma39pw1+gIe/VkJf2yCvuL2iIwfeZsWPBzSYZJSrXiIzG/CWpYyXvQCXwxr6w2QkUScF0DTteewsLAxYKiiFXCm4+Z24UWbqfcBQIRxdU4vXqo67RqmCrNltW0L33PhfI3hGCzVpZJcrjYICP9Ge0suxG8FzmzdtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Dti3Abde; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Dti3Abde" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790597334; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N44NDMt7gH7wG13kKZD9HCNCFqKm7fCYbpbuur6UAAU=; b=Dti3AbdeRGsWLrWCTP/sOZ7DderBxXMlZ0AM9nICw5Q/5OnWLVBFxKaKn7EZd3oYKZpMJK +9ozR5F2uwSorfOJhRjekuUQeQE10AyxZuSMR+zubZA+5lO/B4rs+Rpt0e+355I04FRd8k 6azmlFf5pOgx/5ZcAgkhYx0nDiNbLBk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-j6ntZwIoPMKF3X_682JZ8w-1; Mon, 28 Sep 2026 08:08:50 -0400 X-MC-Unique: j6ntZwIoPMKF3X_682JZ8w-1 X-Mimecast-MFC-AGG-ID: j6ntZwIoPMKF3X_682JZ8w_1790597329 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CFDF318009D6; Mon, 28 Sep 2026 12:08:48 +0000 (UTC) Received: from redhat.com (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D0161800345; Mon, 28 Sep 2026 12:08:45 +0000 (UTC) Date: Mon, 28 Sep 2026 13:08:42 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: Yonggang Luo , qemu-devel@nongnu.org, Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , "Edgar E. Iglesias" , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , Alistair Francis , Peter Maydell , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-arm@nongnu.org, kvm@vger.kernel.org Subject: Re: [PATCH v4 46/55] qapi: add query-targets Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20260926070057.1234-1-luoyonggang@gmail.com> <20260926070057.1234-47-luoyonggang@gmail.com> <87se2tfurc.fsf@pond.sub.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87se2tfurc.fsf@pond.sub.org> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 On Mon, Sep 28, 2026 at 02:03:19PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Sat, Sep 26, 2026 at 03:00:45PM +0800, Yonggang Luo wrote: > >> query-targets lists each linked target, including none, with its > >> arch, endianness, and the machines that target accepts. > >> > >> Signed-off-by: Yonggang Luo > >> --- > >> hw/core/machine-qmp-cmds.c | 30 ++++++++++++++++++++++++++++++ > >> qapi/machine.json | 35 +++++++++++++++++++++++++++++++++++ > >> 2 files changed, 65 insertions(+) > > > > > >> diff --git a/qapi/machine.json b/qapi/machine.json > >> index 6aaa2af709a..d8cdea6203e 100644 > >> --- a/qapi/machine.json > >> +++ b/qapi/machine.json > >> @@ -307,6 +307,41 @@ > >> ## > >> { 'command': 'query-target', 'returns': 'QemuTargetInfo' } > >> > >> +## > >> +# @TargetMachines: > >> +# > >> +# One registered system target and the machines that can run on it. > >> +# > >> +# @arch: the target architecture > >> +# > >> +# @endianness: the target endianness > >> +# > >> +# @machines: machine type names, not aliases > >> +# > >> +# Since: 11.2 > >> +## > >> +{ 'struct': 'TargetMachines', > >> + 'data': { 'arch': 'SysEmuTarget', > >> + 'endianness': 'EndianMode', > >> + 'machines': ['str'] } } > > > > We already have 'QemuTargetInfo' struct which is used > > with 'query-target', that should also be used with the > > new 'query-targets' command. > > > > We need to add the 'endianness' field to QemuTargetInfo. > > > > I don't think that we need to report machines though. > > We already have 'query-machines' which gives much broader > > information on the machines. "MachineInfo" needs to > > gain > > > > "targets": ["SysEmuTarget"] > > > > to list which target(s) a machine can be used with. > > Do we need query-targets at all? What information does it provide that > cannot easily be computed from query-machines once we add @target and > @endiannes to MachineInfo? Hmm, yes, I need to get out of the "target oriented" mindset, "machines" are the top level object of interest, and target just a property of each. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|